Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add npm script to strip l10n comments #3149

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Conversation

t1m0thyj
Copy link
Member

Proposed changes

Adds a script that strips comments out of bundle.l10n.json, sorts properties by key, and saves a new file bundle.l10n.json.template.

Use this command to run the script from top level of repo: pnpm --filter vscode-extension-for-zowe strip-l10n

Release Notes

Milestone: 3.0.0

Changelog: N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • All PR dependencies have been merged and published (if applicable)
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

Deployment

  • I have added developer documentation (if applicable)
  • Documentation should be added to Zowe Docs
    • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
    • Otherwise, please check with the rest of the squad about any needed documentation before merging.
  • These changes may need ported to the appropriate branches (list here):

Further comments

Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
@t1m0thyj t1m0thyj added the no-changelog Add to PR's that don't require a CHANGELOG update label Sep 24, 2024
Copy link

📅 Suggested merge-by date: 10/8/2024

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.77%. Comparing base (affdb40) to head (4d70f98).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3149   +/-   ##
=======================================
  Coverage   92.77%   92.77%           
=======================================
  Files         113      113           
  Lines       11662    11662           
  Branches     2593     2597    +4     
=======================================
  Hits        10819    10819           
  Misses        841      841           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zFernand0 zFernand0 mentioned this pull request Sep 24, 2024
15 tasks
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

The generated .template file keeps the comments as part of the keys while removing it from the values 🥳
Thanks @t1m0thyj 😋

image

Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Timothy for adding this script!

Copy link

@JillieBeanSim JillieBeanSim merged commit 06f1236 into main Sep 24, 2024
20 checks passed
@JillieBeanSim JillieBeanSim deleted the dev/add-strip-l10n-script branch September 24, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Add to PR's that don't require a CHANGELOG update size/S
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

4 participants