-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add npm script to strip l10n comments #3149
Conversation
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
📅 Suggested merge-by date: 10/8/2024 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3149 +/- ##
=======================================
Coverage 92.77% 92.77%
=======================================
Files 113 113
Lines 11662 11662
Branches 2593 2597 +4
=======================================
Hits 10819 10819
Misses 841 841
Partials 2 2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 😋
The generated .template
file keeps the comments as part of the keys while removing it from the values 🥳
Thanks @t1m0thyj 😋
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks Timothy for adding this script!
Quality Gate passedIssues Measures |
Proposed changes
Adds a script that strips comments out of
bundle.l10n.json
, sorts properties by key, and saves a new filebundle.l10n.json.template
.Use this command to run the script from top level of repo:
pnpm --filter vscode-extension-for-zowe strip-l10n
Release Notes
Milestone: 3.0.0
Changelog: N/A
Types of changes
Checklist
General
yarn workspace vscode-extension-for-zowe vscode:prepublish
pnpm --filter vscode-extension-for-zowe vscode:prepublish
Code coverage
Deployment
Further comments