Improve messaging when realm push notifications are not enabled #5785
Comments
|
@_Alya Abbott|19257 said:
|
|
Updated the issue with that change. |
|
On the "Notifications" screen, here's what the gray-shaded per-account area currently looks like when the server hasn't enabled notifications (
Quoting from the current issue description:
For this part—
—that's an easy change to the "not set up" row's text. ❓ When you tap the row, should it open the troubleshooting article, so you can learn what it means for push notifications to be enabled for your org? ❓ And for the "New setting" part, probably we want that setting to only appear when the server hasn't enabled push notifications, right? For this other part—
—I wonder if the change to be made is to add a link to the troubleshooting guide from the "Troubleshooting" page itself. ❓ Does that sound good? If not, I'd like some guidance on what change we want to make to the "Notifications" screen in cases where there's a problem other than |
One of the Role.Admin conditions had actually been going the wrong way, showing the admin message to non-admins and the non-admin message to admins. Fortunately that was on the notification troubleshooting screen, which you can't have reached unless the server had been set up for notifications earlier in the mobile app's session. Fixes-partly: zulip#5785
…tions
In particular, the message
> Push notifications are not enabled for {realmName}.
can now appear in these places:
- on the "Notifications" button in the settings screen
- in the dialog shown when you tap a warning icon on the active
account in the "Pick account" screen.
Before this, both of those places would just say:
> Notifications for this account may not arrive.
which was less definitive than we would like. (If the server hasn't
enabled push notifications, then they definitely won't arrive.)
In this commit, we also start using those same two places to give
other actionable feedback as it applies:
> Notifications are disabled in system settings.
> Notifications require Google Play Services, which is unavailable.
For the "Google Play Services" message, this commit also causes it
to appear on the "Troubleshooting" button in the notification
settings screen. (When the "not enabled for {realmName}" case or the
"disabled in system settings" case applies, the notification
settings screen already has appropriate messaging, since before this
commit, that doesn't involve the "Troubleshooting" button.)
Fixes-partly: zulip#5785
…tions" Fixes-partly: zulip#5785
And also on ServerCompatBanner, since it seems right to be consistent between the two banners. Fixes-partly: zulip#5785
…tions" Fixes-partly: zulip#5785
And also on ServerCompatBanner, since it seems right to be consistent between the two banners. Fixes-partly: zulip#5785
I think this heading would be most appropriate when notifications are not enabled on the server: https://zulip.com/help/mobile-notifications#enabling-push-notifications-for-self-hosted-servers |
I think the setting can always be there. There may be other reasons why users get nagged about push notifications, and they can just ignore it if they've never seen a banner. |
Sure, let's try that. |
Oh indeed, yeah. I just checked and that's actually the heading I ended up using in the PR :) |
One of the Role.Admin conditions had actually been going the wrong way, showing the admin message to non-admins and the non-admin message to admins. Fortunately that was on the notification troubleshooting screen, which you can't have reached unless the server had been set up for notifications earlier in the mobile app's session. Fixes-partly: zulip#5785
…tions
In particular, the message
> Push notifications are not enabled for {realmName}.
can now appear in these places:
- on the "Notifications" button in the settings screen
- in the dialog shown when you tap a warning icon on the active
account in the "Pick account" screen.
Before this, both of those places would just say:
> Notifications for this account may not arrive.
which was less definitive than we would like. (If the server hasn't
enabled push notifications, then they definitely won't arrive.)
In this commit, we also start using those same two places to give
other actionable feedback as it applies:
> Notifications are disabled in system settings.
> Notifications require Google Play Services, which is unavailable.
For the "Google Play Services" message, this commit also causes it
to appear on the "Troubleshooting" button in the notification
settings screen. (When the "not enabled for {realmName}" case or the
"disabled in system settings" case applies, the notification
settings screen already has appropriate messaging, since before this
commit, that doesn't involve the "Troubleshooting" button.)
Fixes-partly: zulip#5785
…tions" Fixes-partly: zulip#5785
And also on ServerCompatBanner, since it seems right to be consistent between the two banners. Fixes-partly: zulip#5785
One of the Role.Admin conditions had actually been going the wrong way, showing the admin message to non-admins and the non-admin message to admins. Fortunately that was on the notification troubleshooting screen, which you can't have reached unless the server had been set up for notifications earlier in the mobile app's session. Fixes-partly: zulip#5785
…tions
In particular, the message
> Push notifications are not enabled for {realmName}.
can now appear in these places:
- on the "Notifications" button in the settings screen
- in the dialog shown when you tap a warning icon on the active
account in the "Pick account" screen.
Before this, both of those places would just say:
> Notifications for this account may not arrive.
which was less definitive than we would like. (If the server hasn't
enabled push notifications, then they definitely won't arrive.)
In this commit, we also start using those same two places to give
other actionable feedback as it applies:
> Notifications are disabled in system settings.
> Notifications require Google Play Services, which is unavailable.
For the "Google Play Services" message, this commit also causes it
to appear on the "Troubleshooting" button in the notification
settings screen. (When the "not enabled for {realmName}" case or the
"disabled in system settings" case applies, the notification
settings screen already has appropriate messaging, since before this
commit, that doesn't involve the "Troubleshooting" button.)
Fixes-partly: zulip#5785
…tions" Fixes-partly: zulip#5785
And also on ServerCompatBanner, since it seems right to be consistent between the two banners. Fixes-partly: zulip#5785
There are several places in the mobile app where we communicate that a user will not receive push notifications when
realm_push_notifications_enabledisfalse. We should improve the messaging and flows for those notifications.Home screen banner
Notice in Settings (Notifications button)
Notice on login screen
Notifications screen
Notices
Just in the case of
realm_push_notifications_enabled = false: "Push notifications are not enabled for {realmName}."For all situations where we warn that notifications may not be working: "View trouble-shooting guide for mobile push notifications."
New setting
A switch labeled: "Silence warnings about disabled mobile push notifications" (off by default)
If you enable the switch, the warning banner on the home screen and the notice on the login screen are turned off. (The info is still available in the settings.)
The text was updated successfully, but these errors were encountered: