Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Live-update push_notifications_enabled, newly included in realm update events #5805

Closed
chrisbobbe opened this issue Dec 20, 2023 · 0 comments · Fixed by #5807
Closed

Live-update push_notifications_enabled, newly included in realm update events #5805

chrisbobbe opened this issue Dec 20, 2023 · 0 comments · Fixed by #5807
Labels
P1 high-priority

Comments

@chrisbobbe
Copy link
Contributor

chrisbobbe commented Dec 20, 2023 •
edited
Loading

See API changelog entry for FL 231:

GET /events: A realm update event is now sent whenever push_notifications_enabled or push_notifications_enabled_end_timestamp changes.

We should recognize and handle changes to push_notifications_enabled, stored in RealmState as pushNotificationsEnabled. (We don't yet store push_notifications_enabled_end_timestamp.)
@chrisbobbe chrisbobbe mentioned this issue Dec 20, 2023
Merged
chrisbobbe added a commit to chrisbobbe/zulip-mobile that referenced this issue Dec 20, 2023
@chrisbobbe
notifs: Live-update state of whether realm has enabled notifications
4152ab7 
Making sure that when the realm goes from disabling to enabling
notifications, we clear out the state of whether the user has
dismissed the banner on the home screen -- just like we do when the
/register response informs us of this change. That's so that if
notifications become disabled again, a new banner will be shown.

Fixes: zulip#5805
@chrisbobbe chrisbobbe mentioned this issue Dec 20, 2023
Merged
chrisbobbe added a commit to chrisbobbe/zulip-mobile that referenced this issue Dec 27, 2023
@chrisbobbe
notifs: Live-update state of whether realm has enabled notifications
c46625f 
Making sure that when the realm goes from disabling to enabling
notifications, we clear out the state of whether the user has
dismissed the banner on the home screen -- just like we do when the
/register response informs us of this change. That's so that if
notifications become disabled again, a new banner will be shown.

Fixes: zulip#5805
chrisbobbe added a commit that referenced this issue Jan 5, 2024
@chrisbobbe
changelog: Add "plus other fixes" line to 27.222
d27668e 
The changes in #5785 and #5805 will be user-visible, but probably
not worthy of highlighting explicitly in the user notes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P1 high-priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

notifs: Live-update state of whether realm has enabled notifications chrisbobbe/zulip-mobile
1 participant
@chrisbobbe