Followups from #4679 #4768
Merged
Followups from #4679 #4768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this needs a rebase past #4750 which added a |
|
Ah, yep! Thanks for catching that, done. |
This makes the OptionRow always the same height, regardless of whether there's an icon or not. As far as I can tell, this doesn't change any of the current uses of OptionRow (since almost all of them currently use icons). The value of 56 was discovered by inspecting OptionRows with icons - since RNVI uses font-size instead of width/height, there isn't a nice way to get the height of an icon from its size. This is in preparation for removing some icons from the settings screen.
Since the "Chrome" icon for the in-app browser setting was confusing, remove that icon. And since it looks strange to have icons on some but not all settings, this also removes the icon for "Night Mode", leaving us with icons only for groups of settings, not individual settings.
|
Looks good, thanks! Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4766