Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Followups from #4679 #4768

Merged
merged 5 commits into from
Jun 9, 2021
Merged

Followups from #4679 #4768

merged 5 commits into from
Jun 9, 2021

Commits on Jun 9, 2021

  1. openLink [nfc]: Add jsdocs.

    @WesleyAC @gnprice
    WesleyAC authored and gnprice committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    f613cf1 View commit details
    Browse the repository at this point in the history

  2. openLink [nfc]: Take SettingsState instead of GetState.

    @WesleyAC @gnprice
    WesleyAC authored and gnprice committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    82d6c15 View commit details
    Browse the repository at this point in the history

  3. OptionRow: Make height the same regardless of icon. 

    This makes the OptionRow always the same height, regardless of whether
there's an icon or not. As far as I can tell, this doesn't change any of
the current uses of OptionRow (since almost all of them currently use
icons).

The value of 56 was discovered by inspecting OptionRows with icons -
since RNVI uses font-size instead of width/height, there isn't a nice
way to get the height of an icon from its size.

This is in preparation for removing some icons from the settings screen.
    @WesleyAC @gnprice
    WesleyAC authored and gnprice committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    f5b05ae View commit details
    Browse the repository at this point in the history

  4. settings: Remove icons from top-level settings. 

    Since the "Chrome" icon for the in-app browser setting was confusing,
remove that icon. And since it looks strange to have icons on some but
not all settings, this also removes the icon for "Night Mode", leaving
us with icons only for groups of settings, not individual settings.
    @WesleyAC @gnprice
    WesleyAC authored and gnprice committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    6cf9ced View commit details
    Browse the repository at this point in the history

  5. reduxTypes [nfc]: Fix BrowserPreference jsdoc.

    @WesleyAC @gnprice
    WesleyAC authored and gnprice committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    c897133 View commit details
    Browse the repository at this point in the history