Improve messaging when realm push notifications are not enabled #5802
Commits on Jan 4, 2024
-
NotifTroubleshootingScreen: Revise text for Google Play Services warning
I suppose the Services could be available on the device, just disabled or otherwise made unavailable to Zulip.
-
notifs [nfc]: Add inheritColor, inheritFontSize to some nested ZulipT…
…exts These all seem to have gotten the right size and color by accident, from global defaults. But given ZulipText's API, passing both of these is the right pattern for these subparts of UI strings. We never intend to discard a locally chosen color or font size just because we're putting a dynamic value into a translated UI string.
-
AlertItem: Make text regular weight, not bold
In the message for NotificationProblem.ServerHasNotEnabled, we'd like to make the realm name bold. Now, when we do that, its weight will still be distinct.
-
notifs: Revise "server not set up" message; drop condition on Role.Admin
One of the Role.Admin conditions had actually been going the wrong way, showing the admin message to non-admins and the non-admin message to admins. Fortunately that was on the notification troubleshooting screen, which you can't have reached unless the server had been set up for notifications earlier in the mobile app's session. Fixes-partly: zulip#5785
-
-
notifs [nfc]: Factor out notifProblemsShortText, from …ShortReactText
We'll use this soon for a caller that needs a LocalizableText and can't use a LocalizableReactText.
-
notifs: Show in more places that the org hasn't enabled push notifica…
…tions In particular, the message > Push notifications are not enabled for {realmName}. can now appear in these places: - on the "Notifications" button in the settings screen - in the dialog shown when you tap a warning icon on the active account in the "Pick account" screen. Before this, both of those places would just say: > Notifications for this account may not arrive. which was less definitive than we would like. (If the server hasn't enabled push notifications, then they definitely won't arrive.) In this commit, we also start using those same two places to give other actionable feedback as it applies: > Notifications are disabled in system settings. > Notifications require Google Play Services, which is unavailable. For the "Google Play Services" message, this commit also causes it to appear on the "Troubleshooting" button in the notification settings screen. (When the "not enabled for {realmName}" case or the "disabled in system settings" case applies, the notification settings screen already has appropriate messaging, since before this commit, that doesn't involve the "Troubleshooting" button.) Fixes-partly: zulip#5785 -
ServerPushSetupBanner: "Learn more" dismisses banner, opens "Notifica…
…tions" Fixes-partly: zulip#5785
-
ServerPushSetupBanner: Change "Remind me later" button text to "Dismiss"
And also on ServerCompatBanner, since it seems right to be consistent between the two banners. Fixes-partly: zulip#5785
-
-
NotifTroubleshootingScreen: Use rows in a group, instead of ZulipButtons
We're about to add a link to the notification troubleshooting guide, and it seems cleanest to do these as rows instead of ZulipButtons.
-
redux types: Remove DismissServerPushSetupNoticeAction from AllAccoun…
…tsAction This doesn't belong here. It's already present in the PerAccountAction union, so nothing to do after removing it here.
-
NotifTroubleshootingScreen: Have genericAlert mention troubleshooting…
… guide As suggested by Alya: zulip#5802 (comment)
