SettingsScreen: Translate languages' names into selected language #5843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These used to be translated, but then we accidentally stopped in a483f56 about a year ago. Oops; fix.
It looks odd to have an item where the title and subtitle are slightly different ways of naming the same thing. The canonical self-name is the one we've chosen by following organizations with a broad global contributor base like Wikipedia, so use that. (We could instead just omit the subtitle, but if we did, then all the rows in the list would have two lines of text except the selected row which would have just one. And that non-uniformity might look odd.)
gnprice
force-pushed
the
pr-language-names
branch
from
0057e10
to
630caee
Compare
|
Thanks! Merged, with some commit-message tweaks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.