Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): add missing parameter 9 to Logic Group ZDB5100 #5690

Merged
merged 3 commits into from
Apr 28, 2023

Conversation

LordMike
Copy link
Contributor

@LordMike LordMike commented Apr 21, 2023

In firmware 1.8 of the Logic Group ZDB5100, parameter 9 was added to control the brightness on the next turning on of the switch.

The setting has two ranges besides 0 for "No effect": 1-99 to affect only the next turning on, and 129-228 to affect every turning on. I picked an option type with manual input allowed, but maybe something else is better suited? I tried to communicate the specifics in description

@zwave-js-assistant zwave-js-assistant bot added the config ⚙ Configuration issues or updates label Apr 21, 2023
@LordMike LordMike changed the title feat(config): Add missing parameter 9 to Logic Group ZDB5100 feat(config): add missing parameter 9 to Logic Group ZDB5100 Apr 21, 2023
In firmware 1.08, parameter 9 was added to control the brightness on the next turning on of the switch.
Copy link
Member

@AlCalzone AlCalzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok with my changes

@AlCalzone AlCalzone enabled auto-merge (squash) April 28, 2023 10:55
@AlCalzone AlCalzone merged commit 30653a2 into zwave-js:master Apr 28, 2023
@LordMike LordMike deleted the zdb5100-add-param9 branch April 28, 2023 22:30
AlCalzone added a commit that referenced this pull request May 3, 2023
### Features
* Implemented a `mock-server` binary to expose a simulated controller via TCP for application testing (#5714)

### Bugfixes
* Several fixes and polishing for `Window Covering CC` (#5735, #5741)
* Fixed a race condition on Windows systems between the serial port and state machine that could cause the communication with the Z-Wave stick to fail (#5737)
* When no other actuator CCs are supported, `Basic CC` is now queried even if not advertised (#5730)
* The daily Entry Lock schedule is now only parsed if any weekday is selected (#5732)
* Support inicoming `Transport Service CCs` with unequal fragment sizes (#5731)
* Do not encapsulate CRC16 or Transport Service in Security S0/S2 (#5731)
* Disconnects of TCP sockets are detected again (#5715)

### Config file changes
* Disable periodic refresh for Shenzhen Neo NAS-PD03Z (#5739)
* Add missing parameter 9 to Logic Group ZDB5100 (#5690)
* Add new parameters 10-13 to Zooz ZEN04 (#5689)
* Force-add Battery CC support for EcoNet Controls EV100 (#5712)

### Changes under the hood
* Fixed the `watch` task on Windows systems
* Add compat flag to disable periodic value refreshes (#5738)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config ⚙ Configuration issues or updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants