fix: decouple reading the serialport from handling the data #5737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zwave-js-bot automerge |
zwave-js-bot
previously approved these changes
May 3, 2023
zwave-js-bot
approved these changes
May 3, 2023
AlCalzone
added a commit
that referenced
this pull request
May 3, 2023
### Features * Implemented a `mock-server` binary to expose a simulated controller via TCP for application testing (#5714) ### Bugfixes * Several fixes and polishing for `Window Covering CC` (#5735, #5741) * Fixed a race condition on Windows systems between the serial port and state machine that could cause the communication with the Z-Wave stick to fail (#5737) * When no other actuator CCs are supported, `Basic CC` is now queried even if not advertised (#5730) * The daily Entry Lock schedule is now only parsed if any weekday is selected (#5732) * Support inicoming `Transport Service CCs` with unequal fragment sizes (#5731) * Do not encapsulate CRC16 or Transport Service in Security S0/S2 (#5731) * Disconnects of TCP sockets are detected again (#5715) ### Config file changes * Disable periodic refresh for Shenzhen Neo NAS-PD03Z (#5739) * Add missing parameter 9 to Logic Group ZDB5100 (#5690) * Add new parameters 10-13 to Zooz ZEN04 (#5689) * Force-add Battery CC support for EcoNet Controls EV100 (#5712) ### Changes under the hood * Fixed the `watch` task on Windows systems * Add compat flag to disable periodic value refreshes (#5738)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #5024
It seems that serialport v10 on Windows behaves differently than on Linux and older serialport versions on Windows - possibly lagging the event loop or something similar. After the upgrade, the state machine was sometimes still in the old state and hasn't progressed yet. This caused some message tests to use the old state and fail / consider the message unsolicited/unexpected.
After delaying the data handling using
setImmediate, I can no longer reproduce the issue - so I hope this is actually fixed now.