Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future Enhancements #1

Closed
10 tasks done
zz85 opened this issue Dec 29, 2014 · 10 comments
Closed
10 tasks done

Future Enhancements #1

zz85 opened this issue Dec 29, 2014 · 10 comments

Comments

@zz85
Copy link
Owner

zz85 commented Dec 29, 2014

Expanding from commit message 09925d9 here are a couple ideas to improve this tool:

release 1.0 !!!

Feel free to make suggestions or PRs :D

@gero3
Copy link
Collaborator

gero3 commented Dec 30, 2014

@zz85
Do you mind using an experimental version of autoformatter?? Other wise I could update formatter to make it work with this version. I tested the formatter before on three.min.js and there were only some minor issues left.

@zz85
Copy link
Owner Author

zz85 commented Dec 30, 2014

yes, i wouldn't mind. i also realize there have been some recent changes in jscs that some rules aren't working eg spaces between parenthesis.

@gero3, which is your latest working copy right now?

@gero3
Copy link
Collaborator

gero3 commented Dec 30, 2014

A local version for the moment but the one I linked to shouldn't be far behind. It still has a problem with whitespacing tough. I'll see if I can make a version today.

A small suggestion would to also have diff library then, to actually highlight the proposed changes.

For systax highlighting, I wouldn't use anything fancy, Prettify should be good enough, I think.

@zz85
Copy link
Owner Author

zz85 commented Dec 30, 2014

Diffing sounds like a good idea. I'll take a look at prettify but I was
thinking CodeMirror is a good candidate as it supports warning messages in
the gutter like any good editor/ide

@zz85 zz85 mentioned this issue Dec 31, 2014
@gero3
Copy link
Collaborator

gero3 commented Dec 31, 2014

Dropping source files already works in codemirror.

@zz85
Copy link
Owner Author

zz85 commented Dec 31, 2014

@gero3 nice observation! it relatively easy for me to add a "click to browse" button too though.

@zz85
Copy link
Owner Author

zz85 commented Jan 1, 2015

Happy new year all! I'm actually pretty satisfied with where things are right now - given this was started 3 days ago, we already have 14 PRs merged, thanks largely to the efforts of @gero3 (and probably this "PR-driven-development").

There are only a couple more checkboxes here to strike off, and I think we should stamp a v1.0 for the new year and probably move on to do other greater stuff. Just before we do that, there's just a couple more things

  1. adding the browse/open file feature
  2. getting Spaces Required Between Array Expressions #19 and Spaces required in { key: values } #20 resolved
  3. bundling / minifying the js file to make loads faster
  4. blog about this

i'll work on 1,2,4 and we should soon be able to give ourselves a pat on the back and call it a day (until #22). 😀

@gero3
Copy link
Collaborator

gero3 commented Jan 1, 2015

Happy new year 🎉. I fixed issues #19 and #20 in #23.
I'll see if I can make time today to strike off bundling / minifying the js file to make loads faster.

@zz85
Copy link
Owner Author

zz85 commented Jan 1, 2015

thanks... and oops i think i mean't 1, 3, 4 just now. also one more thing which we should do is run code-formatter on our code to clean them out :)

@zz85
Copy link
Owner Author

zz85 commented Jan 25, 2015

Closing with blog post and release 1.0 :)

@zz85 zz85 closed this as completed Jan 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants