First version of formatting #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, I'll take a look at that when I get back home |
Conflicts: index.html
|
Auto formatting is great... but the issues with white spacing 😿 ... but with formatting, i think it also motives me more code mirror should be use, since it does support the diff plugin too. |
|
@gero3 i think we can merge this? we'll can deal with the white-spacing issue later... |
|
We should do that since I've been having problems with it before. I'll have to take my time to look at it. |
|
checking works great, thanks! would you be making a PR for the mdcs preset in node-jscs too? i'll merge this first and try adding code-mirror support... |
|
yep I'll create a PR in node-jscs. |
|
👍 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first try at formatting the code.
It uses the latest version of jscs and the old code i had from months ago. It still has som minor issues but it works even on the webglrenderer file altough it takes a second or 2.
A preview is here:
https://preview.c9.io/gero3/mrdoobapproves/index.html