Remove CollateralCurrencyIds from module-cdp-engine #2096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated tests and configs accordingly
Updated tests accordingly.
…lType Updated code and tests accordingly
Now uses CollateralParams to determine valid collateral currencies.
…rrencyIds * origin/master: add xcm instruction RefundSurplus after Transact (#2088) rm dex share duplicate code (#2089) precompile (#2049) Remove honzon global paramter (#2071) update orml (#2077) Auto publish predeploy contracts (#2076) # Conflicts: # modules/cdp-engine/src/lib.rs # modules/cdp-engine/src/tests.rs # runtime/acala/src/lib.rs
Codecov Report
@@ Coverage Diff @@
## master #2096 +/- ##
==========================================
+ Coverage 86.45% 86.64% +0.19%
==========================================
Files 99 98 -1
Lines 21240 21141 -99
==========================================
- Hits 18362 18317 -45
+ Misses 2878 2824 -54
Continue to review full report at Codecov.
|
xlc
reviewed
May 10, 2022
xlc
approved these changes
May 10, 2022
ferrell-code
approved these changes
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A list of valid collateral currencies are obtained from configured currency parameters
Added ACA as collateral in Mandala. This needs to be configured after upgrade.
Closes #2069