Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leaking when loading data #17758

Merged
merged 2 commits into from
Jul 13, 2023

Conversation

Haoning-Sun
Copy link
Contributor

What changes are proposed in this pull request?

Release buffer when an exception occurs.

Why are the changes needed?

Fix memory leaking.

@Haoning-Sun Haoning-Sun force-pushed the fix/fix-memory-leaking branch 2 times, most recently from ea47289 to 943518c Compare July 11, 2023 09:33
@Haoning-Sun Haoning-Sun changed the title Release buffer when an exception occurs Fix memory leaking when loading data Jul 11, 2023
Copy link
Contributor

@jja725 jja725 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix

@jja725 jja725 self-requested a review July 12, 2023 17:57
@Haoning-Sun Haoning-Sun requested a review from jja725 July 13, 2023 03:41
Copy link
Contributor

@jja725 jja725 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jja725
Copy link
Contributor

jja725 commented Jul 13, 2023

alluxio-bot, merge this please

@alluxio-bot
Copy link
Contributor

merge failed:
Merge refused because pull request does not have label start with type-

@jja725 jja725 added the type-bug This issue is about a bug label Jul 13, 2023
@jja725
Copy link
Contributor

jja725 commented Jul 13, 2023

alluxio-bot, merge this please

@alluxio-bot alluxio-bot merged commit 2b83d95 into Alluxio:master-2.x Jul 13, 2023
17 checks passed
humengyu2012 added a commit to humengyu2012/alluxio that referenced this pull request Jul 17, 2023
humengyu2012 added a commit to humengyu2012/alluxio that referenced this pull request Jul 17, 2023
Fix memory leaking when loading data: Alluxio#17758

See merge request data-infra/alluxio!42
alluxio-bot added a commit that referenced this pull request Nov 8, 2023
### What changes are proposed in this pull request?
Merge missing commits from master-2.x to main. The commits in 2023/07/01~2023/11/08 from main...master-2.x will be included by this PR.

We do this merge to catch missing fixes from `master-2.x` and catch the train before `main` cuts a release.

#17747 is not cherry picked because tencent cloud EMR doc is removed
#17755 is not cherry picked because DistLoadCliRunner has been removed in 3.x
#17758 is not cherry picked because MonoBlockStore has been removed in 3.x
#17641 is not cherry picked because the PR has already been in main
#17781 is not cherry picked because the PR has already been in main
#17722 is not cherry picked because the alluxio-fuse command has been changed a lot
#17489 is not cherry picked because audit log on master is no longer in 3.x
#17865 is not cherry picked because replication on job service is no longer in 3.x
#17858 is not cherry picked because it is already in main
#18090 is not cherry picked because generate-tarball has been rewritten in 3.x
#18091 is not cherry picked because the change is already in main
#17474 is not cherry picked because reconfiguration feature is not defined in 3.x
#17735 is not cherry picked because MonoBlockStore is no longer in 3.x
#18133 is not cherry picked because the issue is about master metadata and no longer relevant in 3.x
#17910 is not cherry picked because I prefer to do that manually
#17983 is not cherry picked because the web UI has been reworked
#17984 is not cherry picked because Mount/Unmount commands have been reworked in 3.x
#18103 is not cherry picked because worker cache metrics have been reworked in 3.x
#18185 is not cherry picked because the report command has been reworked in 3.x
#18222 is not cherry picked because Mount/Unmount operations have been reworked in 3.x
#18143 is not cherry picked because the change is already in main
#18303 is not cherry picked because the change is already in main
#18208 is not cherry picked because cache metrics have been reworked in 3.x
#17002 is not cherry picked because the owner has been notified separately
#18334 is not cherry picked because the bash scripts have been reworked in 3.x
#18326 is not cherry picked because the owner has been notified separately

			pr-link: #18397
			change-id: cid-dbf8cbb2d9e721a5a0a1e5028a3c9577438a2ac0
@ccy00808
Copy link
Contributor

alluxio-bot, cherry-pick this to enterprise-2.10 please

@alluxio-bot
Copy link
Contributor

Auto cherry-pick unsuccessful Failed to setup local git for auto cherry-pick

@ccy00808
Copy link
Contributor

alluxio-bot, cherry-pick this to branch-2.10 please

alluxio-bot pushed a commit that referenced this pull request Apr 28, 2024
### What changes are proposed in this pull request?

Release buffer when an exception occurs.

### Why are the changes needed?
Fix memory leaking.

			pr-link: #17758
			change-id: cid-b5e9e655aff744b04d3187687a62dbaed6754186
@alluxio-bot
Copy link
Contributor

Auto cherry-pick to branch branch-2.10 successfully opened PR: #18592

alluxio-bot added a commit that referenced this pull request Apr 28, 2024
Cherry-pick of existing commit.
orig-pr: #17758
orig-commit: 2b83d95
orig-commit-author: Haoning Sun <msunhaoning@163.com>

			pr-link: #18592
			change-id: cid-b5e9e655aff744b04d3187687a62dbaed6754186
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug This issue is about a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants