Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change CosNUnderFileSystemFactory implementation UnderFileSystemFactory #18143

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Change CosNUnderFileSystemFactory implementation UnderFileSystemFactory #18143

merged 1 commit into from
Oct 17, 2023

Conversation

gp1314
Copy link
Contributor

@gp1314 gp1314 commented Sep 13, 2023 •
edited
Loading

What changes are proposed in this pull request?

  • Don't have to inherit the HdfsUnderFileSystemFactory CosNUnderFileSystemFactory directly implement UnderFileSystemFactory interface

Why are the changes needed?

  • Possibly to resolve package conflicts, Remove HdfsUnderFileSystemFactory from service loading in COSN UFS jar #17024 removed HdfsUnderFileSystemFactory from COSN UFS jar, resulting in inability to use COSN interface
  • However, CosNUnderFileSystemFactory inherits from HdfsUnderFileSystemFactory,the ServiceLoader.load method loads CosNUnderFileSystemFactory and first searches for its parent class, so removing HdfsUnderFileSystemFactory directly will result in an error.
failed to load jar alluxio-underfs-hadoop-cosn-3.1.0-5.8.5-2.9.3.jar NoClassdDefFoundError :alluxio/underfs/hdfs/HdfsUnderFileSystemFactory

@alluxio-bot
Copy link
Contributor

Automated checks report:

  • PR title follows the conventions: FAIL
    • The title of the PR does not pass all the checks. Please fix the following issues:
      • First word of title ("After") is not an imperative verb. Please use one of the valid words
  • Commits associated with Github account: FAIL
    • It looks like your commits can't be linked to a valid Github account.
      Your commits are made with the email gupeng@gupengdeMacBook-Pro.local, which does not allow your contribution to be tracked by Github.
      See this link for possible reasons this might be happening.
      To change the author email address that your most recent commit was made under, you can run: 
      git -c user.name="Name" -c user.email="Email" commit --amend --reset-author
      See this answer for more details about how to change commit email addresses.
      Once the author email address has been updated, update the pull request by running: 
      git push --force https://github.com/gp1314/alluxio.git dev/gup/support_cosn

Some checks failed. Please fix the reported issues and reply 'alluxio-bot, check this please' to re-run checks.

@gp1314 gp1314 changed the title After removing HdfsUnderFileSystemFactory COSN support CosNUnderFileSystemFactory implementation UnderFileSystemFactory Sep 13, 2023
@gp1314
Copy link
Contributor Author

gp1314 commented Sep 13, 2023

alluxio-bot, check this please

@alluxio-bot
Copy link
Contributor

Automated checks report:

  • PR title follows the conventions: FAIL
    • The title of the PR does not pass all the checks. Please fix the following issues:
      • First word of title ("CosNUnderFileSystemFactory") is not an imperative verb. Please use one of the valid words
  • Commits associated with Github account: FAIL
    • It looks like your commits can't be linked to a valid Github account.
      Your commits are made with the email gupeng@gupengdeMacBook-Pro.local, which does not allow your contribution to be tracked by Github.
      See this link for possible reasons this might be happening.
      To change the author email address that your most recent commit was made under, you can run: 
      git -c user.name="Name" -c user.email="Email" commit --amend --reset-author
      See this answer for more details about how to change commit email addresses.
      Once the author email address has been updated, update the pull request by running: 
      git push --force https://github.com/gp1314/alluxio.git dev/gup/support_cosn

Some checks failed. Please fix the reported issues and reply 'alluxio-bot, check this please' to re-run checks.

@gp1314 gp1314 changed the title CosNUnderFileSystemFactory implementation UnderFileSystemFactory Change CosNUnderFileSystemFactory implementation UnderFileSystemFactory Sep 13, 2023
@gp1314
Copy link
Contributor Author

gp1314 commented Sep 13, 2023

alluxio-bot, check this please

@alluxio-bot
Copy link
Contributor

Automated checks report:

  • PR title follows the conventions: PASS
  • Commits associated with Github account: FAIL
    • It looks like your commits can't be linked to a valid Github account.
      Your commits are made with the email gupeng@gupengdeMacBook-Pro.local, which does not allow your contribution to be tracked by Github.
      See this link for possible reasons this might be happening.
      To change the author email address that your most recent commit was made under, you can run: 
      git -c user.name="Name" -c user.email="Email" commit --amend --reset-author
      See this answer for more details about how to change commit email addresses.
      Once the author email address has been updated, update the pull request by running: 
      git push --force https://github.com/gp1314/alluxio.git dev/gup/support_cosn

Some checks failed. Please fix the reported issues and reply 'alluxio-bot, check this please' to re-run checks.

@alluxio-bot
Copy link
Contributor

Automated checks report:

  • PR title follows the conventions: PASS
  • Commits associated with Github account: PASS

All checks passed!

maobaolong
maobaolong approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@maobaolong maobaolong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense. LGTM. Thanks for your contribution

@gp1314
Copy link
Contributor Author

gp1314 commented Sep 27, 2023

@jiacheliu3 can you help merge?

Jackson-Wang-7
Jackson-Wang-7 approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@Jackson-Wang-7 Jackson-Wang-7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jiacheliu3
Copy link
Contributor

alluxio-bot, merge this please

@alluxio-bot
Copy link
Contributor

merge failed:
Merge refused because pull request does not have label start with type-

@jiacheliu3 jiacheliu3 added type-bug This issue is about a bug area-ufs Under File Storage labels Oct 17, 2023
@jiacheliu3
Copy link
Contributor

alluxio-bot, merge this please

@alluxio-bot alluxio-bot merged commit 057804e into Alluxio:master-2.x Oct 17, 2023
19 checks passed
@jiacheliu3
Copy link
Contributor

alluxio-bot, cherry-pick this to main please

@alluxio-bot
Copy link
Contributor

Auto cherry-pick to branch main successfully opened PR: #18279

@alluxio-bot alluxio-bot mentioned this pull request Oct 17, 2023
Merged
alluxio-bot pushed a commit that referenced this pull request Oct 17, 2023
@gp1314 @alluxio-bot
Change CosNUnderFileSystemFactory implementation UnderFileSystemFactory
0802c1a 
### What changes are proposed in this pull request?

- Don't have to inherit the HdfsUnderFileSystemFactory CosNUnderFileSystemFactory directly implement UnderFileSystemFactory interface


### Why are the changes needed?

- Possibly to resolve package conflicts, #17024 removed HdfsUnderFileSystemFactory from COSN UFS jar, resulting in inability to use COSN interface
- However, CosNUnderFileSystemFactory inherits from HdfsUnderFileSystemFactory,the ServiceLoader.load method loads CosNUnderFileSystemFactory and first searches for its parent class, so removing HdfsUnderFileSystemFactory directly will result in an error.
```
failed to load jar alluxio-underfs-hadoop-cosn-3.1.0-5.8.5-2.9.3.jar NoClassdDefFoundError :alluxio/underfs/hdfs/HdfsUnderFileSystemFactory
```




			pr-link: #18143
			change-id: cid-4a80f6cdeae5b9bdb9e956c36838403ee6ce7c46
alluxio-bot added a commit that referenced this pull request Oct 17, 2023
@alluxio-bot
Change CosNUnderFileSystemFactory implementation UnderFileSystemFactory
b597c61 
Cherry-pick of existing commit.
orig-pr: #18143
orig-commit: 057804e
orig-commit-author: gp1314 <814085234@qq.com>

			pr-link: #18279
			change-id: cid-4a80f6cdeae5b9bdb9e956c36838403ee6ce7c46
@jiacheliu3 jiacheliu3 mentioned this pull request Oct 27, 2023
Merged
alluxio-bot pushed a commit that referenced this pull request Oct 27, 2023
@maobaolong
Fix cosn ufs cannot find class
5fee8fb 
Fix bug involved by #17024

After #18143, `HdfsUnderFileSystemFactory` is no longer included in COSN jar therefore no need to exclude.
			pr-link: #18303
			change-id: cid-6931be7291f52728022e4555d1c7183857948b9f
@maobaolong maobaolong mentioned this pull request Oct 29, 2023
Merged
alluxio-bot pushed a commit that referenced this pull request Nov 7, 2023
@maobaolong
Fix cosn ufs cannot find class
8d3ab67 
Fix bug involved by #17024

After #18143, HdfsUnderFileSystemFactory is no longer included in COSN jar therefore no need to exclude.

Same PR as #18303 but pushing to the main branch
			pr-link: #18336
			change-id: cid-c79454f41157781a29fb04d6067ea8cf16520977
@jiacheliu3 jiacheliu3 mentioned this pull request Nov 8, 2023
Merged
alluxio-bot added a commit that referenced this pull request Nov 8, 2023
@alluxio-bot
Merge master-2.x commits 2023/07/01~2023/11/08 into main
c2f4cd2 
### What changes are proposed in this pull request?
Merge missing commits from master-2.x to main. The commits in 2023/07/01~2023/11/08 from main...master-2.x will be included by this PR.

We do this merge to catch missing fixes from `master-2.x` and catch the train before `main` cuts a release.

#17747 is not cherry picked because tencent cloud EMR doc is removed
#17755 is not cherry picked because DistLoadCliRunner has been removed in 3.x
#17758 is not cherry picked because MonoBlockStore has been removed in 3.x
#17641 is not cherry picked because the PR has already been in main
#17781 is not cherry picked because the PR has already been in main
#17722 is not cherry picked because the alluxio-fuse command has been changed a lot
#17489 is not cherry picked because audit log on master is no longer in 3.x
#17865 is not cherry picked because replication on job service is no longer in 3.x
#17858 is not cherry picked because it is already in main
#18090 is not cherry picked because generate-tarball has been rewritten in 3.x
#18091 is not cherry picked because the change is already in main
#17474 is not cherry picked because reconfiguration feature is not defined in 3.x
#17735 is not cherry picked because MonoBlockStore is no longer in 3.x
#18133 is not cherry picked because the issue is about master metadata and no longer relevant in 3.x
#17910 is not cherry picked because I prefer to do that manually
#17983 is not cherry picked because the web UI has been reworked
#17984 is not cherry picked because Mount/Unmount commands have been reworked in 3.x
#18103 is not cherry picked because worker cache metrics have been reworked in 3.x
#18185 is not cherry picked because the report command has been reworked in 3.x
#18222 is not cherry picked because Mount/Unmount operations have been reworked in 3.x
#18143 is not cherry picked because the change is already in main
#18303 is not cherry picked because the change is already in main
#18208 is not cherry picked because cache metrics have been reworked in 3.x
#17002 is not cherry picked because the owner has been notified separately
#18334 is not cherry picked because the bash scripts have been reworked in 3.x
#18326 is not cherry picked because the owner has been notified separately

			pr-link: #18397
			change-id: cid-dbf8cbb2d9e721a5a0a1e5028a3c9577438a2ac0
ssz1997 pushed a commit to ssz1997/alluxio that referenced this pull request Dec 15, 2023
@alluxio-bot @ssz1997
Change CosNUnderFileSystemFactory implementation UnderFileSystemFactory
fc245e8 
Cherry-pick of existing commit.
orig-pr: Alluxio#18143
orig-commit: Alluxio/alluxio@057804e
orig-commit-author: gp1314 <814085234@qq.com>

			pr-link: Alluxio#18279
			change-id: cid-4a80f6cdeae5b9bdb9e956c36838403ee6ce7c46
ssz1997 pushed a commit to ssz1997/alluxio that referenced this pull request Dec 15, 2023
@maobaolong @ssz1997
Fix cosn ufs cannot find class
9a5d862 
Fix bug involved by Alluxio#17024

After Alluxio#18143, HdfsUnderFileSystemFactory is no longer included in COSN jar therefore no need to exclude.

Same PR as Alluxio#18303 but pushing to the main branch
			pr-link: Alluxio#18336
			change-id: cid-c79454f41157781a29fb04d6067ea8cf16520977
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acelyc111 acelyc111 acelyc111 approved these changes

@maobaolong maobaolong maobaolong approved these changes

@Jackson-Wang-7 Jackson-Wang-7 Jackson-Wang-7 approved these changes

Assignees
No one assigned
Labels
area-ufs Under File Storage type-bug This issue is about a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gp1314 @alluxio-bot @jiacheliu3 @acelyc111 @maobaolong @Jackson-Wang-7