Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Bump ratis version to 2.5.1" #17910

Merged
merged 2 commits into from
Sep 21, 2023
Merged

Revert "Bump ratis version to 2.5.1" #17910

merged 2 commits into from
Sep 21, 2023

Conversation

maobaolong
Copy link
Contributor

Fix #17889

@ssyssy ssyssy self-requested a review August 7, 2023 20:24
@yuzhu
Copy link
Contributor

yuzhu commented Aug 7, 2023

@jenoudet

@jenoudet
Copy link
Contributor

jenoudet commented Aug 7, 2023

tests are failing @yuzhu

@maobaolong
Copy link
Contributor Author

The failed tests are the following, not sure why previous release version cannot pass these tests.

2023-08-17T12:06:54.9174015Z org.junit.ComparisonFailure: expected:<Status: [CANCE]LED> but was:<Status: [FAI]LED>
2023-08-17T12:06:54.9174855Z 	at org.junit.Assert.assertEquals(Assert.java:117)
2023-08-17T12:06:54.9175800Z 	at org.junit.Assert.assertEquals(Assert.java:146)
2023-08-17T12:06:54.9179517Z 	at alluxio.client.cli.job.DistributedCommandsStatsTest.testAsyncPersistCancelStats(DistributedCommandsStatsTest.java:234)
2023-08-17T12:06:54.9180352Z 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
2023-08-17T12:06:54.9181062Z 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
2023-08-17T12:06:54.9190184Z 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
2023-08-17T12:06:54.9190868Z 	at java.lang.reflect.Method.invoke(Method.java:498)
2023-08-17T12:06:54.9191676Z 	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
2023-08-17T12:06:54.9201891Z 	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
2023-08-17T12:06:54.9202738Z 	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
2023-08-17T12:06:54.9234975Z 	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
2023-08-17T12:06:54.9237616Z 	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
2023-08-17T12:06:54.9243470Z 	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:54)
2023-08-17T12:06:54.9243980Z 	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:54)
2023-08-17T12:06:54.9244592Z 	at org.junit.rules.ExpectedException$ExpectedExceptionStatement.evaluate(ExpectedException.java:258)
2023-08-17T12:06:54.9245175Z 	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:54)
2023-08-17T12:06:54.9245782Z 	at alluxio.testutils.LocalAlluxioClusterResource$ResetRule$1.evaluate(LocalAlluxioClusterResource.java:320)
2023-08-17T12:06:54.9246488Z 	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:288)
2023-08-17T12:06:54.9247190Z 	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:282)
2023-08-17T12:06:54.9247748Z 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
2023-08-17T12:06:54.9248135Z 	at java.lang.Thread.run(Thread.java:748)
2023-08-17T12:06:54.9248317Z 
2023-08-17T12:06:55.2909654Z 12:06:55.283 [INFO] 
2023-08-17T12:06:55.2912321Z 12:06:55.284 [INFO] Results:
2023-08-17T12:06:55.2914023Z 12:06:55.284 [INFO] 
2023-08-17T12:06:55.2914586Z 12:06:55.284 [ERROR] Failures: 
2023-08-17T12:06:55.2915302Z 12:06:55.285 [ERROR] alluxio.client.cli.fsadmin.command.QuorumCommandIntegrationTest.elect
2023-08-17T12:06:55.2916144Z 12:06:55.286 [ERROR]   Run 1: QuorumCommandIntegrationTest.elect:214 expected:<... aff9777f52c6:11495
2023-08-17T12:06:55.2917679Z [Successfully elected aff9777f52c6:11495 as the new leader]> but was:<... aff9777f52c6:11495


2023-08-17T12:03:03.3527366Z 12:03:03.351 [ERROR] alluxio.client.cli.fsadmin.command.QuorumCommandIntegrationTest.infoAfterElect  Time elapsed: 24.317 s  <<< FAILURE!
2023-08-17T12:03:03.3534971Z java.lang.AssertionError: elect command failed expected:<0> but was:<-1>
2023-08-17T12:03:03.3535546Z 	at org.junit.Assert.fail(Assert.java:89)
2023-08-17T12:03:03.3536021Z 	at org.junit.Assert.failNotEquals(Assert.java:835)
2023-08-17T12:03:03.3536508Z 	at org.junit.Assert.assertEquals(Assert.java:647)
2023-08-17T12:03:03.3537294Z 	at alluxio.client.cli.fsadmin.command.QuorumCommandIntegrationTest.infoAfterElect(QuorumCommandIntegrationTest.java:242)
2023-08-17T12:03:03.3549964Z 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
2023-08-17T12:03:03.3557806Z 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
2023-08-17T12:03:03.3558601Z 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
2023-08-17T12:03:03.3559217Z 	at java.lang.reflect.Method.invoke(Method.java:498)
2023-08-17T12:03:03.3559846Z 	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
2023-08-17T12:03:03.3633644Z 	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
2023-08-17T12:03:03.3695382Z 	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
2023-08-17T12:03:03.3716831Z 	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
2023-08-17T12:03:03.3717787Z 	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
2023-08-17T12:03:03.3718862Z 	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:54)
2023-08-17T12:03:03.3719608Z 	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:54)
2023-08-17T12:03:03.3720625Z 	at org.junit.rules.ExpectedException$ExpectedExceptionStatement.evaluate(ExpectedException.java:258)
2023-08-17T12:03:03.3721742Z 	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:54)
2023-08-17T12:03:03.3722886Z 	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:288)
2023-08-17T12:03:03.3723831Z 	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:282)
2023-08-17T12:03:03.3724802Z 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
2023-08-17T12:03:03.3725380Z 	at java.lang.Thread.run(Thread.java:748)


2023-08-17T12:03:03.3731612Z [Failed to elect aff9777f52c6:11495 as the new leader: aff9777f52c6_11498@group-ABB3109A44C1 refused to transfer leadership to peer aff9777f52c6_11495 as it does not has highest priority 0: peers:[aff9777f52c6_11492|rpc:aff9777f52c6:11492|admin:|client:|dataStream:|priority:0|startupRole:FOLLOWER, aff9777f52c6_11495|rpc:aff9777f52c6:11495|admin:|client:|dataStream:|priority:0|startupRole:FOLLOWER, aff9777f52c6_11498|rpc:aff9777f52c6:11498|admin:|client:|dataStream:|priority:0|startupRole:FOLLOWER]|listeners:[], old=null]>
2023-08-17T12:03:03.3733071Z 	at org.junit.Assert.assertEquals(Assert.java:117)
2023-08-17T12:03:03.3777426Z 	at org.junit.Assert.assertEquals(Assert.java:146)
2023-08-17T12:03:03.3838003Z 	at alluxio.client.cli.fsadmin.command.QuorumCommandIntegrationTest.elect(QuorumCommandIntegrationTest.java:214)
2023-08-17T12:03:03.3838980Z 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
2023-08-17T12:03:03.3839992Z 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
2023-08-17T12:03:03.3840871Z 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
2023-08-17T12:03:03.3841804Z 	at java.lang.reflect.Method.invoke(Method.java:498)
2023-08-17T12:03:03.3842555Z 	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
2023-08-17T12:03:03.3843581Z 	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
2023-08-17T12:03:03.3844443Z 	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
2023-08-17T12:03:03.3845491Z 	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
2023-08-17T12:03:03.3846387Z 	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
2023-08-17T12:03:03.3847348Z 	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:54)
2023-08-17T12:03:03.3848158Z 	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:54)
2023-08-17T12:03:03.3849172Z 	at org.junit.rules.ExpectedException$ExpectedExceptionStatement.evaluate(ExpectedException.java:258)
2023-08-17T12:03:03.3849942Z 	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:54)
2023-08-17T12:03:03.3850963Z 	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:288)
2023-08-17T12:03:03.3851858Z 	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:282)
2023-08-17T12:03:03.3852816Z 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
2023-08-17T12:03:03.3853386Z 	at java.lang.Thread.run(Thread.java:748)

elega
elega reviewed Aug 18, 2023
View reviewed changes
core/server/common/src/main/java/alluxio/master/journal/raft/RaftJournalUtils.java
* @return the temporary snapshot file
* @throws IOException if error occurred while creating the snapshot file
*/
public static File createTempSnapshotFile(SimpleStateMachineStorage storage) throws IOException {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is this used?

dbw9580
dbw9580 approved these changes Aug 18, 2023
View reviewed changes
Copy link
Contributor

@dbw9580 dbw9580 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dbw9580
Copy link
Contributor

dbw9580 commented Aug 28, 2023

Changes LGTM. @jiacheliu3 your call to merge this.

@jiacheliu3 jiacheliu3 added the type-bug This issue is about a bug label Sep 21, 2023
@jiacheliu3
Copy link
Contributor

alluxio-bot, merge this please

@alluxio-bot alluxio-bot merged commit a6eef7d into Alluxio:master-2.x Sep 21, 2023
17 checks passed
@jiacheliu3 jiacheliu3 mentioned this pull request Nov 8, 2023
Merged
alluxio-bot added a commit that referenced this pull request Nov 8, 2023
@alluxio-bot
Merge master-2.x commits 2023/07/01~2023/11/08 into main
c2f4cd2 
### What changes are proposed in this pull request?
Merge missing commits from master-2.x to main. The commits in 2023/07/01~2023/11/08 from main...master-2.x will be included by this PR.

We do this merge to catch missing fixes from `master-2.x` and catch the train before `main` cuts a release.

#17747 is not cherry picked because tencent cloud EMR doc is removed
#17755 is not cherry picked because DistLoadCliRunner has been removed in 3.x
#17758 is not cherry picked because MonoBlockStore has been removed in 3.x
#17641 is not cherry picked because the PR has already been in main
#17781 is not cherry picked because the PR has already been in main
#17722 is not cherry picked because the alluxio-fuse command has been changed a lot
#17489 is not cherry picked because audit log on master is no longer in 3.x
#17865 is not cherry picked because replication on job service is no longer in 3.x
#17858 is not cherry picked because it is already in main
#18090 is not cherry picked because generate-tarball has been rewritten in 3.x
#18091 is not cherry picked because the change is already in main
#17474 is not cherry picked because reconfiguration feature is not defined in 3.x
#17735 is not cherry picked because MonoBlockStore is no longer in 3.x
#18133 is not cherry picked because the issue is about master metadata and no longer relevant in 3.x
#17910 is not cherry picked because I prefer to do that manually
#17983 is not cherry picked because the web UI has been reworked
#17984 is not cherry picked because Mount/Unmount commands have been reworked in 3.x
#18103 is not cherry picked because worker cache metrics have been reworked in 3.x
#18185 is not cherry picked because the report command has been reworked in 3.x
#18222 is not cherry picked because Mount/Unmount operations have been reworked in 3.x
#18143 is not cherry picked because the change is already in main
#18303 is not cherry picked because the change is already in main
#18208 is not cherry picked because cache metrics have been reworked in 3.x
#17002 is not cherry picked because the owner has been notified separately
#18334 is not cherry picked because the bash scripts have been reworked in 3.x
#18326 is not cherry picked because the owner has been notified separately

			pr-link: #18397
			change-id: cid-dbf8cbb2d9e721a5a0a1e5028a3c9577438a2ac0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elega elega elega approved these changes

@dbw9580 dbw9580 dbw9580 approved these changes

@ssyssy ssyssy ssyssy approved these changes

Assignees
No one assigned
Labels
type-bug This issue is about a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@maobaolong @yuzhu @jenoudet @dbw9580 @jiacheliu3 @elega @ssyssy @alluxio-bot @kaijchen