Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libs explore endpoints #3354

Merged
merged 4 commits into from
Jul 1, 2022
Merged

Add libs explore endpoints #3354

merged 4 commits into from
Jul 1, 2022

Conversation

jowlee
Copy link
Contributor

@jowlee jowlee commented Jun 30, 2022

Description

Updates libs to add discovery endpoints: top playlists, best new releases, and most loved tracks

reference discovery pr: #3353

Tests

Ran locally against linked libs

Fixes PLAT-233

Monitoring - How will this change be monitored? Are there sufficient logs / alerts?

@jowlee jowlee requested a review from dylanjeffers June 30, 2022 16:27
@jowlee jowlee changed the title Jowlee libs explore Add libs explore endpoints Jun 30, 2022
Copy link
Contributor

@dylanjeffers dylanjeffers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice additions

@@ -727,6 +730,26 @@ export class DiscoveryProvider {
return await this._makeRequest(req)
}

async getTrendingPlaylists(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since there are a lot of optional params, does it make sense to use object? or do we want to have same api as the request function?

@@ -486,6 +489,28 @@ export const getTopPlaylists = (
}
}

export const getTrendingPlaylists = (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually considering we define it here, maybe object for both makes sense?

@jowlee jowlee merged commit 2ace945 into master Jul 1, 2022
@jowlee jowlee deleted the jowlee-libs-explore branch July 1, 2022 13:58
@jowlee jowlee mentioned this pull request Jul 1, 2022
@raymondjacobson raymondjacobson mentioned this pull request Jul 6, 2022
hareeshnagaraj pushed a commit that referenced this pull request Jul 14, 2022
## Changelog

- #3463 by nicoback2 bump
- #3420 by nicoback2 Use
- #2988 by Cheran [INF-76]
- #3458 by Johannes Naylor
- #3456 by Sid Sethi
- libs by Johannes Naylor
- #3451 by Sebastian Klingler
- #3373 by Sebastian Klingler
- #3449 by Theo Ilie
- #3408 by Theo Ilie
- #3445 by Sebastian Klingler
- #3435 by Reed Added
- #3438 by Raymond Jacobson
- #3434 by Hareesh Nagaraj
- #3433 by Sebastian Klingler
- #3406 by nicoback2 Make
- #3402 by Hareesh Nagaraj
- #3394 by Raymond Jacobson
- #3392 by Raymond Jacobson
- #3363 by Michael Piazza
- #3366 by Joseph Lee
- #3354 by Joseph Lee
- #3362 by Michael Piazza
- #3361 by Raymond Jacobson
- #3360 by Raymond Jacobson
- #3347 by Raymond Jacobson
- #3345 by Raymond Jacobson
- #3337 by Sebastian Klingler
- #3336 by Sid Sethi
hareeshnagaraj pushed a commit that referenced this pull request Jul 14, 2022
## Changelog

- #3463 by nicoback2 bump
- #3420 by nicoback2 Use
- #2988 by Cheran [INF-76]
- #3458 by Johannes Naylor
- #3456 by Sid Sethi
- libs by Johannes Naylor
- #3451 by Sebastian Klingler
- #3373 by Sebastian Klingler
- #3449 by Theo Ilie
- #3408 by Theo Ilie
- #3445 by Sebastian Klingler
- #3435 by Reed Added
- #3438 by Raymond Jacobson
- #3434 by Hareesh Nagaraj
- #3433 by Sebastian Klingler
- #3406 by nicoback2 Make
- #3402 by Hareesh Nagaraj
- #3394 by Raymond Jacobson
- #3392 by Raymond Jacobson
- #3363 by Michael Piazza
- #3366 by Joseph Lee
- #3354 by Joseph Lee
- #3362 by Michael Piazza
- #3361 by Raymond Jacobson
- #3360 by Raymond Jacobson
- #3347 by Raymond Jacobson
- #3345 by Raymond Jacobson
- #3337 by Sebastian Klingler
- #3336 by Sid Sethi
hareeshnagaraj pushed a commit that referenced this pull request Jul 14, 2022
## Changelog

- #3463 by nicoback2 bump
- #3420 by nicoback2 Use
- #2988 by Cheran [INF-76]
- #3458 by Johannes Naylor
- #3456 by Sid Sethi
- libs by Johannes Naylor
- #3451 by Sebastian Klingler
- #3373 by Sebastian Klingler
- #3449 by Theo Ilie
- #3408 by Theo Ilie
- #3445 by Sebastian Klingler
- #3435 by Reed Added
- #3438 by Raymond Jacobson
- #3434 by Hareesh Nagaraj
- #3433 by Sebastian Klingler
- #3406 by nicoback2 Make
- #3402 by Hareesh Nagaraj
- #3394 by Raymond Jacobson
- #3392 by Raymond Jacobson
- #3363 by Michael Piazza
- #3366 by Joseph Lee
- #3354 by Joseph Lee
- #3362 by Michael Piazza
- #3361 by Raymond Jacobson
- #3360 by Raymond Jacobson
- #3347 by Raymond Jacobson
- #3345 by Raymond Jacobson
- #3337 by Sebastian Klingler
- #3336 by Sid Sethi
sliptype pushed a commit that referenced this pull request Sep 10, 2023
[9855fd2] Update locks (#3397) Dylan Jeffers
[aecef5f] [PAY-1144] [PAY-1182] [PAY-1147] DMs: Delete chat, message permissions (#3390) Marcus Pasell
[64ccd9d] Add stylelint to ci (#3373) Dylan Jeffers
[b642a16] [C-2518, C-2523, C-2611] Improve playlist create sagas (#3378) Dylan Jeffers
[5620d53] [PAY-1197] Mobile inbox unavailable modal from profile screen (#3376) Reed
[2ebaef5] [PAY-1248] Initial changes to get ready for upcoming PRs that include track and playlist tiles in DMs (#3391) Saliou Diallo
[c2fabf6] [PAY-1218] Mobile block dms drawer switches block/unblock (#3387) Reed
[0acad29] [C-2575] Match length of related artists user list to preview (#3395) Andrew Mendelsohn
[40525ae] [C-2615] Fix favorite tracks error due to empty track entries on web mobile (#3386) Kyle Shanks
[93a8077] [PAY-1145] DMs: Add InboxUnavailableModal (#3369) Marcus Pasell
[633484d] Update edit playlist flow and components (#3361) Kyle Shanks
[334ea0d] Special case ios safari for stem download (#3385) Raymond Jacobson
[d38238d] [C-2607] Pagination wrapper hooks for audius-query (#3375) Andrew Mendelsohn
[0a332d8] Hotfix: Fix stems downloads on mobile web (#3382) Marcus Pasell
[81da65e] Clean up artist_pick_track_id in APIUser (#3381) Michelle Brier
[64d89ef] Fix lint (#3380) Raymond Jacobson
[59129b4] [C-2614] Fix download stems mobile web (#3379) Raymond Jacobson
[df68727] [PAY-1032][PAY-892] Mobile DMs unread indicator, prefetch chats (#3352) Reed
[4a00fad] [PAY-1151] Handle chat reactions near top of screen on mobile (#3370) Reed
[bff316f] [PAY-1139] Throttle calls to fetchMessages on web scroll (#3372) Michael Piazza
[e723cec] C-2483 Fix queue overshot empty track player bug (#3353) nicoback2
[472a41d] [C-2596] Add disabled option to audius-query hooks (#3367) Andrew Mendelsohn
[f518962] [C-2602] Improve playlist library layout (#3364) Dylan Jeffers
[b3db8fa] Fix debounce on notif reaction (#3362) Raymond Jacobson
[2104b2b] [PAY-1183] Make clicking ChatUser handle/displayname lead to profile (#3368) Michael Piazza
[21cb6fc] DMs: Fix click handler in search user list for users you can't chat (#3358) Marcus Pasell
[24e7d8a] DMs: Update copy, scroll inbox-settings modal (#3359) Marcus Pasell
[e5e8d90] [PAY-941] Fix "1 new messages" unread tag (web) (#3366) Michael Piazza
[cfa1b2a] [C-2603] Fix readonly object error in audius-query reducer (#3365) Andrew Mendelsohn
[978c993] Fix invite reward claimable state on mobile (#3363) Reed
[a174fcc] [C-2556, C-2557] Address AI Attribution QA (#3349) Dylan Jeffers
[3c9b0f1] [PAY-1202] Refactor saved collections fetching (#3337) Randy Schott
[a0bdad5] Get call to action for chat permissions (#3325) Marcus Pasell
[03a2721] DMs: Use the optimistic unread count if applicable (#3354) Marcus Pasell
[8b99c2b] [C-2550] Left-nav fixes and improvements (#3357) Dylan Jeffers
[e7b0aab] [PAY-1215] Fix create new message crash (#3356) Reed
[6e7ece9] [PAY-1196] Mobile dms search users empty state (#3355) Reed
[315ae4f] [PAY-1219] Fix mobile chat reactions popup message getting cut off (#3342) Reed
@AudiusProject AudiusProject deleted a comment from linear bot Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants