Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add success true and false metrics w prometheus #3382

Merged
merged 1 commit into from
Jul 5, 2022
Merged

Add success true and false metrics w prometheus #3382

merged 1 commit into from
Jul 5, 2022

Conversation

vicky-g
Copy link
Contributor

@vicky-g vicky-g commented Jul 5, 2022 •
edited
Loading

Description

Update the prometheus metric tracking according to standard. Thanks @joaquincasares for guiding me here!

Tests

Checked the /prometheus_metrics route for the update_track_is_available worker

# HELP audius_dn_update_track_is_available_duration_seconds Multiprocess metric
# TYPE audius_dn_update_track_is_available_duration_seconds histogram
audius_dn_update_track_is_available_duration_seconds_sum{success="true",task_name="update_track_is_available"} 0.36917924880981445
audius_dn_update_track_is_available_duration_seconds_bucket{le="0.005",success="true",task_name="update_track_is_available"} 1.0
audius_dn_update_track_is_available_duration_seconds_bucket{le="0.01",success="true",task_name="update_track_is_available"} 7.0
audius_dn_update_track_is_available_duration_seconds_bucket{le="0.025",success="true",task_name="update_track_is_available"} 8.0
audius_dn_update_track_is_available_duration_seconds_bucket{le="0.05",success="true",task_name="update_track_is_available"} 15.0
audius_dn_update_track_is_available_duration_seconds_bucket{le="0.075",success="true",task_name="update_track_is_available"} 15.0
audius_dn_update_track_is_available_duration_seconds_bucket{le="0.1",success="true",task_name="update_track_is_available"} 15.0
audius_dn_update_track_is_available_duration_seconds_bucket{le="0.25",success="true",task_name="update_track_is_available"} 15.0
audius_dn_update_track_is_available_duration_seconds_bucket{le="0.5",success="true",task_name="update_track_is_available"} 15.0
audius_dn_update_track_is_available_duration_seconds_bucket{le="0.75",success="true",task_name="update_track_is_available"} 15.0
audius_dn_update_track_is_available_duration_seconds_bucket{le="1.0",success="true",task_name="update_track_is_available"} 15.0
audius_dn_update_track_is_available_duration_seconds_bucket{le="2.5",success="true",task_name="update_track_is_available"} 15.0
audius_dn_update_track_is_available_duration_seconds_bucket{le="5.0",success="true",task_name="update_track_is_available"} 15.0
audius_dn_update_track_is_available_duration_seconds_bucket{le="7.5",success="true",task_name="update_track_is_available"} 15.0
audius_dn_update_track_is_available_duration_seconds_bucket{le="10.0",success="true",task_name="update_track_is_available"} 15.0
audius_dn_update_track_is_available_duration_seconds_bucket{le="+Inf",success="true",task_name="update_track_is_available"} 15.0
audius_dn_update_track_is_available_duration_seconds_count{success="true",task_name="update_track_is_available"} 15.0

Monitoring - How will this change be monitored? Are there sufficient logs / alerts?

Metrics regarding this task should be logged into the celery workers grafana dashboard

@vicky-g vicky-g requested a review from joaquincasares July 5, 2022 19:39
@vicky-g vicky-g added the discovery-node Discovery Node (previously known as Discovery Provider) label Jul 5, 2022
joaquincasares
joaquincasares approved these changes Jul 5, 2022
View reviewed changes
Copy link
Contributor

@joaquincasares joaquincasares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@vicky-g vicky-g merged commit 590bbd6 into master Jul 5, 2022
@vicky-g vicky-g deleted the vg-fix-track-available-metrics branch July 5, 2022 21:04
sliptype pushed a commit that referenced this pull request Sep 10, 2023
@rickyrombo
Hotfix: Fix stems downloads on mobile web (#3382)
f143708
sliptype pushed a commit that referenced this pull request Sep 10, 2023
v1.5.25
7413dba 
[9855fd2] Update locks (#3397) Dylan Jeffers
[aecef5f] [PAY-1144] [PAY-1182] [PAY-1147] DMs: Delete chat, message permissions (#3390) Marcus Pasell
[64ccd9d] Add stylelint to ci (#3373) Dylan Jeffers
[b642a16] [C-2518, C-2523, C-2611] Improve playlist create sagas (#3378) Dylan Jeffers
[5620d53] [PAY-1197] Mobile inbox unavailable modal from profile screen (#3376) Reed
[2ebaef5] [PAY-1248] Initial changes to get ready for upcoming PRs that include track and playlist tiles in DMs (#3391) Saliou Diallo
[c2fabf6] [PAY-1218] Mobile block dms drawer switches block/unblock (#3387) Reed
[0acad29] [C-2575] Match length of related artists user list to preview (#3395) Andrew Mendelsohn
[40525ae] [C-2615] Fix favorite tracks error due to empty track entries on web mobile (#3386) Kyle Shanks
[93a8077] [PAY-1145] DMs: Add InboxUnavailableModal (#3369) Marcus Pasell
[633484d] Update edit playlist flow and components (#3361) Kyle Shanks
[334ea0d] Special case ios safari for stem download (#3385) Raymond Jacobson
[d38238d] [C-2607] Pagination wrapper hooks for audius-query (#3375) Andrew Mendelsohn
[0a332d8] Hotfix: Fix stems downloads on mobile web (#3382) Marcus Pasell
[81da65e] Clean up artist_pick_track_id in APIUser (#3381) Michelle Brier
[64d89ef] Fix lint (#3380) Raymond Jacobson
[59129b4] [C-2614] Fix download stems mobile web (#3379) Raymond Jacobson
[df68727] [PAY-1032][PAY-892] Mobile DMs unread indicator, prefetch chats (#3352) Reed
[4a00fad] [PAY-1151] Handle chat reactions near top of screen on mobile (#3370) Reed
[bff316f] [PAY-1139] Throttle calls to fetchMessages on web scroll (#3372) Michael Piazza
[e723cec] C-2483 Fix queue overshot empty track player bug (#3353) nicoback2
[472a41d] [C-2596] Add disabled option to audius-query hooks (#3367) Andrew Mendelsohn
[f518962] [C-2602] Improve playlist library layout (#3364) Dylan Jeffers
[b3db8fa] Fix debounce on notif reaction (#3362) Raymond Jacobson
[2104b2b] [PAY-1183] Make clicking ChatUser handle/displayname lead to profile (#3368) Michael Piazza
[21cb6fc] DMs: Fix click handler in search user list for users you can't chat (#3358) Marcus Pasell
[24e7d8a] DMs: Update copy, scroll inbox-settings modal (#3359) Marcus Pasell
[e5e8d90] [PAY-941] Fix "1 new messages" unread tag (web) (#3366) Michael Piazza
[cfa1b2a] [C-2603] Fix readonly object error in audius-query reducer (#3365) Andrew Mendelsohn
[978c993] Fix invite reward claimable state on mobile (#3363) Reed
[a174fcc] [C-2556, C-2557] Address AI Attribution QA (#3349) Dylan Jeffers
[3c9b0f1] [PAY-1202] Refactor saved collections fetching (#3337) Randy Schott
[a0bdad5] Get call to action for chat permissions (#3325) Marcus Pasell
[03a2721] DMs: Use the optimistic unread count if applicable (#3354) Marcus Pasell
[8b99c2b] [C-2550] Left-nav fixes and improvements (#3357) Dylan Jeffers
[e7b0aab] [PAY-1215] Fix create new message crash (#3356) Reed
[6e7ece9] [PAY-1196] Mobile dms search users empty state (#3355) Reed
[315ae4f] [PAY-1219] Fix mobile chat reactions popup message getting cut off (#3342) Reed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raymondjacobson raymondjacobson raymondjacobson approved these changes

@joaquincasares joaquincasares joaquincasares approved these changes

Assignees

@raymondjacobson raymondjacobson

Labels
discovery-node Discovery Node (previously known as Discovery Provider) size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vicky-g @joaquincasares @raymondjacobson