track trigger runs on update #3654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stereosteve
force-pushed
the
trigger_unlisted_track
branch
from
133dc95 to
89211f0
Compare
jowlee
approved these changes
Aug 17, 2022
|
audius-infra
pushed a commit
that referenced
this pull request
Aug 18, 2022
## Changelog - 2022-08-17 [6d1ca16] [C-853] Add solanaWeb3Manager to NativeAudiusLibs (#3711) [Dylan Jeffers] - 2022-08-17 [a19fee7] Pass track cover art when creating a playlist (#3707) [Isaac Solo] - 2022-08-17 [9847029] INF-221 Automate Grafana Alert extraction from Grafana Panels (#3708) [Joaquin Casares] - 2022-08-17 [fa5f45d] INF-213 New Alchemy and SDK Prometheus Exporters (#3627) [Joaquin Casares] - 2022-08-17 [9f9be2d] PrimarySyncFromSecondary() improvements to error handling and logging (#3703) [Sid Sethi] - 2022-08-17 [6b38bac] INF-201 Enable local ELK and Grafana-related Sidecars by default for remote-dev (#3710) [Joaquin Casares] - 2022-08-17 [c870855] Track is available flag (#3709) [Steve Perkins] - 2022-08-17 [6401d59] track trigger runs on update (#3654) [Steve Perkins] - 2022-08-17 [5f0803f] Update block error codes (#3704) [Saliou Diallo] - 2022-08-16 [8bcc9ac] Bump sdk to v0.0.35 [audius-infra]
audius-infra
pushed a commit
that referenced
this pull request
Aug 18, 2022
## Changelog - 2022-08-17 [6d1ca16] [C-853] Add solanaWeb3Manager to NativeAudiusLibs (#3711) [Dylan Jeffers] - 2022-08-17 [a19fee7] Pass track cover art when creating a playlist (#3707) [Isaac Solo] - 2022-08-17 [9847029] INF-221 Automate Grafana Alert extraction from Grafana Panels (#3708) [Joaquin Casares] - 2022-08-17 [fa5f45d] INF-213 New Alchemy and SDK Prometheus Exporters (#3627) [Joaquin Casares] - 2022-08-17 [9f9be2d] PrimarySyncFromSecondary() improvements to error handling and logging (#3703) [Sid Sethi] - 2022-08-17 [6b38bac] INF-201 Enable local ELK and Grafana-related Sidecars by default for remote-dev (#3710) [Joaquin Casares] - 2022-08-17 [c870855] Track is available flag (#3709) [Steve Perkins] - 2022-08-17 [6401d59] track trigger runs on update (#3654) [Steve Perkins] - 2022-08-17 [5f0803f] Update block error codes (#3704) [Saliou Diallo] - 2022-08-16 [8bcc9ac] Bump sdk to v0.0.35 [audius-infra]
sliptype
pushed a commit
that referenced
this pull request
Sep 10, 2023
sliptype
pushed a commit
that referenced
this pull request
Sep 10, 2023
[4a26077] [C-2678] Add Stems and Source Files Modal (#3671) Andrew Mendelsohn [6a3342a] Bump android version to 1.1.391 to fix play-store build (#3678) Dylan Jeffers [2064212] [C-2813] Catch collectibles runtime errors (#3675) Dylan Jeffers [29233ea] [C-2808] Improve storageNodeSelector usage and perf (#3674) Dylan Jeffers [2de2035] Fix mobile image uri (#3670) Dylan Jeffers [55a6089] [C-2807] Add ModalField subforms with cancellation (#3664) Andrew Mendelsohn [e26986f] [C-2812] Use storageNodeSelector in libs, fix mobile images (#3667) Dylan Jeffers [5daea08] Enable playlist updates on prod (#3668) Dylan Jeffers [d90c369] [PAY-1541] Autofocus textinput on mobile search users screen (#3666) Reed [194f894] [PAY-1542][PAY-1539][PAY-1537] Mobile chats QA improvements (#3665) Reed [58b9028] [C-2798] Fix playlist button overlap (#3662) Dylan Jeffers [a935588] [PAY-1538] Fix autocorrect behavior (#3661) Michael Piazza [1a8a6e7] [PAY-1518] DMs: Align the overflow menu bottom center (#3654) Marcus Pasell [c880b2a] [plat-1085] disable fav and repost on hidden tracks in play bar (#3653) sabrina-kiam [d80617e] [PAY-1529] Add initial types for usdc purchases (#3651) Randy Schott [68e87ff] [C-2787] Reregister device-token on app startup (#3660) Dylan Jeffers [ddfa510] [C-2802] Move embed to client monorepo! (#3659) Raymond Jacobson [6a2f008] Add Sentry error logging to Audius query C-2800 (#3656) nicoback2 [79213de] Add Amplitude events to new Write OAuth flows C-2801 (#3657) nicoback2 [6576ae4] Fix android chat message cut off at top (#3658) Reed [160b325] [C-2677] Remix Settings Modal layout complete (#3647) Andrew Mendelsohn [c01c022] [C-2790] Add private DogEar to desktop playlist cards (#3655) Dylan Jeffers [50e8f4e] [PAY-1522][PAY-1451] Fix issues with DMs notification dot (#3649) Michael Piazza [1658810] [PAY-1530] adds usdc feature flag and hooks for fetching it (#3645) Randy Schott
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
is_unlistedis updated in place without adding a new row. This meanstrack_countwould fail to decrement when a track became unlisted.However...
aggregate_user:save_countandrepost_countwon't be recomputed for a user who saved or reposted this unlisted track. This might be okay... it'll be recomputed the next time user saves or reposts.Question: are there other known places where we update in place instead of inserting new row? Maybe
is_availablefield?Tests
✅