CON-321 Clean up sanity checks #3658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o dm-cleanup-sanity-checks
SidSethi
approved these changes
Aug 26, 2022
audius-infra
pushed a commit
that referenced
this pull request
Sep 27, 2022
## Changelog - 2022-09-27 [e85874b] [PAY-480][PAY-482][PAY-488][PAY-503][PAY-520][PAY-588] Activate premium content middleware (#3841) [Saliou Diallo] - 2022-09-27 [d075c43] [PAY-631] Update filter logic for trending premium content (#3904) [Saliou Diallo] - 2022-09-26 [13d48e5] Await CN services before starting server (#3937) [Theo Ilie] - 2022-09-26 [56340ff] Run Content Node on multiple cluster processes and migrate Bull->BullMQ (#3881) [Theo Ilie] - 2022-09-26 [a39471f] Add Hyperpop to trending (#3931) [Raymond Jacobson] - 2022-09-23 [620ab53] INF-251 don't send Starting nor Success slack messages for auto-deploys (#3935) [Joaquin Casares] - 2022-09-23 [36884df] Patch staging CN delegateOwnerWallet (#3933) [Sid Sethi] - 2022-09-23 [d662e84] INF-251 Streamlined reorg for Deployment Pipeline (#3934) [Joaquin Casares] - 2022-09-23 [f1e0981] INF-251 add host to post-health check logs (#3932) [Joaquin Casares] - 2022-09-23 [40af9d4] Block notifs on error 7 (#3930) [Michael Piazza] - 2022-09-23 [60b6310] INF-251 reorg production deployment flow w/release-day lessons (#3927) [Joaquin Casares] - 2022-09-23 [37b651c] INF-251 always deploy to canaries first (#3924) [Joaquin Casares] - 2022-09-23 [53e96f8] INF-251 remove hold job for auto-deploying to staging (#3926) [Joaquin Casares] - 2022-09-23 [bc0fe57] Remove handle relay blocking logic (#3921) [Michael Piazza] - 2022-09-23 [5cf8e3f] Add upload track to audius-cmd (#3915) [Cheran] - 2022-09-23 [dc2ec68] CON-402 CN Remove all synchronous disk ops (#3908) [Sid Sethi] - 2022-09-22 [e438b87] Add check for GCP DBs in check-secrets.sh (#3925) [Michael Piazza] - 2022-09-22 [5dc84a9] Update stage contract addresses to goerli (#3922) [Isaac Solo] - 2022-09-22 [df427a9] INF-251 don't block releases for test-eth-contracts (#3920) [Joaquin Casares] - 2022-09-22 [1a134bb] INF-251 throttle prod releases (#3919) [Joaquin Casares] - 2022-09-22 [64b1889] Randomize order of orphaned data recovery (#3917) [Theo Ilie] - 2022-09-22 [56ab786] [PAY-604] Use /abuse endpoint in Identity (#3860) [Michael Piazza] - 2022-09-22 [0eff09d] Default foundation spIDs to reconfig blacklist (#3901) [vicky :)] - 2022-09-21 [b5dd929] Bump to version 0.3.67 (#3913) [Sid Sethi] - 2022-09-21 [c2c9502] Fix artist name sorter (#3912) [Raymond Jacobson] - 2022-09-21 [da6aeeb] INF-251 use set-tag for prod (#3911) [Joaquin Casares] - 2022-09-21 [945ba42] INF-251 Allow for surgical deployments via a trigger pipeline (#3910) [Joaquin Casares] - 2022-09-21 [04be7bb] bump connection pool max (#3909) [Johannes Naylor] - 2022-09-21 [0a05746] remove start time from slack alert (#3907) [Johannes Naylor] - 2022-09-21 [41c0ac7] Creator node Track owner validation from discovery (#3851) [Joseph Lee] - 2022-09-21 [8a4cb0c] Increase CN nginx worker procs + Update caching rules (#3883) [Sid Sethi] - 2022-09-20 [1712c8c] Add a route to start a stripe session in SDK (#3878) [Marcus Pasell] - 2022-09-20 [8fbd03d] INF deploy-master-hold (#3902) [Joaquin Casares] - 2022-09-20 [77fcfc3] [PAY-568] Add route to identity to create a Stripe session (#3879) [Marcus Pasell] - 2022-09-20 [d9c8474] INF-251 Automate Production Deployments (#3893) [Joaquin Casares] - 2022-09-20 [84d3f28] Make block explorer optional (#3894) [Cheran] - 2022-09-20 [400b146] Add feeling lucky API to libs (#3895) [Isaac Solo] - 2022-09-20 [c17637c] Add feeling lucky route (#3896) [Isaac Solo] - 2022-09-20 [989b35d] Change tsconfig root dir (#3900) [vicky :)] - 2022-09-20 [7ab9807] Also log aborts in issuing sync flow (#3899) [vicky :)] - 2022-09-20 [c63975f] Include 2 new challenges in notification tests (#3889) [Reed] - 2022-09-20 [4bc1e73] Add FsInstrumentation to content node (#3898) [Johannes Naylor] - 2022-09-19 [b201438] More grafana granularity and track sync failure per wallet (#3886) [vicky :)] - 2022-09-19 [89545fb] [CON-395] Add duration to network monitoring metrics (#3891) [Johannes Naylor] - 2022-09-19 [5d613e4] Run is_available job every 3 hours (#3892) [Raymond Jacobson] - 2022-09-19 [5c199d6] INF clear exporter's tallies for new proposals (#3885) [Joaquin Casares] - 2022-09-19 [fb87b2e] INF production Grafana snapshot (#3890) [Joaquin Casares] - 2022-09-19 [64fb281] Fix email deliverable field (#3888) [Michael Piazza] - 2022-09-19 [95cc726] [CON-395] Add start time to network monitoring slack alert (#3887) [Johannes Naylor] - 2022-09-19 [05d7766] Clean up sanity checks (#3658) [Dheeraj Manjunath] - 2022-09-19 [e12947e] Add auth headers cmd for local dev (#3852) [Cheran] - 2022-09-19 [d9a7b36] Add ESLint rules to prevent easy errors (#3884) [Johannes Naylor] - 2022-09-19 [9d7d567] Remove snapback init from serviceRegistry (#3882) [Theo Ilie] - 2022-09-18 [cfbe6d4] Add aborts for primary sync from secondary (#3877) [vicky :)] - 2022-09-18 [9720cb9] Set reconfig blacklist (#3871) [vicky :)] - 2022-09-16 [22a3f66] First Playlist and Tip Challenge Playlist Notifications (#3880) [Reed] - 2022-09-16 [d87f1db] INF-194 Add staging deploys to CircleCi (#3545) [Joaquin Casares] - 2022-09-16 [c5ef7ea] Update final retry call and add async retry tests (#3844) [vicky :)] - 2022-09-15 [eac4bb7] [INF-187] Add elastic search to discovery provider (#3800) [Cheran] - 2022-09-15 [31a81c1] Increase node mem in cnode (#3876) [Raymond Jacobson] - 2022-09-14 [6f255c5] Fix generated types (#3873) [Saliou Diallo] - 2022-09-14 [8fc2753] Remove redundant stack trace log (#3872) [vicky :)] - 2022-09-14 [d46fbab] Test apply early limit true (#3870) [Joseph Lee] - 2022-09-14 [baed51d] Breakup try catch in audius libs init (#3869) [vicky :)] - 2022-09-14 [bf379dc] Add multi-root VSCode workspace (#3866) [Michael Piazza] - 2022-09-14 [93098e4] double snapbackUsersPerJob (#3868) [Sid Sethi] - 2022-09-14 [cd7681f] Enable all reconfig modes on prod by default (#3858) [Sid Sethi] - 2022-09-14 [51d0eff] Bump sdk to v1.0.5 [audius-infra]
audius-infra
pushed a commit
that referenced
this pull request
Sep 27, 2022
## Changelog - 2022-09-27 [e85874b] [PAY-480][PAY-482][PAY-488][PAY-503][PAY-520][PAY-588] Activate premium content middleware (#3841) [Saliou Diallo] - 2022-09-27 [d075c43] [PAY-631] Update filter logic for trending premium content (#3904) [Saliou Diallo] - 2022-09-26 [13d48e5] Await CN services before starting server (#3937) [Theo Ilie] - 2022-09-26 [56340ff] Run Content Node on multiple cluster processes and migrate Bull->BullMQ (#3881) [Theo Ilie] - 2022-09-26 [a39471f] Add Hyperpop to trending (#3931) [Raymond Jacobson] - 2022-09-23 [620ab53] INF-251 don't send Starting nor Success slack messages for auto-deploys (#3935) [Joaquin Casares] - 2022-09-23 [36884df] Patch staging CN delegateOwnerWallet (#3933) [Sid Sethi] - 2022-09-23 [d662e84] INF-251 Streamlined reorg for Deployment Pipeline (#3934) [Joaquin Casares] - 2022-09-23 [f1e0981] INF-251 add host to post-health check logs (#3932) [Joaquin Casares] - 2022-09-23 [40af9d4] Block notifs on error 7 (#3930) [Michael Piazza] - 2022-09-23 [60b6310] INF-251 reorg production deployment flow w/release-day lessons (#3927) [Joaquin Casares] - 2022-09-23 [37b651c] INF-251 always deploy to canaries first (#3924) [Joaquin Casares] - 2022-09-23 [53e96f8] INF-251 remove hold job for auto-deploying to staging (#3926) [Joaquin Casares] - 2022-09-23 [bc0fe57] Remove handle relay blocking logic (#3921) [Michael Piazza] - 2022-09-23 [5cf8e3f] Add upload track to audius-cmd (#3915) [Cheran] - 2022-09-23 [dc2ec68] CON-402 CN Remove all synchronous disk ops (#3908) [Sid Sethi] - 2022-09-22 [e438b87] Add check for GCP DBs in check-secrets.sh (#3925) [Michael Piazza] - 2022-09-22 [5dc84a9] Update stage contract addresses to goerli (#3922) [Isaac Solo] - 2022-09-22 [df427a9] INF-251 don't block releases for test-eth-contracts (#3920) [Joaquin Casares] - 2022-09-22 [1a134bb] INF-251 throttle prod releases (#3919) [Joaquin Casares] - 2022-09-22 [64b1889] Randomize order of orphaned data recovery (#3917) [Theo Ilie] - 2022-09-22 [56ab786] [PAY-604] Use /abuse endpoint in Identity (#3860) [Michael Piazza] - 2022-09-22 [0eff09d] Default foundation spIDs to reconfig blacklist (#3901) [vicky :)] - 2022-09-21 [b5dd929] Bump to version 0.3.67 (#3913) [Sid Sethi] - 2022-09-21 [c2c9502] Fix artist name sorter (#3912) [Raymond Jacobson] - 2022-09-21 [da6aeeb] INF-251 use set-tag for prod (#3911) [Joaquin Casares] - 2022-09-21 [945ba42] INF-251 Allow for surgical deployments via a trigger pipeline (#3910) [Joaquin Casares] - 2022-09-21 [04be7bb] bump connection pool max (#3909) [Johannes Naylor] - 2022-09-21 [0a05746] remove start time from slack alert (#3907) [Johannes Naylor] - 2022-09-21 [41c0ac7] Creator node Track owner validation from discovery (#3851) [Joseph Lee] - 2022-09-21 [8a4cb0c] Increase CN nginx worker procs + Update caching rules (#3883) [Sid Sethi] - 2022-09-20 [1712c8c] Add a route to start a stripe session in SDK (#3878) [Marcus Pasell] - 2022-09-20 [8fbd03d] INF deploy-master-hold (#3902) [Joaquin Casares] - 2022-09-20 [77fcfc3] [PAY-568] Add route to identity to create a Stripe session (#3879) [Marcus Pasell] - 2022-09-20 [d9c8474] INF-251 Automate Production Deployments (#3893) [Joaquin Casares] - 2022-09-20 [84d3f28] Make block explorer optional (#3894) [Cheran] - 2022-09-20 [400b146] Add feeling lucky API to libs (#3895) [Isaac Solo] - 2022-09-20 [c17637c] Add feeling lucky route (#3896) [Isaac Solo] - 2022-09-20 [989b35d] Change tsconfig root dir (#3900) [vicky :)] - 2022-09-20 [7ab9807] Also log aborts in issuing sync flow (#3899) [vicky :)] - 2022-09-20 [c63975f] Include 2 new challenges in notification tests (#3889) [Reed] - 2022-09-20 [4bc1e73] Add FsInstrumentation to content node (#3898) [Johannes Naylor] - 2022-09-19 [b201438] More grafana granularity and track sync failure per wallet (#3886) [vicky :)] - 2022-09-19 [89545fb] [CON-395] Add duration to network monitoring metrics (#3891) [Johannes Naylor] - 2022-09-19 [5d613e4] Run is_available job every 3 hours (#3892) [Raymond Jacobson] - 2022-09-19 [5c199d6] INF clear exporter's tallies for new proposals (#3885) [Joaquin Casares] - 2022-09-19 [fb87b2e] INF production Grafana snapshot (#3890) [Joaquin Casares] - 2022-09-19 [64fb281] Fix email deliverable field (#3888) [Michael Piazza] - 2022-09-19 [95cc726] [CON-395] Add start time to network monitoring slack alert (#3887) [Johannes Naylor] - 2022-09-19 [05d7766] Clean up sanity checks (#3658) [Dheeraj Manjunath] - 2022-09-19 [e12947e] Add auth headers cmd for local dev (#3852) [Cheran] - 2022-09-19 [d9a7b36] Add ESLint rules to prevent easy errors (#3884) [Johannes Naylor] - 2022-09-19 [9d7d567] Remove snapback init from serviceRegistry (#3882) [Theo Ilie] - 2022-09-18 [cfbe6d4] Add aborts for primary sync from secondary (#3877) [vicky :)] - 2022-09-18 [9720cb9] Set reconfig blacklist (#3871) [vicky :)] - 2022-09-16 [22a3f66] First Playlist and Tip Challenge Playlist Notifications (#3880) [Reed] - 2022-09-16 [d87f1db] INF-194 Add staging deploys to CircleCi (#3545) [Joaquin Casares] - 2022-09-16 [c5ef7ea] Update final retry call and add async retry tests (#3844) [vicky :)] - 2022-09-15 [eac4bb7] [INF-187] Add elastic search to discovery provider (#3800) [Cheran] - 2022-09-15 [31a81c1] Increase node mem in cnode (#3876) [Raymond Jacobson] - 2022-09-14 [6f255c5] Fix generated types (#3873) [Saliou Diallo] - 2022-09-14 [8fc2753] Remove redundant stack trace log (#3872) [vicky :)] - 2022-09-14 [d46fbab] Test apply early limit true (#3870) [Joseph Lee] - 2022-09-14 [baed51d] Breakup try catch in audius libs init (#3869) [vicky :)] - 2022-09-14 [bf379dc] Add multi-root VSCode workspace (#3866) [Michael Piazza] - 2022-09-14 [93098e4] double snapbackUsersPerJob (#3868) [Sid Sethi] - 2022-09-14 [cd7681f] Enable all reconfig modes on prod by default (#3858) [Sid Sethi] - 2022-09-14 [51d0eff] Bump sdk to v1.0.5 [audius-infra]
rickyrombo
added a commit
that referenced
this pull request
Jan 6, 2023
This reverts commit 05d7766.
sliptype
pushed a commit
that referenced
this pull request
Sep 10, 2023
sliptype
pushed a commit
that referenced
this pull request
Sep 10, 2023
[4a26077] [C-2678] Add Stems and Source Files Modal (#3671) Andrew Mendelsohn [6a3342a] Bump android version to 1.1.391 to fix play-store build (#3678) Dylan Jeffers [2064212] [C-2813] Catch collectibles runtime errors (#3675) Dylan Jeffers [29233ea] [C-2808] Improve storageNodeSelector usage and perf (#3674) Dylan Jeffers [2de2035] Fix mobile image uri (#3670) Dylan Jeffers [55a6089] [C-2807] Add ModalField subforms with cancellation (#3664) Andrew Mendelsohn [e26986f] [C-2812] Use storageNodeSelector in libs, fix mobile images (#3667) Dylan Jeffers [5daea08] Enable playlist updates on prod (#3668) Dylan Jeffers [d90c369] [PAY-1541] Autofocus textinput on mobile search users screen (#3666) Reed [194f894] [PAY-1542][PAY-1539][PAY-1537] Mobile chats QA improvements (#3665) Reed [58b9028] [C-2798] Fix playlist button overlap (#3662) Dylan Jeffers [a935588] [PAY-1538] Fix autocorrect behavior (#3661) Michael Piazza [1a8a6e7] [PAY-1518] DMs: Align the overflow menu bottom center (#3654) Marcus Pasell [c880b2a] [plat-1085] disable fav and repost on hidden tracks in play bar (#3653) sabrina-kiam [d80617e] [PAY-1529] Add initial types for usdc purchases (#3651) Randy Schott [68e87ff] [C-2787] Reregister device-token on app startup (#3660) Dylan Jeffers [ddfa510] [C-2802] Move embed to client monorepo! (#3659) Raymond Jacobson [6a2f008] Add Sentry error logging to Audius query C-2800 (#3656) nicoback2 [79213de] Add Amplitude events to new Write OAuth flows C-2801 (#3657) nicoback2 [6576ae4] Fix android chat message cut off at top (#3658) Reed [160b325] [C-2677] Remix Settings Modal layout complete (#3647) Andrew Mendelsohn [c01c022] [C-2790] Add private DogEar to desktop playlist cards (#3655) Dylan Jeffers [50e8f4e] [PAY-1522][PAY-1451] Fix issues with DMs notification dot (#3649) Michael Piazza [1658810] [PAY-1530] adds usdc feature flag and hooks for fetching it (#3645) Randy Schott
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Clean up sanity checks. Changes include deleting rolloverNodes and sanitizeNodes checks
Tests
Linked the sdk from client, added logs around start/finish sanity checks to make sure it got run successful and created an account and made sure that still worked.
Monitoring - How will this change be monitored? Are there sufficient logs / alerts?
Sentry might be the best place to see any errors or regressions from this. Previously even in the happy path, I don't believe this code was ever being run.