Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduled release web client #6866

Merged
merged 35 commits into from
Dec 13, 2023
Merged

Scheduled release web client #6866

merged 35 commits into from
Dec 13, 2023

Conversation

isaacsolo
Copy link
Contributor

@isaacsolo isaacsolo commented Dec 6, 2023

Description

First pass at web changes for scheduled releases.
Includes:

  • Reverting scheduled release POC
  • Upload scheduled release as hidden track

https://www.figma.com/file/4n1QrIMgvJ1NMFyPRN3Uox/%F0%9F%97%93-Scheduled-Release?type=design&node-id=0-1&mode=design

Keeping tabs on things to follow up on
Artist dashboard.
Release now button flashes "Make Public".
Fetch track release dates as utc from the source.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

Tested against stage.

@audius-infra
Copy link
Collaborator

Preview this change https://demo.audius.co/is-scheduled-release

@audius-infra
Copy link
Collaborator

It looks like there may be some changes to native mobile code, which requires triggering a full app release. Please follow the instructions here: https://www.notion.so/audiusproject/When-to-bump-app-version-2644a8f772364a4d91f44abcba44ce0b?pvs=4. cc @nicoback2 @sliptype

@audius-infra
Copy link
Collaborator

Preview this change https://demo.audius.co/is-scheduled-release

@isaacsolo isaacsolo requested a review from amendelsohn December 6, 2023 17:33
@audius-infra
Copy link
Collaborator

It looks like there may be some changes to native mobile code, which requires triggering a full app release. Please follow the instructions here: https://www.notion.so/audiusproject/When-to-bump-app-version-2644a8f772364a4d91f44abcba44ce0b?pvs=4. cc @nicoback2 @sliptype

@audius-infra
Copy link
Collaborator

Preview this change https://demo.audius.co/is-scheduled-release

@audius-infra
Copy link
Collaborator

It looks like there may be some changes to native mobile code, which requires triggering a full app release. Please follow the instructions here: https://www.notion.so/audiusproject/When-to-bump-app-version-2644a8f772364a4d91f44abcba44ce0b?pvs=4. cc @nicoback2 @sliptype

@audius-infra
Copy link
Collaborator

Preview this change https://demo.audius.co/is-scheduled-release

@audius-infra
Copy link
Collaborator

It looks like there may be some changes to native mobile code, which requires triggering a full app release. Please follow the instructions here: https://www.notion.so/audiusproject/When-to-bump-app-version-2644a8f772364a4d91f44abcba44ce0b?pvs=4. cc @nicoback2 @sliptype

@audius-infra
Copy link
Collaborator

Preview this change https://demo.audius.co/is-scheduled-release

Copy link
Contributor

@amendelsohn amendelsohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! some small stuff to fix, but awesome work 👏

Copy link
Contributor

@amendelsohn amendelsohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Great job!!

@@ -60,7 +60,7 @@
background-color: var(--neutral-light-10);
border: 1px solid var(--neutral-light-9);
border-radius: 4px;
width: 100%;
width: 200%;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this intended? 200% sort of unusual

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea just realized the date picker should be twice as wide but maybe i should set it to fixed pixels

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

likely the right approach is to make the parent wider and keep this at 100%

@audius-infra
Copy link
Collaborator

It looks like there may be some changes to native mobile code, which requires triggering a full app release. Please follow the instructions here: https://www.notion.so/audiusproject/When-to-bump-app-version-2644a8f772364a4d91f44abcba44ce0b?pvs=4. cc @nicoback2 @sliptype

@audius-infra
Copy link
Collaborator

Preview this change https://demo.audius.co/is-scheduled-release

@audius-infra
Copy link
Collaborator

It looks like there may be some changes to native mobile code, which requires triggering a full app release. Please follow the instructions here: https://www.notion.so/audiusproject/When-to-bump-app-version-2644a8f772364a4d91f44abcba44ce0b?pvs=4. cc @nicoback2 @sliptype

Copy link

gitguardian bot commented Dec 13, 2023

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
688750 Generic High Entropy Secret 9723942 monitoring/uptime/node-ui/.env.stage.local View secret
2416684 Generic High Entropy Secret 9723942 monitoring/uptime/node-ui/.env.stage.local View secret
2416685 Generic High Entropy Secret 9723942 monitoring/uptime/node-ui/.env.stage.local View secret
2416686 Generic High Entropy Secret 9723942 monitoring/uptime/node-ui/.env.stage.local View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@isaacsolo isaacsolo enabled auto-merge (squash) December 13, 2023 23:37
@audius-infra
Copy link
Collaborator

It looks like there may be some changes to native mobile code, which requires triggering a full app release. Please follow the instructions here: https://www.notion.so/audiusproject/When-to-bump-app-version-2644a8f772364a4d91f44abcba44ce0b?pvs=4. cc @nicoback2 @sliptype

@isaacsolo isaacsolo merged commit 3d8a5cd into main Dec 13, 2023
11 of 14 checks passed
@isaacsolo isaacsolo deleted the is-scheduled-release branch December 13, 2023 23:46
audius-infra pushed a commit that referenced this pull request Dec 16, 2023
[952c141] [PAY-2278] Disable coinflow apple/gpay on desktop (#6961) Raymond Jacobson
[aab8f30] Notify Slack when stage nodes aren't updating (#6922) Theo Ilie
[6a71a1a] Make finding slow queries compatible with pg 13+ (#6950) Theo Ilie
[bf24278] [PAY-2283] Disable purchase button immediately after click (#6960) Marcus Pasell
[509efd7] [PAY-2274] Update minWidths of pay extra pills to prevent clipping (#6959) Randy Schott
[7a8d979] Use retry logic for coinflow (#6957) Marcus Pasell
[bc346fd] Bump mobile versions for full release (#6958) Dylan Jeffers
[a336fc1] [PAY-2286] Increase payment router indexer frequency (#6956) Raymond Jacobson
[4d674d0] [C-3449] Add native welcome modal & consolidate messages to common (#6939) JD Francis
[4d1e378] Scheduled release mobile (#6954) Isaac Solo
[c954108] Bump version to 0.6.3 audius-infra
[54e3a24] [C-3485, C-3487, C-3486] Add Track to Album (web) (#6936) Andrew Mendelsohn
[551902e] fix: Fix native select genres pill performance issue (#6953) JD Francis
[801d075] [PAY-2224] Add ExploreTransaction callout to sale/purchase details (#6944) Raymond Jacobson
[7fe4adf] Fix pay extra (#6952) Raymond Jacobson
[f02009d] Revert "Extra amount is in dollars (#6949)" (#6951) Marcus Pasell
[c4c8b6b] Extra amount is in dollars (#6949) Marcus Pasell
[b193f23] Fix primary key for DashboardWalletUsers (#6934) nicoback2
[9e33796] [C-3506] Upgrade selectable-pill to use gestures (#6938) Dylan Jeffers
[96bb775] [C-3435] Add CompletionCheck to native harmony (#6947) Kyle Shanks
[4b4328f] [PAY-2276] Selectable amounts for coinflow add funds web (#6946) Reed
[b6a82b9] [PAY-2277][PAY-2272] Fix purchase modaldrawer scroll and safe areas (#6941) Raymond Jacobson
[fe21499] [PAY-2273] Fix payExtra for coinflow and stripe (#6943) Raymond Jacobson
[215a36a] [PAY-2270] Show vendor button only if more than 1 vendor (#6945) Reed
[9c2e79c] Use 0.0.0.0 default host for vite app (#6942) Raymond Jacobson
[8f2f0f6] Bump version to 0.6.2 audius-infra
[c45aa43] [PAY-2249] Adds tests for payment router indexing (#6932) Randy Schott
[f18f78e] [C-3509] Fix sign-in legacy styles (#6940) Dylan Jeffers
[ac8aa98] [C-3475] Allow editing album track order (#6876) Andrew Mendelsohn
[5b9d32c] [C-3505] Upgrade react-native-gesture-handler (#6923) Dylan Jeffers
[3b24a93] Fix feature flag lint issue (#6937) Dylan Jeffers
[38670b9] Add dashboard wallet users table C-3497 (#6933) nicoback2
[3d8a5cd] Scheduled release web client (#6866) Isaac Solo
[8213ebb] [PAY-2271] Skip preflight in coinflow checkout (#6930) Raymond Jacobson
[354a5b6] [PAY-2269] Fix mobile config (#6931) Raymond Jacobson
[ad95c08] [C-3429] Add FollowButton to native harmony (#6928) Kyle Shanks
[b18a138] rm does_follow_current_user from API response (#6836) Steve Perkins
[88bde40] Fix defaults when coinflow disabled + android purchase vendor drawer (#6926) Reed
[76bede3] Remove CTA on withdrawals table empty state (#6924) Reed
[683748f] Fix mobile web purchase drawer layout (#6927) Reed
[92ad724] Add uptime to node overview tables in protocol dashboard (#6900) Michelle Brier
[be58789] [PROTO-1481] Hardcode mediorum dbUrl to localhost (#6918) Theo Ilie
[b6207d8] [C-3446] Native Select Genres Page (#6916) JD Francis
[cbb0508] Bump version to 0.6.1 audius-infra
[59f5b5c] Bump version to 0.6.0 (#6925) Raymond Jacobson
[ca78cdf] [PROTO-1480] Expose hosted DBs in healthz (#6908) Theo Ilie
[e10f870] Fix prices add types for purchases (#6921) Marcus Pasell
[6b6ebb6] [PAY-2246][PAY-2257][PAY-2264] Fix mobile coinflow support (#6919) Raymond Jacobson
[d6de701] [PAY-2263] Always Allow Deactivations on DN Relay (#6920) Marcus Pasell
[7c379ff] [PAY-2263] Decode ABI for blocked users and relay if they're deactivation requests (#6917) Marcus Pasell
[dc91844] [PAY-2241][PAY-2259] Add Funds via Coinflow (#6915) Marcus Pasell
[0f571a1] [C-3504] Enable native animated icons (#6914) Dylan Jeffers
[15c7909] Add sign in route aliases C-3503 (#6912) nicoback2
[5f7e980] Fix timestamp comparison for sched releases (#6913) Isaac Solo
[46ce24f] [C-3445] Add native finish-profile-screen (#6909) Dylan Jeffers
[ad8463d] [C-3436] Add SelectablePill component to native harmony (#6903) Kyle Shanks
[a9df266] Bump version to 0.5.36 audius-infra
[768e3b5] trpc test setup (#6872) Steve Perkins
[57348ab] Separate web / mobile trpc client (#6906) Steve Perkins
[8c6d628] [C-3452 C-3448] Native sign-on screen (#6905) Dylan Jeffers
[7929dd0] [PAY-2128] Implement general coinflow scaffolding (#6847) Raymond Jacobson
[ab24471] Add memo for purchaser user id (#6846) Reed
[68d9f71] [C-3444] Native Pick Handle Page (#6890) JD Francis
[1a54363] Fix missing string format on payment router indexing (#6907) Randy Schott
[730423c] [C-3440] Add Hint component to native harmony (#6904) Kyle Shanks
[aab9814] [PAY-2132] Premium content explore page denylist (#6902) Reed
[eecf247] Bump version to 0.5.35 audius-infra
[1f99498] [PAY-2178] Initial implementation of payment router indexing (#6892) Randy Schott
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants