[C-3452 C-3448] Native sign-on screen #6905

dylanjeffers · 2023-12-11T18:23:12Z

Description

Consolidates sign-up and sign-in screens into sign-on
Adds "SignOn" root screen in change of rendering background and expandable panel
Updates "CreateEmailScreen" to work inside the SignOn screen
Updates "SignInScreen" UI up to spec

Adds the sign-on screen navigation header. We should ideally use this as the basis for all the other headers moving forward.

audius-infra · 2023-12-11T18:34:08Z

Preview this change https://demo.audius.co/dj-c3409-sign-on

DejayJD · 2023-12-11T20:22:43Z

packages/harmony/src/foundations/corner-radius/cornerRadius.ts

@@ -4,7 +4,8 @@ export const cornerRadius = {
  m: 8,
  l: 12,
  xl: 16,
-  '2xl': 32
+  '2xl': 32,
+  '3xl': 48


big boy curves.

Not sure if there have already been convos about it but if we're adding this on the dev side we should add it on the design side as well 👍 @szonana @julianbaker

yes thank you for callout <3

audius-infra · 2023-12-11T21:05:58Z

Preview this change https://demo.audius.co/dj-c3409-sign-on

DejayJD · 2023-12-11T21:09:51Z

packages/mobile/src/harmony-native/components/layout/Box/Box.tsx


 import type { BoxProps } from './types'

-export const Box = styled.View<BoxProps>(
+const invalidProps = [


curious what the motivation was here

so it was an issue when i used "as" prop on these, it would then pass all these props to those components, some of which actually expect things like "borderRadius", and they dont expect borderRadius='m', instead they expect numbers, so then i was getting errors. I think prob just good habit for us not to leak these props to the sub components?

DejayJD · 2023-12-11T21:13:56Z

packages/mobile/src/screens/sign-on-screen/screens/SignOnScreen.tsx

+}
+
+/*
+ * Mangaes the container for sign-up and sign-in flow


Suggested change

* Mangaes the container for sign-up and sign-in flow

* Manages the container for sign-up and sign-in flow

DejayJD · 2023-12-11T21:14:15Z

packages/mobile/src/screens/sign-on-screen/screens/SignOnScreen.tsx

+
+/*
+ * Mangaes the container for sign-up and sign-in flow
+ * Not using navigation for this due to transition between sign-in and sign-up


DejayJD · 2023-12-11T21:15:15Z

packages/mobile/src/screens/sign-on-screen/components/AudiusValues.tsx

 import IconCloudUpload from './temp-harmony/iconCloudArrowUp.svg'
 import IconHeadphones from './temp-harmony/iconHeadphones.svg'
 import IconMessage from './temp-harmony/iconMessages.svg'


These are safe to import from harmony-native now I assume if you want to add that in

oh yess! 100%

DejayJD · 2023-12-11T21:16:06Z

packages/common/src/messages/sign-on/pages.ts

+export const signInPageMessages = {
+  metaTitle: 'Sign In • Audius',
+  metaDescription: 'Sign into your Audius account',
+


Suggested change

DejayJD

This looks great to me! The animation stuff is so clean and simple to read :chefskiss:

audius-infra · 2023-12-11T23:12:05Z

Preview this change https://demo.audius.co/dj-c3409-sign-on

[952c141] [PAY-2278] Disable coinflow apple/gpay on desktop (#6961) Raymond Jacobson [aab8f30] Notify Slack when stage nodes aren't updating (#6922) Theo Ilie [6a71a1a] Make finding slow queries compatible with pg 13+ (#6950) Theo Ilie [bf24278] [PAY-2283] Disable purchase button immediately after click (#6960) Marcus Pasell [509efd7] [PAY-2274] Update minWidths of pay extra pills to prevent clipping (#6959) Randy Schott [7a8d979] Use retry logic for coinflow (#6957) Marcus Pasell [bc346fd] Bump mobile versions for full release (#6958) Dylan Jeffers [a336fc1] [PAY-2286] Increase payment router indexer frequency (#6956) Raymond Jacobson [4d674d0] [C-3449] Add native welcome modal & consolidate messages to common (#6939) JD Francis [4d1e378] Scheduled release mobile (#6954) Isaac Solo [c954108] Bump version to 0.6.3 audius-infra [54e3a24] [C-3485, C-3487, C-3486] Add Track to Album (web) (#6936) Andrew Mendelsohn [551902e] fix: Fix native select genres pill performance issue (#6953) JD Francis [801d075] [PAY-2224] Add ExploreTransaction callout to sale/purchase details (#6944) Raymond Jacobson [7fe4adf] Fix pay extra (#6952) Raymond Jacobson [f02009d] Revert "Extra amount is in dollars (#6949)" (#6951) Marcus Pasell [c4c8b6b] Extra amount is in dollars (#6949) Marcus Pasell [b193f23] Fix primary key for DashboardWalletUsers (#6934) nicoback2 [9e33796] [C-3506] Upgrade selectable-pill to use gestures (#6938) Dylan Jeffers [96bb775] [C-3435] Add CompletionCheck to native harmony (#6947) Kyle Shanks [4b4328f] [PAY-2276] Selectable amounts for coinflow add funds web (#6946) Reed [b6a82b9] [PAY-2277][PAY-2272] Fix purchase modaldrawer scroll and safe areas (#6941) Raymond Jacobson [fe21499] [PAY-2273] Fix payExtra for coinflow and stripe (#6943) Raymond Jacobson [215a36a] [PAY-2270] Show vendor button only if more than 1 vendor (#6945) Reed [9c2e79c] Use 0.0.0.0 default host for vite app (#6942) Raymond Jacobson [8f2f0f6] Bump version to 0.6.2 audius-infra [c45aa43] [PAY-2249] Adds tests for payment router indexing (#6932) Randy Schott [f18f78e] [C-3509] Fix sign-in legacy styles (#6940) Dylan Jeffers [ac8aa98] [C-3475] Allow editing album track order (#6876) Andrew Mendelsohn [5b9d32c] [C-3505] Upgrade react-native-gesture-handler (#6923) Dylan Jeffers [3b24a93] Fix feature flag lint issue (#6937) Dylan Jeffers [38670b9] Add dashboard wallet users table C-3497 (#6933) nicoback2 [3d8a5cd] Scheduled release web client (#6866) Isaac Solo [8213ebb] [PAY-2271] Skip preflight in coinflow checkout (#6930) Raymond Jacobson [354a5b6] [PAY-2269] Fix mobile config (#6931) Raymond Jacobson [ad95c08] [C-3429] Add FollowButton to native harmony (#6928) Kyle Shanks [b18a138] rm does_follow_current_user from API response (#6836) Steve Perkins [88bde40] Fix defaults when coinflow disabled + android purchase vendor drawer (#6926) Reed [76bede3] Remove CTA on withdrawals table empty state (#6924) Reed [683748f] Fix mobile web purchase drawer layout (#6927) Reed [92ad724] Add uptime to node overview tables in protocol dashboard (#6900) Michelle Brier [be58789] [PROTO-1481] Hardcode mediorum dbUrl to localhost (#6918) Theo Ilie [b6207d8] [C-3446] Native Select Genres Page (#6916) JD Francis [cbb0508] Bump version to 0.6.1 audius-infra [59f5b5c] Bump version to 0.6.0 (#6925) Raymond Jacobson [ca78cdf] [PROTO-1480] Expose hosted DBs in healthz (#6908) Theo Ilie [e10f870] Fix prices add types for purchases (#6921) Marcus Pasell [6b6ebb6] [PAY-2246][PAY-2257][PAY-2264] Fix mobile coinflow support (#6919) Raymond Jacobson [d6de701] [PAY-2263] Always Allow Deactivations on DN Relay (#6920) Marcus Pasell [7c379ff] [PAY-2263] Decode ABI for blocked users and relay if they're deactivation requests (#6917) Marcus Pasell [dc91844] [PAY-2241][PAY-2259] Add Funds via Coinflow (#6915) Marcus Pasell [0f571a1] [C-3504] Enable native animated icons (#6914) Dylan Jeffers [15c7909] Add sign in route aliases C-3503 (#6912) nicoback2 [5f7e980] Fix timestamp comparison for sched releases (#6913) Isaac Solo [46ce24f] [C-3445] Add native finish-profile-screen (#6909) Dylan Jeffers [ad8463d] [C-3436] Add SelectablePill component to native harmony (#6903) Kyle Shanks [a9df266] Bump version to 0.5.36 audius-infra [768e3b5] trpc test setup (#6872) Steve Perkins [57348ab] Separate web / mobile trpc client (#6906) Steve Perkins [8c6d628] [C-3452 C-3448] Native sign-on screen (#6905) Dylan Jeffers [7929dd0] [PAY-2128] Implement general coinflow scaffolding (#6847) Raymond Jacobson [ab24471] Add memo for purchaser user id (#6846) Reed [68d9f71] [C-3444] Native Pick Handle Page (#6890) JD Francis [1a54363] Fix missing string format on payment router indexing (#6907) Randy Schott [730423c] [C-3440] Add Hint component to native harmony (#6904) Kyle Shanks [aab9814] [PAY-2132] Premium content explore page denylist (#6902) Reed [eecf247] Bump version to 0.5.35 audius-infra [1f99498] [PAY-2178] Initial implementation of payment router indexing (#6892) Randy Schott

dylanjeffers added 2 commits December 9, 2023 15:21

[C-3409] SignOnScreeen

712f3dd

Migrate messages

2f1e365

dylanjeffers requested review from DejayJD and a team December 11, 2023 18:23

pull-request-size bot added the size/XL label Dec 11, 2023

DejayJD reviewed Dec 11, 2023

View reviewed changes

Address some final changes

873ed14

DejayJD reviewed Dec 11, 2023

View reviewed changes

DejayJD approved these changes Dec 11, 2023

View reviewed changes

Fix comments

49f45fd

dylanjeffers changed the title ~~[C-3452] Native sign-on screen~~ [C-3452 C-3448] Native sign-on screen Dec 11, 2023

Merge branch 'main' into dj-c3409-sign-on

f689fa4

dylanjeffers merged commit 8c6d628 into main Dec 12, 2023
7 of 12 checks passed

dylanjeffers deleted the dj-c3409-sign-on branch December 12, 2023 06:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[C-3452 C-3448] Native sign-on screen #6905

[C-3452 C-3448] Native sign-on screen #6905

dylanjeffers commented Dec 11, 2023 •

edited

Loading

audius-infra commented Dec 11, 2023

DejayJD Dec 11, 2023

dylanjeffers Dec 11, 2023

audius-infra commented Dec 11, 2023

DejayJD Dec 11, 2023

dylanjeffers Dec 11, 2023

DejayJD Dec 11, 2023

DejayJD Dec 11, 2023

DejayJD Dec 11, 2023

dylanjeffers Dec 11, 2023

DejayJD Dec 11, 2023

DejayJD left a comment

audius-infra commented Dec 11, 2023

	* Mangaes the container for sign-up and sign-in flow
	* Manages the container for sign-up and sign-in flow

[C-3452 C-3448] Native sign-on screen #6905

[C-3452 C-3448] Native sign-on screen #6905

Conversation

dylanjeffers commented Dec 11, 2023 • edited Loading

Description

audius-infra commented Dec 11, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

audius-infra commented Dec 11, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DejayJD left a comment

Choose a reason for hiding this comment

audius-infra commented Dec 11, 2023

dylanjeffers commented Dec 11, 2023 •

edited

Loading