Scheduled release mobile #6954
Merged
Scheduled release mobile #6954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| GitGuardian id | Secret | Commit | Filename | |
|---|---|---|---|---|
| 688750 | Generic High Entropy Secret | 19b2e8f | monitoring/uptime/node-ui/.env.stage.local | View secret |
| 2416684 | Generic High Entropy Secret | 19b2e8f | monitoring/uptime/node-ui/.env.stage.local | View secret |
| 2416685 | Generic High Entropy Secret | 19b2e8f | monitoring/uptime/node-ui/.env.stage.local | View secret |
| 2416686 | Generic High Entropy Secret | 19b2e8f | monitoring/uptime/node-ui/.env.stage.local | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
isaacsolo
commented
Dec 14, 2023
| @@ -0,0 +1,135 @@ | |||
| import { useCallback, useMemo, useRef, useState } from 'react' | |||
There was a problem hiding this comment.
moved the previous ReleaseDateField to this
|
Preview this change https://demo.audius.co/is-scheduled-release-mobile |
amendelsohn
approved these changes
Dec 15, 2023
| menuScreenName='ReleaseDate' | ||
| label={messages.label} | ||
| value={value} | ||
| pillValue={value ? moment(value).format('M/D/YY @ h:mm A') : null} |
There was a problem hiding this comment.
Is this not what renderValue is for?
There was a problem hiding this comment.
i wanted to use the default renderValue without directly using the form's value since it needed formatting. but maybe overriding renderValue is the cleaner way. this is just using value and the default renderValue
There was a problem hiding this comment.
actually i think just renaming pillValue -> formattedValue would make this clearer and seems re-usable.
packages/mobile/src/screens/edit-track-screen/screens/ReleaseDateScreen.tsx
Outdated
Show resolved
Hide resolved
packages/mobile/src/screens/edit-track-screen/screens/ReleaseDateScreen.tsx
Show resolved
Hide resolved
packages/mobile/src/screens/edit-track-screen/screens/ReleaseDateScreen.tsx
Outdated
Show resolved
Hide resolved
packages/mobile/src/screens/edit-track-screen/screens/ReleaseDateScreen.tsx
Outdated
Show resolved
Hide resolved
packages/mobile/src/screens/edit-track-screen/screens/ReleaseDateScreen.tsx
Outdated
Show resolved
Hide resolved
audius-infra
pushed a commit
that referenced
this pull request
Dec 16, 2023
[952c141] [PAY-2278] Disable coinflow apple/gpay on desktop (#6961) Raymond Jacobson [aab8f30] Notify Slack when stage nodes aren't updating (#6922) Theo Ilie [6a71a1a] Make finding slow queries compatible with pg 13+ (#6950) Theo Ilie [bf24278] [PAY-2283] Disable purchase button immediately after click (#6960) Marcus Pasell [509efd7] [PAY-2274] Update minWidths of pay extra pills to prevent clipping (#6959) Randy Schott [7a8d979] Use retry logic for coinflow (#6957) Marcus Pasell [bc346fd] Bump mobile versions for full release (#6958) Dylan Jeffers [a336fc1] [PAY-2286] Increase payment router indexer frequency (#6956) Raymond Jacobson [4d674d0] [C-3449] Add native welcome modal & consolidate messages to common (#6939) JD Francis [4d1e378] Scheduled release mobile (#6954) Isaac Solo [c954108] Bump version to 0.6.3 audius-infra [54e3a24] [C-3485, C-3487, C-3486] Add Track to Album (web) (#6936) Andrew Mendelsohn [551902e] fix: Fix native select genres pill performance issue (#6953) JD Francis [801d075] [PAY-2224] Add ExploreTransaction callout to sale/purchase details (#6944) Raymond Jacobson [7fe4adf] Fix pay extra (#6952) Raymond Jacobson [f02009d] Revert "Extra amount is in dollars (#6949)" (#6951) Marcus Pasell [c4c8b6b] Extra amount is in dollars (#6949) Marcus Pasell [b193f23] Fix primary key for DashboardWalletUsers (#6934) nicoback2 [9e33796] [C-3506] Upgrade selectable-pill to use gestures (#6938) Dylan Jeffers [96bb775] [C-3435] Add CompletionCheck to native harmony (#6947) Kyle Shanks [4b4328f] [PAY-2276] Selectable amounts for coinflow add funds web (#6946) Reed [b6a82b9] [PAY-2277][PAY-2272] Fix purchase modaldrawer scroll and safe areas (#6941) Raymond Jacobson [fe21499] [PAY-2273] Fix payExtra for coinflow and stripe (#6943) Raymond Jacobson [215a36a] [PAY-2270] Show vendor button only if more than 1 vendor (#6945) Reed [9c2e79c] Use 0.0.0.0 default host for vite app (#6942) Raymond Jacobson [8f2f0f6] Bump version to 0.6.2 audius-infra [c45aa43] [PAY-2249] Adds tests for payment router indexing (#6932) Randy Schott [f18f78e] [C-3509] Fix sign-in legacy styles (#6940) Dylan Jeffers [ac8aa98] [C-3475] Allow editing album track order (#6876) Andrew Mendelsohn [5b9d32c] [C-3505] Upgrade react-native-gesture-handler (#6923) Dylan Jeffers [3b24a93] Fix feature flag lint issue (#6937) Dylan Jeffers [38670b9] Add dashboard wallet users table C-3497 (#6933) nicoback2 [3d8a5cd] Scheduled release web client (#6866) Isaac Solo [8213ebb] [PAY-2271] Skip preflight in coinflow checkout (#6930) Raymond Jacobson [354a5b6] [PAY-2269] Fix mobile config (#6931) Raymond Jacobson [ad95c08] [C-3429] Add FollowButton to native harmony (#6928) Kyle Shanks [b18a138] rm does_follow_current_user from API response (#6836) Steve Perkins [88bde40] Fix defaults when coinflow disabled + android purchase vendor drawer (#6926) Reed [76bede3] Remove CTA on withdrawals table empty state (#6924) Reed [683748f] Fix mobile web purchase drawer layout (#6927) Reed [92ad724] Add uptime to node overview tables in protocol dashboard (#6900) Michelle Brier [be58789] [PROTO-1481] Hardcode mediorum dbUrl to localhost (#6918) Theo Ilie [b6207d8] [C-3446] Native Select Genres Page (#6916) JD Francis [cbb0508] Bump version to 0.6.1 audius-infra [59f5b5c] Bump version to 0.6.0 (#6925) Raymond Jacobson [ca78cdf] [PROTO-1480] Expose hosted DBs in healthz (#6908) Theo Ilie [e10f870] Fix prices add types for purchases (#6921) Marcus Pasell [6b6ebb6] [PAY-2246][PAY-2257][PAY-2264] Fix mobile coinflow support (#6919) Raymond Jacobson [d6de701] [PAY-2263] Always Allow Deactivations on DN Relay (#6920) Marcus Pasell [7c379ff] [PAY-2263] Decode ABI for blocked users and relay if they're deactivation requests (#6917) Marcus Pasell [dc91844] [PAY-2241][PAY-2259] Add Funds via Coinflow (#6915) Marcus Pasell [0f571a1] [C-3504] Enable native animated icons (#6914) Dylan Jeffers [15c7909] Add sign in route aliases C-3503 (#6912) nicoback2 [5f7e980] Fix timestamp comparison for sched releases (#6913) Isaac Solo [46ce24f] [C-3445] Add native finish-profile-screen (#6909) Dylan Jeffers [ad8463d] [C-3436] Add SelectablePill component to native harmony (#6903) Kyle Shanks [a9df266] Bump version to 0.5.36 audius-infra [768e3b5] trpc test setup (#6872) Steve Perkins [57348ab] Separate web / mobile trpc client (#6906) Steve Perkins [8c6d628] [C-3452 C-3448] Native sign-on screen (#6905) Dylan Jeffers [7929dd0] [PAY-2128] Implement general coinflow scaffolding (#6847) Raymond Jacobson [ab24471] Add memo for purchaser user id (#6846) Reed [68d9f71] [C-3444] Native Pick Handle Page (#6890) JD Francis [1a54363] Fix missing string format on payment router indexing (#6907) Randy Schott [730423c] [C-3440] Add Hint component to native harmony (#6904) Kyle Shanks [aab9814] [PAY-2132] Premium content explore page denylist (#6902) Reed [eecf247] Bump version to 0.5.35 audius-infra [1f99498] [PAY-2178] Initial implementation of payment router indexing (#6892) Randy Schott
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://app.optimizely.com/v2/projects/18140642080/features
Scheduled release mobile changes behind a feature flag. Moves release date to upload form and enables past/future release dates.
https://app.optimizely.com/v2/projects/18140642080/features
This is pretty much all the changes. Want to get on staging so we can test on stage and add any follow ons.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.
Tested on stage iOS.