[C-3425] Add Button component to native harmony #7038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
Preview this change https://demo.audius.co/kj-Add-Button-component-to-native-harmony |
dylanjeffers
approved these changes
Dec 28, 2023
| backgroundColor: themeColors.neutral.n150 | ||
| }) | ||
| } | ||
| const primaryDynamicStyles = { |
There was a problem hiding this comment.
I wouldn't call these "styles" I guess... what do we call these in base button in web?
There was a problem hiding this comment.
yea styles isn't 100% correct, but they're not really props either. and we don't do this in web bc it's easier to animate things in web
| disabled={isDisabled} | ||
| style={buttonCss} | ||
| dynamicStyles={isDisabled ? undefined : dynamicStyles} | ||
| innerProps={{ |
There was a problem hiding this comment.
Just checking that we have this pattern in web? Or is it the case in web we just have css do the modifications?
There was a problem hiding this comment.
yea doing this bc its easier to apply styles to inner elements in web. Need to pass along fill colors and things on mobile. Not the most fun, but wanted to find a setup that didn't change the api of the exported components too much
packages/mobile/src/harmony-native/components/Button/BaseButton/BaseButton.tsx
Outdated
Show resolved
Hide resolved
packages/mobile/src/harmony-native/components/Button/Button/Button.tsx
Outdated
Show resolved
Hide resolved
packages/mobile/src/harmony-native/components/Button/Button/Button.tsx
Outdated
Show resolved
Hide resolved
Kyle-Shanks
force-pushed
the
kj-Add-Button-component-to-native-harmony
branch
from
f01a794 to
eb55a4f
Compare
|
It looks like there may be some changes to native mobile code, which requires triggering a full app release. Please follow the instructions here: https://www.notion.so/audiusproject/When-to-bump-app-version-2644a8f772364a4d91f44abcba44ce0b?pvs=4. cc @nicoback2 @sliptype |
|
Preview this change https://demo.audius.co/kj-Add-Button-component-to-native-harmony |
Kyle-Shanks
force-pushed
the
kj-Add-Button-component-to-native-harmony
branch
from
eb55a4f to
eea5128
Compare
|
It looks like there may be some changes to native mobile code, which requires triggering a full app release. Please follow the instructions here: https://www.notion.so/audiusproject/When-to-bump-app-version-2644a8f772364a4d91f44abcba44ce0b?pvs=4. cc @nicoback2 @sliptype |
audius-infra
pushed a commit
that referenced
this pull request
Jan 6, 2024
[0f7a486] [C-3478] Backlink to album from track page (#7074) Andrew Mendelsohn [bc375b1] DDEX NODE_ENV production -> prod (#7103) Michelle Brier [ac831b6] Actually fix discovery notif tests (#7101) Raymond Jacobson [c9fd31e] Move uploads out of DDEX client (#7100) Michelle Brier [d162abc] [C-3571] Fix modal header styles (#7091) Dylan Jeffers [3e22ea8] [C-3515] Fix desktop sign up page transitions (#7084) Dylan Jeffers [dcd6c7d] Bump version to 0.6.12 audius-infra [dd4de97] [Web] Fix OAuth sig timestamp (#7099) nicoback2 [6aada56] Add default ddex stage keys and enforce prettier (#7098) Theo Ilie [80ec2c0] Fix copyright year for notif test (#7079) Isaac Solo [6e3fe0c] Increment mobile versions ahead of 1.5.59 (#7097) Raymond Jacobson [53722a8] Add ddex upload logic to backend (#7096) Michelle Brier [1149d51] Add 8cpu resource class to circleci runners (#7094) Danny [7dc3969] Make Stripe the default PurchaseVendor for AddFunds on mobile (#7085) Marcus Pasell [33e1b72] [C-3560 C-3564] Improve mobile playlist image generation perf. (#7080) Dylan Jeffers [9d82f82] Fix harmony build (#7093) Dylan Jeffers [e8bb46a] fix: Fix horizontal color logo clipping & resize img (#7082) JD Francis [c8fea06] Try again to bust cache (#7090) nicoback2 [9ad8bc5] Fix esbuild on intel (#7089) Dylan Jeffers [78460d7] Perform full disk cleanup hourly for self-hosted runners (#7088) Danny [90f3b13] Add DDEX MVC + DB scaffolding (#7086) Theo Ilie [a679e5b] Fix uptime optimizely env (#7083) Michelle Brier [62a618a] Bust turbo web cache (#7081) nicoback2 [643f1d6] [C-3524] Mobile sign-up QA (#7069) Dylan Jeffers [0cd9acf] [C-3462] Disable native font scaling (#7072) Dylan Jeffers [9ff4ac9] [C-3546] Upgrade electron (#7071) Dylan Jeffers [e44ec48] [PROTO-1557] Add DDEX NodeJS backend (#7064) Theo Ilie [3d25793] Bump version to 0.6.11 audius-infra [7840090] [Web] Enable connecting wallet to user via new OAuth `write_once` scope [C-3499] (#7045) nicoback2 [34934d7] [C-3425] Add Button component to native harmony (#7038) Kyle Shanks [a065073] Fix svgr template when no theme (#7076) Dylan Jeffers [c92b4c6] [Discovery API] Add transaction signature to OAuth JWT payload type (#7075) nicoback2 [f66e31c] Scheduled release UI fixes from QA (#7070) Isaac Solo [e3ead7f] Sanitize h1 (#7073) Raymond Jacobson [5bb8bb6] [C-3450] Native Social SignUp (#7000) JD Francis [26f3249] Add is_scheduled_release field (#7061) Isaac Solo [d715d6f] [PAY-2289] Fix premium/usdc modal close issues (#7060) Raymond Jacobson [c2e15dc] Fix native storybook (#7068) Dylan Jeffers [32333e9] [C-3553] Upgrade all react native deps to latest (#7048) Dylan Jeffers [954437d] Restrict DDEX logins (#7062) Michelle Brier [5acff7d] [EM] Allow dashboard wallet to sign EM CreateDashboardWalletUser tx and user to sign `user_signature` in the metadata C-3568 (#7067) nicoback2 [9102cbe] [PAY-2321] Prevent crash if nsure RN module isn't available (#7065) Randy Schott [1bb061a] [C-3490] Improve profile touch targets (#7053) Dylan Jeffers [d82052a] [C-3492] Fix podcast popup position (#7054) Dylan Jeffers [e430ee8] [C-3565] Reduce saga apk size (#7058) Dylan Jeffers [8d2d6df] Clamp upload percentage (#7049) Dylan Jeffers [89bf61d] Fix payment method existing balance (#7063) Saliou Diallo [6e69ecf] [PAY-2281] Fix mobile web purchase modal footer placement (#7059) Raymond Jacobson [733f140] Bump version to 0.6.10 audius-infra [7af8ba5] [C-3513] Private albums + show PublishButton for albums (#7055) Andrew Mendelsohn [5c034eb] [PAY-2320] Fix explore tx link callouts (#7057) Raymond Jacobson [f7e0852] [C-3566] UploadChip - fix text wrapping (#7056) Andrew Mendelsohn [7811bb7] Fix schedule release gating (#7051) Isaac Solo [eccbe31] Tag protocol dashboard `-dev` image (for audius-d) (#7052) endline [b68a4e4] Fix react-native-svg version (#7050) Dylan Jeffers [21ffecd] [PAY-2297] Add extra purchase metadata on mobile (#7010) Randy Schott [9815067] Fix button color darkening (#7047) Dylan Jeffers [1380e77] Bump version to 0.6.9 audius-infra [7928e12] Improve sdk track upload logs (#7007) Sebastian Klingler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added the button component and kept the styles as close to the web designs as possible.
The icon transitions and the blur on the tertiary button is the only things that need update.
How Has This Been Tested?
Looks good in storybook