[C-3478] Backlink to album from track page #7074

amendelsohn · 2024-01-04T00:46:31Z

Description

Add link to album on track page
Add tRPC endpoint for album backlink
Clean up previous tRPC endpoint

How Has This Been Tested?

local web + local trpc server

vercel · 2024-01-04T00:46:37Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
audius-web-ssr	⬜️ Ignored (Inspect)	Visit Preview		Jan 6, 2024 1:05am

gitguardian · 2024-01-04T00:46:41Z

⚠️ GitGuardian has uncovered 13 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	Secret	Commit	Filename
2416684	Generic High Entropy Secret	`bc1b54e`	packages/ddex/.env.stage.local	View secret
3939057	Generic High Entropy Secret	`fbd3388`	packages/ddex/.env.dev	View secret
3939057	Generic High Entropy Secret	`bc1b54e`	packages/ddex/.env.dev	View secret
9142379	PostgreSQL Credentials	`62af2e0`	packages/trpc-server/.env	View secret
9142379	PostgreSQL Credentials	`78a2854`	packages/trpc-server/.env	View secret
9142379	PostgreSQL Credentials	`c9741c1`	packages/trpc-server/.env	View secret
2416686	Generic High Entropy Secret	`fbd3388`	packages/ddex/.env.stage.local	View secret
2416686	Generic High Entropy Secret	`bc1b54e`	packages/ddex/.env.stage.local	View secret
688750	Generic High Entropy Secret	`bc1b54e`	packages/ddex/.env.stage.local	View secret
688750	Generic High Entropy Secret	`bc1b54e`	packages/ddex/.env.dev	View secret
9186696	Generic High Entropy Secret	`fbd3388`	packages/ddex/.env.stage.local	View secret
2416685	Generic High Entropy Secret	`bc1b54e`	packages/ddex/.env.stage.local	View secret
9200270	Generic High Entropy Secret	`8c41481`	packages/ddex/.env.stage	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secrets safely. Learn here the best practices.
Revoke and rotate these secrets.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!}

stereosteve

nice

stereosteve · 2024-01-05T15:45:21Z

packages/web/package.json

@@ -12,6 +12,8 @@
    "start:stage": "npm run write-sha && npm run publish-scripts && env-cmd ./.env/.env.git env-cmd --no-override ./.env/.env.stage turbo run start",
    "start:stage-local-trpc": "npm run write-sha && npm run publish-scripts && env-cmd ./.env/.env.git env-cmd --no-override ./.env/.env.stage-local-trpc turbo run start",
    "start:prod": "npm run write-sha && npm run publish-scripts && env-cmd ./.env/.env.git env-cmd --no-override ./.env/.env.prod env-cmd ./.env/.env.source-maps turbo run start",
+    "start:stage-local-trpc": "npm run write-sha && npm run publish-scripts && env-cmd ./.env/.env.git env-cmd --no-override ./.env/.env.stage-local-trpc turbo run start",
+    "start:prod-local-trpc": "npm run write-sha && npm run publish-scripts && env-cmd ./.env/.env.git env-cmd --no-override ./.env/.env.prod-local-trpc turbo run start",


Looks like there are two "start:stage-local-trpc" entries.
One option instead of adding more start entries would be to do:

VITE_TRPC_ENDPOINT=http://localhost:2022/trpc npm run web:prod

of course configuring the trpc server to use remote postgres / elasticsearch is still manual... I added some notes in the trpc readme in this PR.

Anyway this is fine... just wondering if it's necessary to add more start variants.

Yeah I think we'll decide on a final structure as a team, but I'll remove them for now in favor of the env variable, especially since you've added it to the README in your PR. Thanks!

audius-infra · 2024-01-05T23:48:56Z

Preview this change https://demo.audius.co/am-link-to-album

audius-infra · 2024-01-06T01:23:22Z

Preview this change https://demo.audius.co/am-link-to-album

[0f7a486] [C-3478] Backlink to album from track page (#7074) Andrew Mendelsohn [bc375b1] DDEX NODE_ENV production -> prod (#7103) Michelle Brier [ac831b6] Actually fix discovery notif tests (#7101) Raymond Jacobson [c9fd31e] Move uploads out of DDEX client (#7100) Michelle Brier [d162abc] [C-3571] Fix modal header styles (#7091) Dylan Jeffers [3e22ea8] [C-3515] Fix desktop sign up page transitions (#7084) Dylan Jeffers [dcd6c7d] Bump version to 0.6.12 audius-infra [dd4de97] [Web] Fix OAuth sig timestamp (#7099) nicoback2 [6aada56] Add default ddex stage keys and enforce prettier (#7098) Theo Ilie [80ec2c0] Fix copyright year for notif test (#7079) Isaac Solo [6e3fe0c] Increment mobile versions ahead of 1.5.59 (#7097) Raymond Jacobson [53722a8] Add ddex upload logic to backend (#7096) Michelle Brier [1149d51] Add 8cpu resource class to circleci runners (#7094) Danny [7dc3969] Make Stripe the default PurchaseVendor for AddFunds on mobile (#7085) Marcus Pasell [33e1b72] [C-3560 C-3564] Improve mobile playlist image generation perf. (#7080) Dylan Jeffers [9d82f82] Fix harmony build (#7093) Dylan Jeffers [e8bb46a] fix: Fix horizontal color logo clipping & resize img (#7082) JD Francis [c8fea06] Try again to bust cache (#7090) nicoback2 [9ad8bc5] Fix esbuild on intel (#7089) Dylan Jeffers [78460d7] Perform full disk cleanup hourly for self-hosted runners (#7088) Danny [90f3b13] Add DDEX MVC + DB scaffolding (#7086) Theo Ilie [a679e5b] Fix uptime optimizely env (#7083) Michelle Brier [62a618a] Bust turbo web cache (#7081) nicoback2 [643f1d6] [C-3524] Mobile sign-up QA (#7069) Dylan Jeffers [0cd9acf] [C-3462] Disable native font scaling (#7072) Dylan Jeffers [9ff4ac9] [C-3546] Upgrade electron (#7071) Dylan Jeffers [e44ec48] [PROTO-1557] Add DDEX NodeJS backend (#7064) Theo Ilie [3d25793] Bump version to 0.6.11 audius-infra [7840090] [Web] Enable connecting wallet to user via new OAuth `write_once` scope [C-3499] (#7045) nicoback2 [34934d7] [C-3425] Add Button component to native harmony (#7038) Kyle Shanks [a065073] Fix svgr template when no theme (#7076) Dylan Jeffers [c92b4c6] [Discovery API] Add transaction signature to OAuth JWT payload type (#7075) nicoback2 [f66e31c] Scheduled release UI fixes from QA (#7070) Isaac Solo [e3ead7f] Sanitize h1 (#7073) Raymond Jacobson [5bb8bb6] [C-3450] Native Social SignUp (#7000) JD Francis [26f3249] Add is_scheduled_release field (#7061) Isaac Solo [d715d6f] [PAY-2289] Fix premium/usdc modal close issues (#7060) Raymond Jacobson [c2e15dc] Fix native storybook (#7068) Dylan Jeffers [32333e9] [C-3553] Upgrade all react native deps to latest (#7048) Dylan Jeffers [954437d] Restrict DDEX logins (#7062) Michelle Brier [5acff7d] [EM] Allow dashboard wallet to sign EM CreateDashboardWalletUser tx and user to sign `user_signature` in the metadata C-3568 (#7067) nicoback2 [9102cbe] [PAY-2321] Prevent crash if nsure RN module isn't available (#7065) Randy Schott [1bb061a] [C-3490] Improve profile touch targets (#7053) Dylan Jeffers [d82052a] [C-3492] Fix podcast popup position (#7054) Dylan Jeffers [e430ee8] [C-3565] Reduce saga apk size (#7058) Dylan Jeffers [8d2d6df] Clamp upload percentage (#7049) Dylan Jeffers [89bf61d] Fix payment method existing balance (#7063) Saliou Diallo [6e69ecf] [PAY-2281] Fix mobile web purchase modal footer placement (#7059) Raymond Jacobson [733f140] Bump version to 0.6.10 audius-infra [7af8ba5] [C-3513] Private albums + show PublishButton for albums (#7055) Andrew Mendelsohn [5c034eb] [PAY-2320] Fix explore tx link callouts (#7057) Raymond Jacobson [f7e0852] [C-3566] UploadChip - fix text wrapping (#7056) Andrew Mendelsohn [7811bb7] Fix schedule release gating (#7051) Isaac Solo [eccbe31] Tag protocol dashboard `-dev` image (for audius-d) (#7052) endline [b68a4e4] Fix react-native-svg version (#7050) Dylan Jeffers [21ffecd] [PAY-2297] Add extra purchase metadata on mobile (#7010) Randy Schott [9815067] Fix button color darkening (#7047) Dylan Jeffers [1380e77] Bump version to 0.6.9 audius-infra [7928e12] Improve sdk track upload logs (#7007) Sebastian Klingler

…arch * origin/main: Bump version to 0.6.13 v1.5.59 [C-3478] Backlink to album from track page (#7074) DDEX NODE_ENV production -> prod (#7103) Actually fix discovery notif tests (#7101) Move uploads out of DDEX client (#7100) [C-3571] Fix modal header styles (#7091) [C-3515] Fix desktop sign up page transitions (#7084)

stereosteve and others added 14 commits December 20, 2023 21:38

fix es-indexer for local dev

0aa97be

playlists.containTrackId method

aae109b

wip

c9741c1

wip

6fe79b2

merge main

bc1b54e

working except elasticsearch weirdness

e274fc3

add collectionType arg

13be056

env redacted

62af2e0

pr feedback

5e71b81

env

78a2854

trpc call works!

edf24bc

album link on track

1f2cca8

Merge branch 'main' into am-link-to-album

fbd3388

cleanup

b55fb2f

amendelsohn requested review from a team and nicoback2 and removed request for a team January 4, 2024 00:46

pull-request-size bot added the size/L label Jan 4, 2024

amendelsohn requested a review from a team January 4, 2024 00:46

amendelsohn requested a review from stereosteve January 4, 2024 17:57

stereosteve approved these changes Jan 5, 2024

View reviewed changes

amendelsohn and others added 7 commits January 5, 2024 12:40

remove local trpc web build commands

1ab8691

Merge branch 'main' into am-link-to-album

8c41481

as const

c8fc5b8

add trpc ts import paths

627eaf6

Update typescript version

8267b24

Pin and upgrade versions

08b874c

Fix again?

fe3b57e

Merge branch 'main' into am-link-to-album

77afeb3

amendelsohn merged commit 0f7a486 into main Jan 6, 2024
14 of 15 checks passed

amendelsohn deleted the am-link-to-album branch January 6, 2024 01:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[C-3478] Backlink to album from track page #7074

[C-3478] Backlink to album from track page #7074

amendelsohn commented Jan 4, 2024

vercel bot commented Jan 4, 2024 •

edited

Loading

gitguardian bot commented Jan 4, 2024 •

edited

Loading

stereosteve left a comment

stereosteve Jan 5, 2024

amendelsohn Jan 5, 2024

audius-infra commented Jan 5, 2024

audius-infra commented Jan 6, 2024

[C-3478] Backlink to album from track page #7074

[C-3478] Backlink to album from track page #7074

Conversation

amendelsohn commented Jan 4, 2024

Description

How Has This Been Tested?

vercel bot commented Jan 4, 2024 • edited Loading

gitguardian bot commented Jan 4, 2024 • edited Loading

⚠️ GitGuardian has uncovered 13 secrets following the scan of your pull request.

stereosteve left a comment

Choose a reason for hiding this comment

stereosteve Jan 5, 2024

Choose a reason for hiding this comment

amendelsohn Jan 5, 2024

Choose a reason for hiding this comment

audius-infra commented Jan 5, 2024

audius-infra commented Jan 6, 2024

vercel bot commented Jan 4, 2024 •

edited

Loading

gitguardian bot commented Jan 4, 2024 •

edited

Loading