Improve search analytics #7696

isaacsolo · 2024-02-22T22:43:16Z

Description

Resolves C-3779

Mobile search result clicks weren't working and some of web too. Now every search (or tag search or autocomplete search) result click will be sent properly so we can analyze click through rates.

For track, only playback and title click navigation will result in a hit.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

Logged out metrics sent to amplitude and confirmed every result such as

Search: Result Select {term: 'a', kind: 'album', id: 761, source: 'search results page'}

audius-infra · 2024-02-22T23:16:06Z

Preview this change https://demo.audius.co/is-improve-search-analytics

gitguardian · 2024-02-22T23:59:10Z

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
9349019	Triggered	Generic High Entropy Secret	`8770823`	packages/ddex/.env.stage	View secret
9349019	Triggered	Generic High Entropy Secret	`27f1010`	dev-tools/config.json	View secret
9368958	Triggered	Generic Password	`27f1010`	dev-tools/compose/docker-compose.ddex.yml	View secret
9412812	Triggered	Generic Password	`8770823`	packages/discovery-provider/ddl/local-test.sh	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secrets safely. Learn here the best practices.
Revoke and rotate these secrets.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!}

audius-infra · 2024-02-23T00:12:14Z

Preview this change https://demo.audius.co/is-improve-search-analytics

isaacsolo · 2024-02-23T22:21:39Z

Going to make this more generic + use hooks instead of passing a function through initialParams

audius-infra · 2024-02-27T01:38:36Z

Preview this change https://demo.audius.co/is-improve-search-analytics

dylanjeffers

excellent job!!

packages/mobile/src/components/lineup/types.ts

packages/mobile/src/components/profile-list/ProfileList.tsx

packages/mobile/src/screens/search-results-screen/tabs/AlbumsTab.tsx

packages/mobile/src/screens/search-results-screen/tabs/useTrackSearchResultSelect.tsx

dylanjeffers · 2024-02-27T01:40:51Z

packages/mobile/src/screens/search-screen/SearchResults/SearchItem.tsx


  const handlePress = useCallback(() => {
    dispatch(addItem({ searchItem: user.name }))
    navigation.push('Profile', { handle: user.handle })
-  }, [user, navigation, dispatch])
+    trackAnalytics(


could you also use the hook here? just pass it a different source?

audius-infra · 2024-02-27T02:41:22Z

Preview this change https://demo.audius.co/is-improve-search-analytics

[73c35e5] Bump mobile app version for full-app release (#7770) Dylan Jeffers [fa9c7ce] [PAY-2490] Delete backfill txs tables (#7768) Reed [acf5840] Fix reset-password-modal icon + ui (#7769) Dylan Jeffers [cb9c022] [C-3929] Fix select-artist genres (#7765) Dylan Jeffers [709ff70] Fix reset password (#7767) Marcus Pasell [1c1474e] [C-3708] Fix wallet text clipping issue in withdrawals table (#7762) Kyle Shanks [7f4b187] Add an isNativeMobile prop to amplitude (#7766) JD Francis [4f6972f] [PAY-2527] Return `playlists_containing_track` from track apis (#7764) Andrew Mendelsohn [dbc6dc1] Fix download buttons erroneously displaying (#7763) Reed [8cf2464] [PAY-2531] Grant access to stream track if user has purchased album (#7753) Reed [762a9ac] [C-3926] Add error helper text to new sign in password field (#7761) Kyle Shanks [6d6117f] [C-3885] Migrate to harmony text-link (#7746) Dylan Jeffers [82dd8c5] Update dapp-store build artifacts audius-infra [1c554c6] [C-3924] Fix misc font/type issues on purchase flow (#7760) Raymond Jacobson [b695203] [C-3923] Remove double badges on purchase flow (#7759) Raymond Jacobson [e1dd6e0] [PAY-2488] Remove stripe option from purchase flow (#7755) Raymond Jacobson [4931acb] Bump version to 0.6.50 audius-infra [c8eaa02] [C-2928] Add auth request signing middleware to sdk (#7724) Raymond Jacobson [0d2d3b1] Add verifier checks to discovery relay (#7756) Raymond Jacobson [c3f0a99] useHarmonyField (#7514) Marcus Pasell [ce226e7] Publish harmony to npm (#7751) Sebastian Klingler [d5c0c98] [C-3897] Fix ai-attribution dropdown (#7754) Dylan Jeffers [26f9c7d] [PAY-2533] Index album purchases (#7735) Andrew Mendelsohn [375f5b5] [C-3888] Add header-shadow to sign-up-screen (#7750) Dylan Jeffers [dbbbc88] @audius/sdk: v3.0.35 audius-infra [5125501] [DRVL-16] - Documentation Site Updates (#7699) Sam Gutentag [2738765] Use turbo for sdk release (#7748) Sebastian Klingler [23072cd] [C-3918] Fix wallet and dev-apps icons (#7749) Dylan Jeffers [a4bbe1c] Update stem limit to 20 (#7745) Raymond Jacobson [f4863c6] Fix social sign ups redirecting unintentionally (#7744) JD Francis [557142b] Disable play button if all collection tracks deleted (#7743) Saliou Diallo [5f28d5d] Add others to skip otp (#7741) Raymond Jacobson [b33bc5b] Add download gated column (#7742) Saliou Diallo [9f0f84e] Bump version to 0.6.49 audius-infra [c2a9c46] Add ddex_app field for ddex tracks/playlists to discovery (#7734) Michelle Brier [c932495] [PROTO-1686] Setup DDEX choreography infra and related improvements (#7739) Theo Ilie [aec57f9] Misc sign up social fixes (#7737) JD Francis [682a384] [ONC-35] Fix crash on android due to react native importing images as numbers (#7738) Marcus Pasell [273be01] Misc Sign up fixes (spacing & page swipe animation) (#7736) JD Francis [cb39083] [ONC-34] Fix bug in mobile suggested collection tracks (#7731) Saliou Diallo [8db7400] [C-3866] Update placement of theme reset in mobile sign out to make colors display properly (#7728) Kyle Shanks [0d15ae7] [C-3898] Fix faded gray screen android on sign up (#7730) JD Francis [a0d314b] Bump version to 0.6.48 audius-infra [f43e956] [PROTO-1513] Add e2e ddex test (#7733) Theo Ilie [f5ad4c3] Fix harmony ssr (#7732) Dylan Jeffers [06af9d2] [C-3909] Fix upload track challenge copy (#7729) Saliou Diallo [8f73c19] [C-3899] Fix android able to go back on signup (#7727) JD Francis [d04b4bc] [PAY-2529] Index album stream_conditions (#7720) Reed [8966f88] [QA-779][QA-704] Fix some UI issues (#7725) Saliou Diallo [d29c83f] Misc Sign Up QA Fixes (#7722) JD Francis [90b098a] Discovery placement hosts (#7718) Steve Perkins [9674780] Bump version to 0.6.47 audius-infra [398db27] PROTO-1574: sepolia (#7698) alecsavvy [40583e6] Improve search analytics (#7696) Isaac Solo [3e1b544] Add env linter (#7697) Raymond Jacobson [5a3498c] [DVRL-11] Move client history requests to sdk (#7679) Raymond Jacobson [beb054b] Remove all usage of PROTOCOL_DIR env var (#7714) Danny [6230eca] [PAY-2528] is_stream_gated + stream_conditions on Playlist (#7717) Reed [4136985] [PAY-2524, PAY-2525, PAY-2526] Add collections_containing_track field to tracks (#7708) Andrew Mendelsohn [f25cc23] Fix the same typo in another spot (#7716) Theo Ilie [f51ccd8] [C-3858] Additional padding on select artists screen (#7715) JD Francis [9ff7262] [C-3858] Social sign on loading screen adjustments (#7710) JD Francis [4c3a35c] Fix typo breaking audius-compose push (#7713) Theo Ilie [74facea] Bump mobile versions for prod release (#7712) Dylan Jeffers [392bb21] Bump version to 0.6.46 audius-infra

isaacsolo added 4 commits February 9, 2024 09:26

wip

21f6427

Merge branch 'main' into is-improve-search-analytics

1e0f80d

mostly working

6002c72

clean

952dd2a

pull-request-size bot added the size/L label Feb 22, 2024

clean

aee7c98

isaacsolo requested a review from dylanjeffers February 22, 2024 22:48

isaacsolo force-pushed the is-improve-search-analytics branch from 5c6e5e9 to 235178e Compare February 22, 2024 22:54

isaacsolo requested a review from nicoback2 February 22, 2024 23:04

lint

357b2eb

isaacsolo force-pushed the is-improve-search-analytics branch from 235178e to 357b2eb Compare February 22, 2024 23:04

Merge branch 'main' into is-improve-search-analytics

8770823

isaacsolo added 4 commits February 26, 2024 09:57

generic web

5fb4610

Working

b7447af

Merge branch 'main' into is-improve-search-analytics

27f1010

generic

751bfe9

dylanjeffers approved these changes Feb 27, 2024

View reviewed changes

pass 2

90ad33b

fix album

52d8e68

isaacsolo enabled auto-merge (squash) February 27, 2024 02:48

isaacsolo merged commit 40583e6 into main Feb 27, 2024
9 of 11 checks passed

isaacsolo deleted the is-improve-search-analytics branch February 27, 2024 02:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve search analytics #7696

Improve search analytics #7696

isaacsolo commented Feb 22, 2024 •

edited

Loading

audius-infra commented Feb 22, 2024

gitguardian bot commented Feb 22, 2024 •

edited

Loading

audius-infra commented Feb 23, 2024

isaacsolo commented Feb 23, 2024 •

edited

Loading

audius-infra commented Feb 27, 2024

dylanjeffers left a comment

dylanjeffers Feb 27, 2024

audius-infra commented Feb 27, 2024

Improve search analytics #7696

Improve search analytics #7696

Conversation

isaacsolo commented Feb 22, 2024 • edited Loading

Description

How Has This Been Tested?

audius-infra commented Feb 22, 2024

gitguardian bot commented Feb 22, 2024 • edited Loading

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

audius-infra commented Feb 23, 2024

isaacsolo commented Feb 23, 2024 • edited Loading

audius-infra commented Feb 27, 2024

dylanjeffers left a comment

Choose a reason for hiding this comment

dylanjeffers Feb 27, 2024

Choose a reason for hiding this comment

audius-infra commented Feb 27, 2024

isaacsolo commented Feb 22, 2024 •

edited

Loading

gitguardian bot commented Feb 22, 2024 •

edited

Loading

isaacsolo commented Feb 23, 2024 •

edited

Loading