Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix download buttons erroneously displaying #7763

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Fix download buttons erroneously displaying #7763

merged 1 commit into from
Mar 1, 2024

Conversation

dharit-tan
Copy link
Contributor

Description

Fixes bug where ! was accidentally added while doing an icon migration, causing download buttons to show before purchase, and vice versa.

How Has This Been Tested?

Local web stage

@sddioulde sddioulde merged commit dbc6dc1 into main Mar 1, 2024
9 of 12 checks passed
@sddioulde sddioulde deleted the rt-fix branch March 1, 2024 20:57
@audius-infra
Copy link
Collaborator

Preview this change https://demo.audius.co/rt-fix

audius-infra pushed a commit that referenced this pull request Mar 2, 2024
[73c35e5] Bump mobile app version for full-app release (#7770) Dylan Jeffers
[fa9c7ce] [PAY-2490] Delete backfill txs tables (#7768) Reed
[acf5840] Fix reset-password-modal icon + ui (#7769) Dylan Jeffers
[cb9c022] [C-3929] Fix select-artist genres (#7765) Dylan Jeffers
[709ff70] Fix reset password (#7767) Marcus Pasell
[1c1474e] [C-3708] Fix wallet text clipping issue in withdrawals table (#7762) Kyle Shanks
[7f4b187] Add an isNativeMobile prop to amplitude (#7766) JD Francis
[4f6972f] [PAY-2527] Return `playlists_containing_track` from track apis (#7764) Andrew Mendelsohn
[dbc6dc1] Fix download buttons erroneously displaying (#7763) Reed
[8cf2464] [PAY-2531] Grant access to stream track if user has purchased album (#7753) Reed
[762a9ac] [C-3926] Add error helper text to new sign in password field (#7761) Kyle Shanks
[6d6117f] [C-3885] Migrate to harmony text-link (#7746) Dylan Jeffers
[82dd8c5] Update dapp-store build artifacts audius-infra
[1c554c6] [C-3924] Fix misc font/type issues on purchase flow (#7760) Raymond Jacobson
[b695203] [C-3923] Remove double badges on purchase flow (#7759) Raymond Jacobson
[e1dd6e0] [PAY-2488] Remove stripe option from purchase flow (#7755) Raymond Jacobson
[4931acb] Bump version to 0.6.50 audius-infra
[c8eaa02] [C-2928] Add auth request signing middleware to sdk (#7724) Raymond Jacobson
[0d2d3b1] Add verifier checks to discovery relay (#7756) Raymond Jacobson
[c3f0a99] useHarmonyField (#7514) Marcus Pasell
[ce226e7] Publish harmony to npm (#7751) Sebastian Klingler
[d5c0c98] [C-3897] Fix ai-attribution dropdown (#7754) Dylan Jeffers
[26f9c7d] [PAY-2533] Index album purchases (#7735) Andrew Mendelsohn
[375f5b5] [C-3888] Add header-shadow to sign-up-screen (#7750) Dylan Jeffers
[dbbbc88] @audius/sdk: v3.0.35 audius-infra
[5125501] [DRVL-16] - Documentation Site Updates (#7699) Sam Gutentag
[2738765] Use turbo for sdk release (#7748) Sebastian Klingler
[23072cd] [C-3918] Fix wallet and dev-apps icons (#7749) Dylan Jeffers
[a4bbe1c] Update stem limit to 20 (#7745) Raymond Jacobson
[f4863c6] Fix social sign ups redirecting unintentionally (#7744) JD Francis
[557142b] Disable play button if all collection tracks deleted (#7743) Saliou Diallo
[5f28d5d] Add others to skip otp (#7741) Raymond Jacobson
[b33bc5b] Add download gated column (#7742) Saliou Diallo
[9f0f84e] Bump version to 0.6.49 audius-infra
[c2a9c46] Add ddex_app field for ddex tracks/playlists to discovery (#7734) Michelle Brier
[c932495] [PROTO-1686] Setup DDEX choreography infra and related improvements (#7739) Theo Ilie
[aec57f9] Misc sign up social fixes (#7737) JD Francis
[682a384] [ONC-35] Fix crash on android due to react native importing images as numbers (#7738) Marcus Pasell
[273be01] Misc Sign up fixes (spacing & page swipe animation) (#7736) JD Francis
[cb39083] [ONC-34] Fix bug in mobile suggested collection tracks (#7731) Saliou Diallo
[8db7400] [C-3866] Update placement of theme reset in mobile sign out to make colors display properly (#7728) Kyle Shanks
[0d15ae7] [C-3898] Fix faded gray screen android on sign up (#7730) JD Francis
[a0d314b] Bump version to 0.6.48 audius-infra
[f43e956] [PROTO-1513] Add e2e ddex test (#7733) Theo Ilie
[f5ad4c3] Fix harmony ssr (#7732) Dylan Jeffers
[06af9d2] [C-3909] Fix upload track challenge copy (#7729) Saliou Diallo
[8f73c19] [C-3899] Fix android able to go back on signup (#7727) JD Francis
[d04b4bc] [PAY-2529] Index album stream_conditions (#7720) Reed
[8966f88] [QA-779][QA-704] Fix some UI issues (#7725) Saliou Diallo
[d29c83f] Misc Sign Up QA Fixes (#7722) JD Francis
[90b098a] Discovery placement hosts (#7718) Steve Perkins
[9674780] Bump version to 0.6.47 audius-infra
[398db27] PROTO-1574: sepolia (#7698) alecsavvy
[40583e6] Improve search analytics (#7696) Isaac Solo
[3e1b544] Add env linter (#7697) Raymond Jacobson
[5a3498c] [DVRL-11] Move client history requests to sdk (#7679) Raymond Jacobson
[beb054b] Remove all usage of PROTOCOL_DIR env var (#7714) Danny
[6230eca] [PAY-2528] is_stream_gated + stream_conditions on Playlist (#7717) Reed
[4136985] [PAY-2524, PAY-2525, PAY-2526] Add collections_containing_track field to tracks (#7708) Andrew Mendelsohn
[f25cc23] Fix the same typo in another spot (#7716) Theo Ilie
[f51ccd8] [C-3858] Additional padding on select artists screen (#7715) JD Francis
[9ff7262] [C-3858] Social sign on loading screen adjustments (#7710) JD Francis
[4c3a35c] Fix typo breaking audius-compose push (#7713) Theo Ilie
[74facea] Bump mobile versions for prod release (#7712) Dylan Jeffers
[392bb21] Bump version to 0.6.46 audius-infra
dylanjeffers pushed a commit that referenced this pull request Mar 2, 2024
[73c35e5] Bump mobile app version for full-app release (#7770) Dylan Jeffers
[fa9c7ce] [PAY-2490] Delete backfill txs tables (#7768) Reed
[acf5840] Fix reset-password-modal icon + ui (#7769) Dylan Jeffers
[cb9c022] [C-3929] Fix select-artist genres (#7765) Dylan Jeffers
[709ff70] Fix reset password (#7767) Marcus Pasell
[1c1474e] [C-3708] Fix wallet text clipping issue in withdrawals table (#7762) Kyle Shanks
[7f4b187] Add an isNativeMobile prop to amplitude (#7766) JD Francis
[4f6972f] [PAY-2527] Return `playlists_containing_track` from track apis (#7764) Andrew Mendelsohn
[dbc6dc1] Fix download buttons erroneously displaying (#7763) Reed
[8cf2464] [PAY-2531] Grant access to stream track if user has purchased album (#7753) Reed
[762a9ac] [C-3926] Add error helper text to new sign in password field (#7761) Kyle Shanks
[6d6117f] [C-3885] Migrate to harmony text-link (#7746) Dylan Jeffers
[82dd8c5] Update dapp-store build artifacts audius-infra
[1c554c6] [C-3924] Fix misc font/type issues on purchase flow (#7760) Raymond Jacobson
[b695203] [C-3923] Remove double badges on purchase flow (#7759) Raymond Jacobson
[e1dd6e0] [PAY-2488] Remove stripe option from purchase flow (#7755) Raymond Jacobson
[4931acb] Bump version to 0.6.50 audius-infra
[c8eaa02] [C-2928] Add auth request signing middleware to sdk (#7724) Raymond Jacobson
[0d2d3b1] Add verifier checks to discovery relay (#7756) Raymond Jacobson
[c3f0a99] useHarmonyField (#7514) Marcus Pasell
[ce226e7] Publish harmony to npm (#7751) Sebastian Klingler
[d5c0c98] [C-3897] Fix ai-attribution dropdown (#7754) Dylan Jeffers
[26f9c7d] [PAY-2533] Index album purchases (#7735) Andrew Mendelsohn
[375f5b5] [C-3888] Add header-shadow to sign-up-screen (#7750) Dylan Jeffers
[dbbbc88] @audius/sdk: v3.0.35 audius-infra
[5125501] [DRVL-16] - Documentation Site Updates (#7699) Sam Gutentag
[2738765] Use turbo for sdk release (#7748) Sebastian Klingler
[23072cd] [C-3918] Fix wallet and dev-apps icons (#7749) Dylan Jeffers
[a4bbe1c] Update stem limit to 20 (#7745) Raymond Jacobson
[f4863c6] Fix social sign ups redirecting unintentionally (#7744) JD Francis
[557142b] Disable play button if all collection tracks deleted (#7743) Saliou Diallo
[5f28d5d] Add others to skip otp (#7741) Raymond Jacobson
[b33bc5b] Add download gated column (#7742) Saliou Diallo
[9f0f84e] Bump version to 0.6.49 audius-infra
[c2a9c46] Add ddex_app field for ddex tracks/playlists to discovery (#7734) Michelle Brier
[c932495] [PROTO-1686] Setup DDEX choreography infra and related improvements (#7739) Theo Ilie
[aec57f9] Misc sign up social fixes (#7737) JD Francis
[682a384] [ONC-35] Fix crash on android due to react native importing images as numbers (#7738) Marcus Pasell
[273be01] Misc Sign up fixes (spacing & page swipe animation) (#7736) JD Francis
[cb39083] [ONC-34] Fix bug in mobile suggested collection tracks (#7731) Saliou Diallo
[8db7400] [C-3866] Update placement of theme reset in mobile sign out to make colors display properly (#7728) Kyle Shanks
[0d15ae7] [C-3898] Fix faded gray screen android on sign up (#7730) JD Francis
[a0d314b] Bump version to 0.6.48 audius-infra
[f43e956] [PROTO-1513] Add e2e ddex test (#7733) Theo Ilie
[f5ad4c3] Fix harmony ssr (#7732) Dylan Jeffers
[06af9d2] [C-3909] Fix upload track challenge copy (#7729) Saliou Diallo
[8f73c19] [C-3899] Fix android able to go back on signup (#7727) JD Francis
[d04b4bc] [PAY-2529] Index album stream_conditions (#7720) Reed
[8966f88] [QA-779][QA-704] Fix some UI issues (#7725) Saliou Diallo
[d29c83f] Misc Sign Up QA Fixes (#7722) JD Francis
[90b098a] Discovery placement hosts (#7718) Steve Perkins
[9674780] Bump version to 0.6.47 audius-infra
[398db27] PROTO-1574: sepolia (#7698) alecsavvy
[40583e6] Improve search analytics (#7696) Isaac Solo
[3e1b544] Add env linter (#7697) Raymond Jacobson
[5a3498c] [DVRL-11] Move client history requests to sdk (#7679) Raymond Jacobson
[beb054b] Remove all usage of PROTOCOL_DIR env var (#7714) Danny
[6230eca] [PAY-2528] is_stream_gated + stream_conditions on Playlist (#7717) Reed
[4136985] [PAY-2524, PAY-2525, PAY-2526] Add collections_containing_track field to tracks (#7708) Andrew Mendelsohn
[f25cc23] Fix the same typo in another spot (#7716) Theo Ilie
[f51ccd8] [C-3858] Additional padding on select artists screen (#7715) JD Francis
[9ff7262] [C-3858] Social sign on loading screen adjustments (#7710) JD Francis
[4c3a35c] Fix typo breaking audius-compose push (#7713) Theo Ilie
[74facea] Bump mobile versions for prod release (#7712) Dylan Jeffers
[392bb21] Bump version to 0.6.46 audius-infra
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants