Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lazy Images: Fix typo in attributes filter name #10002

Merged
merged 1 commit into from
Aug 9, 2018
Merged

Lazy Images: Fix typo in attributes filter name #10002

merged 1 commit into from
Aug 9, 2018

Conversation

ebinnion
Copy link
Contributor

@ebinnion ebinnion commented Aug 8, 2018 •
edited
Loading

Fixes an issue that a user pointed out in this comment:

#8787 (comment)

Changes proposed in this Pull Request:

  • Fix a typo in jetpack_lazy_images_skip_image_with_atttributes so that the filter is jetpack_lazy_images_skip_image_with_attributes.
  • Deprecates jetpack_lazy_images_skip_image_with_atttributes filter

Testing instructions:

  • phpunit --filter=WP_Test_Lazy_Images to ensure that both filters work

Proposed changelog entry for your changes:

Deprecates jetpack_lazy_images_skip_image_with_atttributes filter in favor of jetpack_lazy_images_skip_image_with_attributes to address typo.

@ebinnion ebinnion added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Feature] Lazy Images labels Aug 8, 2018
@ebinnion ebinnion added this to the 6.5 milestone Aug 8, 2018
@ebinnion ebinnion self-assigned this Aug 8, 2018
@ebinnion ebinnion requested review from oskosk and gititon August 8, 2018 15:33
@ebinnion ebinnion requested a review from a team as a code owner August 8, 2018 15:33
@ebinnion ebinnion force-pushed the update/lazy-images-filter-typo branch from e5c5f4b to bac4afe Compare August 8, 2018 15:33
@ebinnion ebinnion requested a review from a team as a code owner August 8, 2018 15:33
@ebinnion ebinnion mentioned this pull request Aug 8, 2018
Merged
@eliorivero eliorivero added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Aug 8, 2018
@eliorivero
Copy link
Contributor

Tests work fine 🐑
I've restarted a couple of tests where Travis timed out

@zinigor zinigor merged commit 1a6d6ac into master Aug 9, 2018
@ghost ghost removed the [Status] Ready to Merge Go ahead, you can push that green button! label Aug 9, 2018
@zinigor zinigor deleted the update/lazy-images-filter-typo branch August 9, 2018 12:48
oskosk pushed a commit that referenced this pull request Aug 28, 2018
@abidhahmed @oskosk
[skip-ci] Added changelogs
7c86fd2 
#9958 
#9983 
#9992 
#10002 
#10004
#10010
#10011
#10017
#10031
#10037
#10039
#10040
#10051
oskosk pushed a commit that referenced this pull request Aug 28, 2018
@abidhahmed @oskosk
[skip-ci] Add test instructions
1942746 
#9958
#9983
#9992 
#10002
#10004
#10010
#10017
#10031
#10037
#10039
#10040
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliorivero eliorivero eliorivero approved these changes

@oskosk oskosk Awaiting requested review from oskosk

@gititon gititon Awaiting requested review from gititon

Assignees

@ebinnion ebinnion

Labels
[Feature] Lazy Images [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
6.5
Development

Successfully merging this pull request may close these issues.
5 participants
@ebinnion @eliorivero @zinigor @abidhahmed @matticbot