Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Widgets: Twitter Timeline - Remove Cutoff Date that has now passed #10011

Merged
merged 1 commit into from
Aug 13, 2018
Merged

Widgets: Twitter Timeline - Remove Cutoff Date that has now passed #10011

merged 1 commit into from
Aug 13, 2018

Conversation

mdawaffe
Copy link
Member

Twitter stopped supporting the widget-id parameter on 2018-07-27. Ahead
of time, we hardcoded a cutoff date near then as part of a warning to
folks.

That date is in the past, so we no longer need the check.

See #9575

Changes proposed in this Pull Request:

  • Remove cutoff date check that is no longer necessary.

Testing instructions:

  1. Agree that time() > 1532563200 :)

@mdawaffe
Widgets: Twitter Timeline - Remove Cutoff Date that has now passed
7ae0a50 
Twitter stopped supporting the `widget-id` parameter on 2018-07-27. Ahead
of time, we hardcoded a cutoff date near then as part of a warning to
folks.

That date is in the past, so we no longer need the check.

See #9575
@mdawaffe mdawaffe requested a review from Copons August 10, 2018 00:14
@mdawaffe mdawaffe requested a review from a team as a code owner August 10, 2018 00:14
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Please review this diff before merging: D17084-code. (newly created revision)

@jetpackbot
Copy link

Warnings
⚠️

The PR is missing at least one [Status] label. Suggestions: [Status] In Progress, [Status] Needs Review

Generated by 🚫 dangerJS

@mdawaffe mdawaffe added [Feature] Extra Sidebar Widgets [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Aug 10, 2018
@abidhahmed abidhahmed added this to the 6.5 milestone Aug 10, 2018
abidhahmed
abidhahmed approved these changes Aug 10, 2018
View reviewed changes
Copy link
Contributor

@abidhahmed abidhahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@abidhahmed abidhahmed added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Aug 10, 2018
@brbrr brbrr added the [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it label Aug 13, 2018
@mdawaffe mdawaffe merged commit 53562fc into master Aug 13, 2018
@mdawaffe mdawaffe deleted the remove/passed-twitter-timeline-cutoff branch August 13, 2018 22:13
@ghost ghost removed the [Status] Ready to Merge Go ahead, you can push that green button! label Aug 13, 2018
oskosk pushed a commit that referenced this pull request Aug 28, 2018
@abidhahmed @oskosk
[skip-ci] Added changelogs
7c86fd2 
#9958 
#9983 
#9992 
#10002 
#10004
#10010
#10011
#10017
#10031
#10037
#10039
#10040
#10051
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abidhahmed abidhahmed abidhahmed approved these changes

@Copons Copons Copons approved these changes

Assignees

@mdawaffe mdawaffe

Labels
[Feature] Extra Sidebar Widgets Touches WP.com Files [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
6.5
Development

Successfully merging this pull request may close these issues.
6 participants
@mdawaffe @matticbot @jetpackbot @Copons @abidhahmed @brbrr