-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Wufoo safe for https usage and async #10017
Conversation
Summary: This removes the ssl argument of shortcode and replaces everything to work over https. SSL used to be a paid feature over at Wufoo but that changed 5 years ago https://www.wufoo.com/blog/making-wufoo-more-secure-https/ It also turns the old embed codes into their new async version and makes sure only a single `form.js` would be loaded even for multiple forms. Test Plan: Test with various wufoo embed shortcodes, all should work over https, regardless whether they set https argument (to true/false) or not at all. Reviewers: paulbunkham Reviewed By: paulbunkham Subscribers: mdawaffe, paulbunkham, jblz Tags: #touches_jetpack_files Differential Revision: D16996-code This commit syncs r179447-wpcom.
This is automated (and not very smart btw) check which relies on Generated by 🚫 dangerJS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks reasonable. Do you have any specific tests I can try? I don't have a wufoo account. What URLs were you testing?
Wufoo now appends ssl="true" but that's not the case for many embeds generated in the past and they are missing that param forcing the old behavior to load over HTTP. Some more forms (that I don't own so never submit!) 1ef08-pb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks good.
Summary:
This removes the ssl argument of shortcode and replaces everything to work over https. SSL used to be a paid feature over at Wufoo but that changed 5 years ago https://www.wufoo.com/blog/making-wufoo-more-secure-https/
It also turns the old embed codes into their new async version and makes sure only a single
form.js
would be loaded even for multiple forms.Testing instructions: Test with various wufoo embed shortcodes, all should work over https, regardless whether they set https argument (to true/false) or not at all.
Reviewers: paulbunkham
Reviewed By: paulbunkham
Subscribers: mdawaffe, paulbunkham, jblz
Tags: #touches_jetpack_files
Differential Revision: D16996-code
This commit syncs r179447-wpcom.
Proposed changelog entry for your changes:
Updated Wufoo Shortcode to always load over https and use async form embed.