-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JITMs: Fix styling to work better with a popular plugin #10539
Conversation
Worked with Jeff to fix #9221
This is automated check which relies on Generated by 🚫 dangerJS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It worked well for me in Safari, Firefox, Chrome, and on Chrome for Android. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great in my testing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jeffgolenski and I worked together to fix some styling issues. <!--- Provide a general summary of your changes in the Title above --> Fixes #9221 #### Changes proposed in this Pull Request: <!--- Explain what functional changes your PR includes --> Fix some spacing when a popular plugin is present: <img width="847" alt="screen shot 2018-11-05 at 5 50 24 pm" src="https://user-images.githubusercontent.com/1883296/48013289-41929d80-e124-11e8-8dea-f6b7de9af1b1.png"> #### Testing instructions: <!-- Please include detailed testing steps, explaining how to test your change. --> <!-- Bear in mind that context you working on is not obvious for everyone. --> <!-- Adding "simple" configuration steps will help reviewers to get to your PR as quickly as possible. --> <!-- "Before / After" screenshots can also be very helpful when the change is visual. --> 1. Turn on Hello Dolly on a site with no plan and akismet inactive 2. View the comments page 3. See a jitm that doesn't collide with the hello dolly text #### Proposed changelog entry for your changes: <!-- Please do not leave this empty. If no changelog entry needed, state as such. --> No changelog entry is needed except maybe: Improved plugin compatibility
Cherry-picked to |
@jeffgolenski @withinboredom I'm seeing some issues now when Hello Dolly isn't installed:
It looks like we have some missing padding on the right. |
…)" This reverts commit 1e807b2. Let's not ship this just yet, as we need to fix this issue first: #10539 (comment)
Until the above is fixed, let's not ship that Hello Dolly fix: I reverted here: |
I'll take another look at it soon, @jeherve - thanks for the double check |
…)" This reverts commit af7011b.
I just moved this into the early value project to ensure it gets fixed this week! |
@jeherve were you only testing this on Jurassic ninja sites? I noticed that everything works and looks as intended, except for JN sites, because JN throws some CSS right in-between the screen meta box and the JITM, which is just messing with the JITM styles. see how it works fine in a sandbox: https://cloudup.com/cMVM6scsT9h But this CSS messed up the JITM declarations that we have written because it gets in the way of |
@jeherve Here's an example of that I mean: https://cloudup.com/i5wSzcK89pb |
I don't recall, sorry. The screenshot above is from a JN site for sure, but I don't remember if I tested somewhere else as well. I'll test your patch in #10840! |
@jeffgolenski and I worked together to fix some styling issues.
Fixes #9221
Changes proposed in this Pull Request:
Fix some spacing when a popular plugin is present:
Testing instructions:
Proposed changelog entry for your changes:
No changelog entry is needed except maybe: Improved plugin compatibility