Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JITMs: Fix styling to work better with a popular plugin, take 2 #10816

Closed
wants to merge 1 commit into from

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Dec 4, 2018

fixes #9221

Changes proposed in this Pull Request:

Another take on #10539, that had to be reverted.

Testing instructions:

  1. Turn on Hello Dolly on a site with no plan and akismet inactive
  2. View the comments page
  3. See a jitm that doesn't collide with the hello dolly text
  4. Turn off Hello Dolly
  5. Make sure the JITMs still look good.

Proposed changelog entry for your changes:

  • Notices: fix styling to work better with the Hello Dolly plugin

@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended [Status] In Progress [Feature] JITM Just In Time Messages - pop-up tips and suggestions that appear on the dashboard and sidebar. labels Dec 4, 2018
@jeherve jeherve added this to the 6.9 milestone Dec 4, 2018
@jeherve jeherve requested a review from a team as a code owner December 4, 2018 20:19
@jetpackbot
Copy link

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: January 10, 2019.
Scheduled code freeze: January 3, 2019

Generated by 🚫 dangerJS

@jeherve
Copy link
Member Author

jeherve commented Dec 5, 2018

closing. Replaced by #10840

@jeherve jeherve closed this Dec 5, 2018
@jeherve jeherve deleted the fix/hello-dolly branch December 5, 2018 17:39
@jeffgolenski jeffgolenski restored the fix/hello-dolly branch December 8, 2018 20:39
@kraftbj kraftbj deleted the fix/hello-dolly branch May 24, 2019 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] JITM Just In Time Messages - pop-up tips and suggestions that appear on the dashboard and sidebar. [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JITMs: be nice to Dolly
5 participants