Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JITMs: Fix styling to work better with a popular plugin, take 2 #10840

Merged
merged 3 commits into from
Dec 13, 2018
Merged

JITMs: Fix styling to work better with a popular plugin, take 2 #10840

merged 3 commits into from
Dec 13, 2018

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Dec 5, 2018

fixes #9221

Changes proposed in this Pull Request:

Another take on #10539, that had to be reverted.

Testing instructions:

  1. Turn on Hello Dolly on a site with no plan and akismet inactive
  2. View the comments page
  3. See a jitm that doesn't collide with the hello dolly text
  4. Turn off Hello Dolly
  5. Make sure the JITMs still look good.

Proposed changelog entry for your changes:

  • Notices: fix styling to work better with the Hello Dolly plugin

@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended [Status] In Progress [Feature] JITM Just In Time Messages - pop-up tips and suggestions that appear on the dashboard and sidebar. labels Dec 5, 2018
@jeherve jeherve added this to the 6.9 milestone Dec 5, 2018
@jeherve jeherve requested a review from a team as a code owner December 5, 2018 17:38
@jeherve jeherve mentioned this pull request Dec 5, 2018
Closed
@jetpackbot
Copy link

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: January 10, 2019.
Scheduled code freeze: January 3, 2019

Generated by 🚫 dangerJS

@jeffgolenski
JITM card styling: moving styles for jitm and dolly
75e2a6b 
JITM card styling: moving styles for jitm and dolly
@jeffgolenski
JITMS: adding new default margins to jitm container
be4f2ef 
JITMS: adding new default margins to jitm container
@jeffgolenski
Copy link
Member

Having some conversation about this over here: #10539 (comment)

@jeffgolenski jeffgolenski added [Status] Needs Review To request a review from Crew. Label will be renamed soon. and removed [Status] In Progress labels Dec 8, 2018
@jeffgolenski
Copy link
Member

Fixed the general margins of the JITM.

Here's what it looks like with and without dolly:

With:
screen shot 2018-12-08 at 5 14 16 pm

Without:
screen shot 2018-12-08 at 5 15 04 pm

Make sure you test on a non-jurassic ninja site as well as with a JN site.

@jeherve jeherve mentioned this pull request Dec 10, 2018
Merged
oskosk
oskosk approved these changes Dec 11, 2018
View reviewed changes
Copy link
Contributor

@oskosk oskosk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oskosk oskosk added [Status] Ready to Merge Go ahead, you can push that green button! [Status] Design Review Complete and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Dec 11, 2018
@oskosk oskosk merged commit e385009 into master Dec 13, 2018
@oskosk oskosk deleted the fix/hello-dolly-strikes-back branch December 13, 2018 21:41
@ghost ghost removed the [Status] Ready to Merge Go ahead, you can push that green button! label Dec 13, 2018
jeherve added a commit that referenced this pull request Dec 19, 2018
@jeherve
changelog: add #10840
133ebe2
jeherve added a commit that referenced this pull request Jan 3, 2019
@jeherve
changelog: add #10840
a322f02
jeherve added a commit that referenced this pull request Jan 3, 2019
@jeherve
Jetpack 6.9: Changelog and testing list (#10722)
8d91603 
* Add first version of the Changelog and testing list for 6.9

* Changelog: add #10710

* changelog: add #10538

* changelog: add #10741

* changelog: add #10749

* changelog: add #10664

* changelog: add #10224

* changelog: add #10788

* Changelog: add #10560

* Chanegelog: add #10812

* changelog: add #10556

* Changelog: add #10668

* Changelog: add #10846

* Changelog: add #10947

* Changelog: add #10962

* Changelog: add #10956

* Changelog: add #10940

* Changelog: add #10934

* Changelog: add #10912

* changelog: add #10866

* changelog: add #10924

* Changelog: add #10936

* Changelog: add #10833

* changelog: add #10867

* Changelog: add #10960

* Changelog: add #10888

* changelog: add #10840

* changelog: add #10972

* Changelog: add #10979

* changelog: add #10909

* Changelog: add #10958

* Changelog: add #10981

* Changelog: add #10564

* Changelog: add #10809

* Changelog: add #10982

* Changelog: add #10706

* Changelog: add #10978

* Changelog: add #10132

* Changelog: add #11022

* Changelog: add #11024

* Changelog: add #10875

* Changelog: add #11030

* Changelog: add #11053

* Changelog: add #10880

* Changelog: add #9359

* Changelog: add #11037

* Update block list

* Changelog: add #11060

* Changelog: add #10755

* changelog: add #11000

* Changelog: add #10786

* Changelog: add #10945

* Changelog: add #10597
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oskosk oskosk oskosk approved these changes

Assignees

@jeffgolenski jeffgolenski

Labels
[Feature] JITM Just In Time Messages - pop-up tips and suggestions that appear on the dashboard and sidebar. [Status] Design Review Complete [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
6.9
Development

Successfully merging this pull request may close these issues.

JITMs: be nice to Dolly
6 participants
@jeherve @jetpackbot @jeffgolenski @oskosk @matticbot @withinboredom