Removes all After the Deadline references from Jetpack #11772

rodrigoi · 2019-03-29T22:06:59Z

Fixes Automattic/wp-calypso#31865
This complements Automattic/wp-calypso#31880

Closes #9128
Closes #5640
Closes #3999
Closes #3506

Changes proposed in this Pull Request:

This PR removes all references for After the Deadline from Jetpack. This includes module, settings and the classic editor block.

	Before	After
Writing Settings
Classic Editor Block

Testing instructions:

On an site with an active Jetpack connection:

Go to Jetpack > Settings > Writing and look for the Composing card.
Verify that the remaining options work as expected.
Edit or Create a Post or Page with the Block Editor.
Switch to the Code Editor view.
Add text to the code editor without adding any tags to activate the Classic Editor Block.
Switch back to Visual Editor.
Click on the Classic Editor Block and verify that all options work as expected.

Proposed changelog entry for your changes:

After the Deadline proofreading service module removed

matticbot · 2019-03-29T22:07:04Z

Caution: This PR has changes that must be merged to WordPress.com
Hello rodrigoi! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D26213-code before merging this PR. Thank you!

mmtr · 2019-03-30T02:15:31Z

Are the changes on the yarn.lock file intended?

mmtr

This is working for me as expected.

Note that this also removes the "Proofreading Writing" on posts created with the Classic editor (after activate the Classic editor plugin).

Before	After

Switch to the Code Editor view.

Add text to the code editor without adding any tags to activate the Classic Editor Block.

Switch back to Visual Editor.

You can also insert a classic block directly without switching modes:

simison · 2019-03-31T19:32:57Z

Note this convo about removing/deprecating PHP files: #11713 (review)

We might want to keep them around for a couple Jetpack versions.

kraftbj · 2019-04-01T03:50:09Z

Yup, at least want to keep modules/after-the-deadline.php. The issue as best I'm able to deduce is how we include module files (e.g. autoload any *.php file from the modules dir) is what is problematic since opcache will store what those files are in memory when the actual files are then deleted. https://github.com/Automattic/jetpack/blob/master/modules/wpcc.php for an example.

To help me understand the decision to drop the feature, can you drop the shortlink anchor/link to the p2 discussion. I want to make sure our Happiness team is looped in and we have plenty of time to update documentation and prepare predefs for any questions about this.

kraftbj

modules/after-the-deadline.php needs to stay as a deprecated module file.

rodrigoi · 2019-04-01T16:43:02Z

@kraftbj @simison thanks for taking a look at this! So, to correct procedure would be to mark the module as deprecated and remove the menu item from the classic editor plugin? Or can I remove the tinymce plugin files?

I'll probably close this PR and open a new one with the new changes.

kraftbj · 2019-04-01T20:22:24Z

I think you can delete everything as you did, just leave the modules/after-the-deadline.php file with a stub, exactly like https://github.com/Automattic/jetpack/blob/master/modules/wpcc.php did.

jetpackbot · 2019-04-02T23:59:56Z

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: April 29, 2019.
Scheduled code freeze: April 22, 2019

Generated by 🚫 dangerJS against 6e49ccd

kwight · 2019-04-03T19:40:15Z

To help me understand the decision to drop the feature, can you drop the shortlink anchor/link to the p2 discussion.

@kraftbj I believe it stemmed from Automattic/wp-calypso#28550 (comment)

kwight · 2019-04-03T19:40:53Z

After a fresh yarn build upon switching branches, it all works (or, uh, is missing) as expected 👍

gwwar · 2019-04-04T19:46:34Z

@kraftbj Besides getting a clean CI run, was there any other feedback to address, or are we mostly okay here?

jeherve

This looks good and tests well. I would only recommend that you remove the yarn.lock changes from this PR, since they are not related to the module changes.

Feedback addressed

rodrigoi · 2019-04-24T18:25:21Z

@simison rebased, retested and ready for review. The companion diff for WordPress.com is un-fusionable, so I'll force the test status on the MC tool.

yarn.lock file removed from the diff.

kraftbj · 2019-04-24T19:45:36Z

All this looks good—are we going to clean up any user meta AtD options? AtD_options, AtD_check_when, AtD_guess_lang, AtD_ignored_phrases?

Since cycling through every user could be too taxing, just something like filtering when an user is updated to check/remove that meta?

rodrigoi · 2019-04-24T20:57:36Z

@kraftbj I don't have a strong plan for cleaning user meta, because I'm not very familiar with the sync process and where is the best place to do it. But it's something for another (smaller) PR.

kraftbj · 2019-04-24T21:07:55Z

It's unrelated to sync. It would be on the local Jetpack site.

class.jetpack.php

kraftbj · 2019-04-24T22:10:12Z

I'd like to test my changes outside of my local environment, but running out of time for today. I'll circle back to this tomorrow.

kraftbj · 2019-04-25T14:38:46Z

Before and after with an existing user with AtD preferences then updates the user after this patch:

class.jetpack.php

jeherve

This works well in my end. 👍 🚢 💀

Did a pass over _inc/client/components looking for things that weren't used anywhere, and found a bunch: * components/data/query-connect-url - Last use removed in #8014 * components/data/query-connection-status - Last use removed in 62e9ab0 * components/data/query-modules - Last use removed in bfc40ad * components/data/query-plugin-updates - Last use removed in #17003 * components/data/query-site-products - Last use removed in #21594 * components/form/* - Didn't check for last use, too many bits. But it looks like the `formsy-react` package many of these depended on wasn't even installed since #8208. * components/inline-expand - Last use removed in #6550 * components/jetpack-dialogue - Last use removed in #16518 * components/jetpack-logo - Last use removed in #20148 * components/jetpack-termination-dialog - Last use removed in #21048 * components/module-settings/index.jsx - Last use removed in #10644 * components/module-settings/inline-module-toggle.jsx - Last use removed in #12118 * components/screen-reader-text - Last use removed in #18843 * components/settings - Last use removed in 26315e1, I think * components/tags-input - Last use removed in #11772 Then there were a few more that were only used from some of the above: * components/data/query-connected-plugins * components/module-settings/form-components.jsx * components/multiple-choice-question * components/setting-toggle

Did a pass over _inc/client/components looking for things that weren't used anywhere, and found a bunch: * components/data/query-connect-url - Last use removed in #8014 * components/data/query-connection-status - Last use removed in 62e9ab0 * components/data/query-modules - Last use removed in bfc40ad * components/data/query-plugin-updates - Last use removed in #17003 * components/data/query-site-products - Last use removed in #21594 * components/form/* - Didn't check for last use, too many bits. But it looks like the `formsy-react` package many of these depended on wasn't even installed since #8208. * components/inline-expand - Last use removed in #6550 * components/jetpack-dialogue - Last use removed in #16518 * components/jetpack-logo - Last use removed in #20148 * components/jetpack-termination-dialog - Last use removed in #21048 * components/module-settings/index.jsx - Last use removed in #10644 * components/module-settings/inline-module-toggle.jsx - Last use removed in #12118 * components/screen-reader-text - Last use removed in #18843 * components/settings - Last use removed in 26315e1, I think * components/tags-input - Last use removed in #11772 Then there were a few more that were only used from some of the above: * components/data/query-connected-plugins * components/module-settings/form-components.jsx * components/multiple-choice-question * components/setting-toggle Co-authored-by: Brandon Kraft <public@brandonkraft.com>

rodrigoi self-assigned this Mar 29, 2019

rodrigoi requested a review from a team as a code owner March 29, 2019 22:07

matticbot added the Touches WP.com Files label Mar 29, 2019

rodrigoi mentioned this pull request Mar 29, 2019

Site Settings: removes After the Deadline Automattic/wp-calypso#31880

Merged

rodrigoi added the [Status] In Progress label Mar 29, 2019

Automattic deleted a comment from jetpackbot Mar 29, 2019

rodrigoi added [Status] Needs Review To request a review from Crew. Label will be renamed soon. and removed [Status] In Progress labels Mar 30, 2019

rodrigoi requested a review from a team March 30, 2019 00:09

mmtr previously approved these changes Mar 30, 2019

View reviewed changes

kraftbj previously requested changes Apr 1, 2019

View reviewed changes

kraftbj added this to the 7.3 milestone Apr 1, 2019

rodrigoi dismissed mmtr’s stale review via 02976b8 April 2, 2019 23:54

jeherve previously requested changes Apr 5, 2019

View reviewed changes

rodrigoi force-pushed the update/remove-after-the-deadline branch from 31658cd to ffd8ad7 Compare April 5, 2019 15:19

rodrigoi added [Status] Needs Review To request a review from Crew. Label will be renamed soon. and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Apr 24, 2019

kraftbj added 2 commits April 24, 2019 16:24

Deprecate AtD hooks

a892de0

Remove meta on next user save

5079584

rodrigoi commented Apr 24, 2019

View reviewed changes

class.jetpack.php Show resolved Hide resolved

kraftbj self-assigned this Apr 24, 2019

kraftbj approved these changes Apr 25, 2019

View reviewed changes

kraftbj added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Apr 25, 2019

eliorivero reviewed Apr 25, 2019

View reviewed changes

class.jetpack.php Show resolved Hide resolved

Merge branch 'master' into update/remove-after-the-deadline

911b41c

jeherve approved these changes Apr 25, 2019

View reviewed changes

rodrigoi merged commit 926490b into master Apr 25, 2019

matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Apr 25, 2019

rodrigoi deleted the update/remove-after-the-deadline branch April 25, 2019 19:48

kraftbj added [Status] Has Changelog and removed [Status] Needs Changelog labels Apr 30, 2019

kraftbj added a commit that referenced this pull request Apr 30, 2019

CL: #11772

655de57

rodrigoi mentioned this pull request May 3, 2019

Gutenberg: After the Deadline alternative Automattic/wp-calypso#32798

Open

anomiex mentioned this pull request May 10, 2022

jetpack: Remove unused JS client components #24319

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Removes all After the Deadline references from Jetpack #11772

Removes all After the Deadline references from Jetpack #11772

rodrigoi commented Mar 29, 2019 •

edited by jeherve

Loading

matticbot commented Mar 29, 2019

mmtr commented Mar 30, 2019

mmtr left a comment

simison commented Mar 31, 2019 •

edited

Loading

kraftbj commented Apr 1, 2019

kraftbj left a comment

rodrigoi commented Apr 1, 2019

kraftbj commented Apr 1, 2019

jetpackbot commented Apr 2, 2019 •

edited

Loading

kwight commented Apr 3, 2019

kwight commented Apr 3, 2019 •

edited

Loading

gwwar commented Apr 4, 2019

jeherve left a comment

rodrigoi commented Apr 24, 2019

kraftbj commented Apr 24, 2019

rodrigoi commented Apr 24, 2019

kraftbj commented Apr 24, 2019

kraftbj commented Apr 24, 2019

kraftbj commented Apr 25, 2019

jeherve left a comment

Removes all After the Deadline references from Jetpack #11772

Removes all After the Deadline references from Jetpack #11772

Conversation

rodrigoi commented Mar 29, 2019 • edited by jeherve Loading

Changes proposed in this Pull Request:

Testing instructions:

Proposed changelog entry for your changes:

matticbot commented Mar 29, 2019

mmtr commented Mar 30, 2019

mmtr left a comment

Choose a reason for hiding this comment

simison commented Mar 31, 2019 • edited Loading

kraftbj commented Apr 1, 2019

kraftbj left a comment

Choose a reason for hiding this comment

rodrigoi commented Apr 1, 2019

kraftbj commented Apr 1, 2019

jetpackbot commented Apr 2, 2019 • edited Loading

kwight commented Apr 3, 2019

kwight commented Apr 3, 2019 • edited Loading

gwwar commented Apr 4, 2019

jeherve left a comment

Choose a reason for hiding this comment

rodrigoi commented Apr 24, 2019

kraftbj commented Apr 24, 2019

rodrigoi commented Apr 24, 2019

kraftbj commented Apr 24, 2019

kraftbj commented Apr 24, 2019

kraftbj commented Apr 25, 2019

jeherve left a comment

Choose a reason for hiding this comment

rodrigoi commented Mar 29, 2019 •

edited by jeherve

Loading

simison commented Mar 31, 2019 •

edited

Loading

jetpackbot commented Apr 2, 2019 •

edited

Loading

kwight commented Apr 3, 2019 •

edited

Loading