Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jetpack: Remove unused JS client components #24319

Merged
merged 2 commits into from
May 10, 2022

Conversation

anomiex
Copy link
Contributor

@anomiex anomiex commented May 10, 2022

Changes proposed in this Pull Request:

Did a pass over _inc/client/components looking for things that weren't
used anywhere, and found a bunch:

Then there were a few more that were only used from some of the above:

  • components/data/query-connected-plugins
  • components/module-settings/form-components.jsx
  • components/multiple-choice-question
  • components/setting-toggle

Jetpack product discussion

None

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Is CI happy?
  • There should be no changes to the build other than a few unused rules removed from the built _inc/build/style.min.css (and its rtl version).

Did a pass over _inc/client/components looking for things that weren't
used anywhere, and found a bunch:

* components/data/query-connect-url - Last use removed in #8014
* components/data/query-connection-status - Last use removed in 62e9ab0
* components/data/query-modules - Last use removed in bfc40ad
* components/data/query-plugin-updates - Last use removed in #17003
* components/data/query-site-products - Last use removed in #21594
* components/form/* - Didn't check for last use, too many bits. But it
  looks like the `formsy-react` package many of these depended on wasn't
  even installed since #8208.
* components/inline-expand - Last use removed in #6550
* components/jetpack-dialogue - Last use removed in #16518
* components/jetpack-logo - Last use removed in #20148
* components/jetpack-termination-dialog - Last use removed in #21048
* components/module-settings/index.jsx - Last use removed in #10644
* components/module-settings/inline-module-toggle.jsx - Last use removed
  in #12118
* components/screen-reader-text - Last use removed in #18843
* components/settings - Last use removed in 26315e1, I think
* components/tags-input - Last use removed in #11772

Then there were a few more that were only used from some of the above:

* components/data/query-connected-plugins
* components/module-settings/form-components.jsx
* components/multiple-choice-question
* components/setting-toggle
@anomiex anomiex added [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Type] Janitorial [Pri] Normal labels May 10, 2022
@anomiex anomiex self-assigned this May 10, 2022
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello anomiex! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D80487-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@github-actions github-actions bot added [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ Admin Page React-powered dashboard under the Jetpack menu labels May 10, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 10, 2022

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Jetpack plugin:

  • Next scheduled release: June 7, 2022.
  • Scheduled code freeze: May 31, 2022.

@anomiex
Copy link
Contributor Author

anomiex commented May 10, 2022

Really all this was because I started to remove the dep on react-tagsinput, as it seems to be dead and we're not using it. And also formsy-react, which may not be dead but we're not using it either, but then it turned out we so weren't using it that we didn't even have it in package.json 🤣 Then I decided to take a look through the rest of the components too.

@anomiex anomiex merged commit d878bee into master May 10, 2022
@anomiex anomiex deleted the remove/jetpack-unused-components branch May 10, 2022 18:29
@anomiex
Copy link
Contributor Author

anomiex commented May 10, 2022

r245371-wpcom

@github-actions github-actions bot removed the [Status] Needs Review To request a review from Crew. Label will be renamed soon. label May 10, 2022
@github-actions github-actions bot added this to the jetpack/11.0 milestone May 10, 2022
@github-actions
Copy link
Contributor

Great news! One last step: head over to your WordPress.com diff, D80487-code, and deploy it.
Once you've done so, come back to this PR and add a comment with your changeset ID.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin Page React-powered dashboard under the Jetpack menu [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal Touches WP.com Files [Type] Janitorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants