Recommendations: update button in My Plan to go to Recommendations

[jeherve]

Changes proposed in this Pull Request:

In #12277 and #12429, we added a "checklist" component to the Jetpack dashboard, as well as a CTA that would lead you to the checklist in Calypso.
We never really expanded on that checklist and its display in the React dashboard, but we now have a Recommendations component we use in Jetpack, since #18437.

This commit removes the elements from the checklist that we never used, and updates the CTA link in "My Plan" to point to the new Recommendations, when those recommendations must be shown to site owners.

Jetpack product discussion

• p1HpG7-asW-p2
• p1HpG7-bcl-p2#comment-44627

Does this pull request change what data or activity we track or use?

This PR introduces a new Tracks event that will be triggered when clicking on the button. It respects the same rules as the existing Tracks events on that page.

Testing instructions:

I would recommend testing this with an Atomic site as well as a Jetpack site.

• Go to Jetpack > Dashboard > My Plan on a site that's connected to WordPress.com
  • If the site is Atomic, you should not see any button

* If the site is a Jetpack site, you should see this button

• Clicking on the button should lead you to the Recommendations tab.
• Nothing else should be broken in the dashboard.

Proposed changelog entry for your changes:

• N/A

[jetpackbot]

Scheduled Jetpack release: March 2, 2021.
Scheduled code freeze: February 22, 2021

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Generated by 🚫 dangerJS against d529792

[sdixon194]

This tests well for me! Going to hold off on approval until someone a bit more familiar with React can take a gander, but everything works as expected for me. 👍

[leogermani]

Tested following the instructions on an Atomic site and on a Jetpack site. All worked as expected and I saw no errors.

I'm not a React expert either but the code changes look good. Always feel good to remove old code :)

Well done

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ All commits were linted before commit.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Include a changelog entry for any meaningful change.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

If you are an automattician, once your PR is ready for review add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.undefined

---

jetpack plugin:

• Next scheduled release: March 2, 2021.
• Scheduled code freeze: February 22, 2021

[jeherve]

I had to commit again to fix a linting warning. I would appreciate another review on this :)

Thank you!

[sdixon194]

Still works!