-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slideshow Shortcode: Add labels to navigation buttons for accessibility #13739
Conversation
Caution: This PR has changes that must be merged to WordPress.com |
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: March 3, 2020. |
@codestor4 @jeherve is there anything I can do to move this PR along? I don't want to step on anyone's work, but having this fix would help our site owners out. Thank you! |
Hi! I'm trying to get started with WP and would be interested in helping push this across the finish line .... @codestor4 , @jeherve , is there anything I can do? I've made the suggested changes locally on top of the original PR, but not sure what the proper process or etiquette would be for this. Thanks! |
@coleshaw Thanks for the ping. I'm going to try and get to this before Monday but if I don't, feel free to take this one. The next steps on submitting a patch are available here - https://github.com/Automattic/jetpack/blob/master/docs/CONTRIBUTING.md#write-and-submit-a-patch |
codestor4, Your synced wpcom patch D33966-code has been updated. |
codestor4, Your synced wpcom patch D33966-code has been updated. |
codestor4, Your synced wpcom patch D33966-code has been updated. |
codestor4, Your synced wpcom patch D33966-code has been updated. |
codestor4, Your synced wpcom patch D33966-code has been updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works well for me too, but I'll let someone else review as well so we get more eyes on that last iteration. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Works as intended and approach looks good to me.
Definitely an improvement, thanks! Has there been any consideration of changing
to
? (I can open a new Issue if not.) |
@GaryJones I don't believe this has been discussed, no. You can certainly open an issue, however I should mention that the slideshow shortcode isn't really under active development right now since we now have a Slideshow block. We can review Pull Requests if you'd like to contribute a patch though! |
* 8.3 release: changelog * Changelog: add #14516 * Changelog: add #14574 * Bring in changes from 8.2.1 and 8.2.2 * Update stable version * Bring in 8.2.3 changes * Changelog: add #14714 * Changelog: add #14639 * Changelog: add #14678 * Changelog: add #14673 * Changelog: add #14687 * Changelog: add #14704 * Changelog: add #14702 * Changelog: add #14541 * Changelog: add #14657 * Changelog: add #14622 * Changelog: add #14582 * Changelog: add #14638 * Changelog: add #14633 * Changelog: add #14571 * Changelog: add #14592 * Changelog: add #14539 * Changelog: add #14514 * Changelog: add #14643 * Changelog: add #14494 * Changelog: add #13739 * Changelog: add #14707 * Changelog: add #14736 * Changelog: add #14706 * Changelog: add #14730 * Changelog: add #14685 * Changelog: add #14727 * Changelog: add #14711 * Changelog: add #14742 * Changelog: add #14746 * Changelog: add #14725 * Changelog: add #13999 * Changelog: add #14740 * Changelog: add #14759 * Changelog: add #14703 * Changelog: add #14753 * Changelog: add #14754 * Changelog: add #14645 * Cahngelog: add #14599
Changes proposed in this Pull Request:
aria-label
androle
(similar to what we have in slideshow block).Testing instructions:
aria-label
androle
attributes for slideshow controls (check the screenshot below)Proposed changelog entry for your changes:
Other notes:
I have made changes to the JS file and not the PHP file because the controls are rendered via JS. Thus it is much simpler to make the change this way.