Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gif block: Update placeholder #14571

Merged
merged 1 commit into from
Feb 13, 2020
Merged

Gif block: Update placeholder #14571

merged 1 commit into from
Feb 13, 2020

Conversation

scruffian
Copy link
Member

Changes proposed in this Pull Request:

  • Makes some changes the the placeholder for the Gif block to make it more aligned with other embed blocks

Testing instructions:

  • Create a post
  • Add a Gif block
  • Check that the placeholder looks like this:

Screenshot 2020-02-04 at 11 49 16

* Check that the block preview looks like this:

Screenshot 2020-02-04 at 11 49 25

Proposed changelog entry for your changes:

  • no changelog

@scruffian scruffian requested a review from a team as a code owner February 4, 2020 19:49
@scruffian scruffian self-assigned this Feb 4, 2020
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello scruffian! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D38512-code before merging this PR. Thank you!

@scruffian scruffian added [Block] GIF [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack labels Feb 4, 2020
@jetpackbot
Copy link

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: February 11, 2020.
Scheduled code freeze: February 4, 2020

Generated by 🚫 dangerJS against 4218c4a

@apeatling
Copy link
Member

Placeholder looked like this for me, using Gutenberg master. All looked aligned however:

Screen Shot 2020-02-07 at 10 55 36 AM

@apeatling
Copy link
Member

Preview looked like this, matching your image above:

Screen Shot 2020-02-07 at 10 56 40 AM

apeatling
apeatling reviewed Feb 7, 2020
View reviewed changes
extensions/blocks/gif/edit.js
label={ INPUT_PROMPT }
placeholder={ INPUT_PROMPT }
onChange={ value => setAttributes( { searchText: value } ) }
<input
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there an issue with the TextControl component? Is there anything there that can be fixed in core Gutenberg?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure. The embed block in core doesn't use it, and we are just following that example. Probably worth asking more about that though...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I asked here but didn't get any insight! https://wordpress.slack.com/archives/C02QB2JS7/p1581590282345300

@scruffian scruffian changed the title Logo block: Update placeholder Gif block: Update placeholder Feb 7, 2020
@jeherve jeherve added this to the 8.3 milestone Feb 10, 2020
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Feb 13, 2020
jeherve
jeherve approved these changes Feb 13, 2020
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. 🚢

@scruffian scruffian merged commit 0865a2a into master Feb 13, 2020
@scruffian scruffian deleted the update/logo-placeholder branch February 13, 2020 17:45
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Feb 13, 2020
@scruffian
Copy link
Member Author

r202851-wpcom

jeherve added a commit that referenced this pull request Feb 25, 2020
@jeherve
Changelog: add #14571
fb6bf2b
jeherve added a commit that referenced this pull request Feb 25, 2020
@jeherve
Changelog: 8.3 running changelog (#14642)
8797bea 
* 8.3 release: changelog

* Changelog: add #14516

* Changelog: add #14574

* Bring in changes from 8.2.1 and 8.2.2

* Update stable version

* Bring in 8.2.3 changes

* Changelog: add #14714

* Changelog: add #14639

* Changelog: add #14678

* Changelog: add #14673

* Changelog: add #14687

* Changelog: add #14704

* Changelog: add #14702

* Changelog: add #14541

* Changelog: add #14657

* Changelog: add #14622

* Changelog: add #14582

* Changelog: add #14638

* Changelog: add #14633

* Changelog: add #14571

* Changelog: add #14592

* Changelog: add #14539

* Changelog: add #14514

* Changelog: add #14643

* Changelog: add #14494

* Changelog: add #13739

* Changelog: add #14707

* Changelog: add #14736

* Changelog: add #14706

* Changelog: add #14730

* Changelog: add #14685

* Changelog: add #14727

* Changelog: add #14711

* Changelog: add #14742

* Changelog: add #14746

* Changelog: add #14725

* Changelog: add #13999

* Changelog: add #14740

* Changelog: add #14759

* Changelog: add #14703

* Changelog: add #14753

* Changelog: add #14754

* Changelog: add #14645

* Cahngelog: add #14599
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apeatling apeatling apeatling left review comments

@jeherve jeherve jeherve approved these changes

Assignees

@scruffian scruffian

Labels
[Block] GIF [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack Touches WP.com Files
Projects
None yet
Milestone
8.3
Development

Successfully merging this pull request may close these issues.
5 participants
@scruffian @matticbot @jetpackbot @apeatling @jeherve