-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenTable: Fix error when pasting embed codes #14678
Conversation
We were accidentally relying on an error being thrown during the onChange handler, when an embed code was pasted into the input. The error meant that the event bubbled up and the onSubmit event handled the input correctly. This change sets the saveTransform function to check if the current input looks like an embed. If it does, then it prevents it from being treated like a token, and the onChange handler is never called.
Caution: This PR has changes that must be merged to WordPress.com |
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: March 3, 2020. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Great catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests well for me.
r203005-wpcom |
* 8.3 release: changelog * Changelog: add #14516 * Changelog: add #14574 * Bring in changes from 8.2.1 and 8.2.2 * Update stable version * Bring in 8.2.3 changes * Changelog: add #14714 * Changelog: add #14639 * Changelog: add #14678 * Changelog: add #14673 * Changelog: add #14687 * Changelog: add #14704 * Changelog: add #14702 * Changelog: add #14541 * Changelog: add #14657 * Changelog: add #14622 * Changelog: add #14582 * Changelog: add #14638 * Changelog: add #14633 * Changelog: add #14571 * Changelog: add #14592 * Changelog: add #14539 * Changelog: add #14514 * Changelog: add #14643 * Changelog: add #14494 * Changelog: add #13739 * Changelog: add #14707 * Changelog: add #14736 * Changelog: add #14706 * Changelog: add #14730 * Changelog: add #14685 * Changelog: add #14727 * Changelog: add #14711 * Changelog: add #14742 * Changelog: add #14746 * Changelog: add #14725 * Changelog: add #13999 * Changelog: add #14740 * Changelog: add #14759 * Changelog: add #14703 * Changelog: add #14753 * Changelog: add #14754 * Changelog: add #14645 * Cahngelog: add #14599
We were accidentally relying on an error being thrown during the
onChange handler, when an embed code was pasted into the input. The
error meant that the event bubbled up and the onSubmit event handled the
input correctly.
Changes proposed in this Pull Request:
This change sets the saveTransform function to check if the current
input looks like an embed. If it does, then it prevents it from being
treated like a token, and the onChange handler is never called.
Is this a new feature or does it add/remove features to an existing part of Jetpack?
This is a bug fix to an existing feature
Testing instructions:
Without this branch, and with the browser developer console open paste in an embed code into an OpenTable block - for example:
Hit Enter or click the Embed button.
Notice that you see an error along the lines of
parsed is null
Do the same thing with this branch and you should not see the error.
Proposed changelog entry for your changes:
I'm not sure this requires a changelog entry, but if it does:
Bug fixed that caused an unhandled error when inserting an OpenTable embed code