Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenTable: Fix error when pasting embed codes #14678

Merged
merged 1 commit into from
Feb 18, 2020

Conversation

pablinos
Copy link
Contributor

We were accidentally relying on an error being thrown during the
onChange handler, when an embed code was pasted into the input. The
error meant that the event bubbled up and the onSubmit event handled the
input correctly.

Changes proposed in this Pull Request:

This change sets the saveTransform function to check if the current
input looks like an embed. If it does, then it prevents it from being
treated like a token, and the onChange handler is never called.

Is this a new feature or does it add/remove features to an existing part of Jetpack?

This is a bug fix to an existing feature

Testing instructions:

Without this branch, and with the browser developer console open paste in an embed code into an OpenTable block - for example:

<script type='text/javascript' src='//www.opentable.com/widget/reservation/loader?rid=412810&type=standard&theme=standard&iframe=true&domain=com&lang=en-US&newtab=false&ot_source=Restaurant%20website'></script>

Hit Enter or click the Embed button.
Notice that you see an error along the lines of parsed is null

Do the same thing with this branch and you should not see the error.

Proposed changelog entry for your changes:

I'm not sure this requires a changelog entry, but if it does:

Bug fixed that caused an unhandled error when inserting an OpenTable embed code

We were accidentally relying on an error being thrown during the
onChange handler, when an embed code was pasted into the input. The
error meant that the event bubbled up and the onSubmit event handled the
input correctly.

This change sets the saveTransform function to check if the current
input looks like an embed. If it does, then it prevents it from being
treated like a token, and the onChange handler is never called.
@pablinos pablinos added [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Block] OpenTable labels Feb 14, 2020
@pablinos pablinos requested a review from a team as a code owner February 14, 2020 14:09
@pablinos pablinos self-assigned this Feb 14, 2020
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello pablinos! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D38920-code before merging this PR. Thank you!

@jetpackbot
Copy link

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: March 3, 2020.
Scheduled code freeze: February 25, 2020

Generated by 🚫 dangerJS against a9ae9a2

Copy link
Member

@scruffian scruffian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great catch!

@jeherve jeherve added this to the 8.3 milestone Feb 17, 2020
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Feb 17, 2020
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well for me.

@scruffian scruffian merged commit a9fec8e into master Feb 18, 2020
@scruffian scruffian deleted the fix/restaurant-picker-embed branch February 18, 2020 12:49
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Feb 18, 2020
@scruffian
Copy link
Member

r203005-wpcom

jeherve added a commit that referenced this pull request Feb 25, 2020
jeherve added a commit that referenced this pull request Feb 25, 2020
* 8.3 release: changelog

* Changelog: add #14516

* Changelog: add #14574

* Bring in changes from 8.2.1 and 8.2.2

* Update stable version

* Bring in 8.2.3 changes

* Changelog: add #14714

* Changelog: add #14639

* Changelog: add #14678

* Changelog: add #14673

* Changelog: add #14687

* Changelog: add #14704

* Changelog: add #14702

* Changelog: add #14541

* Changelog: add #14657

* Changelog: add #14622

* Changelog: add #14582

* Changelog: add #14638

* Changelog: add #14633

* Changelog: add #14571

* Changelog: add #14592

* Changelog: add #14539

* Changelog: add #14514

* Changelog: add #14643

* Changelog: add #14494

* Changelog: add #13739

* Changelog: add #14707

* Changelog: add #14736

* Changelog: add #14706

* Changelog: add #14730

* Changelog: add #14685

* Changelog: add #14727

* Changelog: add #14711

* Changelog: add #14742

* Changelog: add #14746

* Changelog: add #14725

* Changelog: add #13999

* Changelog: add #14740

* Changelog: add #14759

* Changelog: add #14703

* Changelog: add #14753

* Changelog: add #14754

* Changelog: add #14645

* Cahngelog: add #14599
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants