Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storybook: Use webpack 5 everywhere #20891

Merged
merged 1 commit into from
Sep 2, 2021

Conversation

anomiex
Copy link
Contributor

@anomiex anomiex commented Aug 31, 2021

Changes proposed in this Pull Request:

They refactored everything to use either 4 or 5, but left a lot of
webpack 4 deps in various subpackages. Either unused, or using
functionality that wasn't changed between 4 and 5.

This PR adds overrides to force webpack 5 in place of 4. That removes a
bunch of webpack 4 deps on chokidar 2, which is itself deprecated and
depends on a version of glob-parent that pnpm audit complains about.

Jetpack product discussion

None

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Is the build happy?
  • Does the storybook code in the build artifact look good?

@anomiex anomiex added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Janitorial [Pri] Normal labels Aug 31, 2021
@anomiex anomiex self-assigned this Aug 31, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Aug 31, 2021

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

jeherve
jeherve previously approved these changes Sep 1, 2021
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the storybook code in the build artifact look good?

This seems to look good, no issues there!

This is going to need a rebase though.

@jeherve jeherve added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Sep 1, 2021
Base automatically changed from update/various-js-deps to master September 1, 2021 14:25
They refactored everything to use either 4 or 5, but left a lot of
webpack 4 deps in various subpackages. Either unused, or using
functionality that wasn't changed between 4 and 5.

This PR adds overrides to force webpack 5 in place of 4. That removes a
bunch of webpack 4 deps on chokidar 2, which is itself deprecated and
depends on a version of glob-parent that `pnpm audit` complains about.
@anomiex anomiex force-pushed the update/storybook-use-webpack5-everywhere branch from a9a99ef to dd753ed Compare September 1, 2021 14:36
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello anomiex! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D66187-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@anomiex anomiex added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Sep 1, 2021
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Sep 2, 2021
@anomiex anomiex merged commit c683b88 into master Sep 2, 2021
@anomiex anomiex deleted the update/storybook-use-webpack5-everywhere branch September 2, 2021 13:28
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Sep 2, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2021

Great news! One last step: head over to your WordPress.com diff, D66187-code, and commit it.
Once you've done so, come back to this PR and add a comment with your changeset ID.

Thank you!

@anomiex
Copy link
Contributor Author

anomiex commented Sep 2, 2021

r231161-wpcom

davidlonjon added a commit that referenced this pull request Sep 3, 2021
* master:
  Backport Connection Package Changelog from Release (#20942)
  Tiled gallery: fix transform again (#20928)
  Jetpack Sync: Checksums: Better handling of WooCommerce tables (#20937)
  VideoPress Block: New Icon for Edit Button (#20916)
  Backup: fix dashboard styling (#20900)
  Connection: remove invalid user token before reconnect (#20919)
  Widget Visibility build tools: adjust command in readme (#20935)
  storybook: Use webpack 5 everywhere (#20891)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants