Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Widget Visibility build tools: adjust command in readme #20935

Merged
merged 1 commit into from
Sep 2, 2021
Merged

Widget Visibility build tools: adjust command in readme #20935

merged 1 commit into from
Sep 2, 2021

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Sep 2, 2021

Follow-up for #20910

Changes proposed in this Pull Request:

Jetpack product discussion

  • No

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

  • Check for typos?

@jeherve jeherve added this to the jetpack/10.2 milestone Sep 2, 2021
@jeherve jeherve added [Feature] Widget Visibility [Pri] Low [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Janitorial labels Sep 2, 2021
@jeherve jeherve self-assigned this Sep 2, 2021
@jeherve jeherve requested a review from anomiex September 2, 2021 10:15
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello jeherve! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D66279-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@jeherve jeherve enabled auto-merge (squash) September 2, 2021 10:15
@jeherve jeherve mentioned this pull request Sep 2, 2021
Merged
@github-actions github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Sep 2, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2021 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

Jetpack plugin:

  • Next scheduled release: September 7, 2021.
  • Scheduled code freeze: August 30, 2021.

@jeherve
Copy link
Member Author

jeherve commented Sep 2, 2021

r231156-wpcom

@jeherve jeherve merged commit 3e3ffff into master Sep 2, 2021
@jeherve jeherve deleted the update/widget-visibility-editor-readme branch September 2, 2021 13:32
@github-actions github-actions bot removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Sep 2, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2021

Great news! One last step: head over to your WordPress.com diff, D66279-code, and commit it.
Once you've done so, come back to this PR and add a comment with your changeset ID.

Thank you!

davidlonjon added a commit that referenced this pull request Sep 3, 2021
@davidlonjon
Merge branch 'master' into try/boost-javascript-tests-workflow
9f575aa 
* master:
  Backport Connection Package Changelog from Release (#20942)
  Tiled gallery: fix transform again (#20928)
  Jetpack Sync: Checksums: Better handling of WooCommerce tables (#20937)
  VideoPress Block: New Icon for Edit Button (#20916)
  Backup: fix dashboard styling (#20900)
  Connection: remove invalid user token before reconnect (#20919)
  Widget Visibility build tools: adjust command in readme (#20935)
  storybook: Use webpack 5 everywhere (#20891)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anomiex anomiex anomiex approved these changes

Assignees

@jeherve jeherve

Labels
[Feature] Widget Visibility [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Low Touches WP.com Files [Type] Janitorial
Projects
None yet
Milestone
jetpack/10.2
Development

Successfully merging this pull request may close these issues.
3 participants
@jeherve @matticbot @anomiex