Added suppress_filters param to get_posts / get_children function calls.

[spacedmonkey]

Fixes #8624

Changes proposed in this Pull Request:

• Pass suppress_filters to all public facing calls to get_posts / get_children

Testing instructions:

• This is hard to test. There should be no noticeable difference it it works.

Proposed changelog entry for your changes:

Added suppress_filters param to get_posts / get_children function calls.

[zinigor]

Thanks for the contribution!
You are saying that this is hard to test, but in the issue you have provided examples of plugins that may rely on filters not being suppressed. You probably had one or two cases where this change would fix a problem. Can you at least describe that case? Otherwise if it makes almost no difference, as you say, we don't see why it needs to get in.

[spacedmonkey]

Thanks for getting back. Advanced post cache is the perfect example of a use cache then. Out of the box, WP_Query runs a couple of queries and these are uncached. Advanced post cache, used on all WordPress.com sites (even GO VIP), hooks into WP_Query can caches the result of these queries to stop the running on every page load. With this suppress_filtersadvanced post cache doesn't not run. This means queries run unnecessarily and result in high level of traffic to database servers at peak times.

Take for example this query that is running on production.

This query should be cached, specially because it is a LIKE search.

It is hard to test because you have to be running another plugin to take advantage of the performance win here.

[dereksmart]

This sounds reasonable 👍