Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin Page: Fix all eslint warnings except those related to React ES6 classes #8861

Merged
merged 10 commits into from
Feb 16, 2018
Merged

Admin Page: Fix all eslint warnings except those related to React ES6 classes #8861

merged 10 commits into from
Feb 16, 2018

Conversation

oskosk
Copy link
Contributor

@oskosk oskosk commented Feb 16, 2018 •
edited
Loading

Fixes eslint warnings on the Admin Page's code.

After this PR is merged eslint warnings are down from 1193 to 69. The only remaining warnings are shown all related to the react/prefer-es6-class rule.

Testing instructions:

  1. Run node_modules/.bin/eslint --ext .js --ext .jsx _inc/client -c .eslintrc
  2. Confirm that the only warnings you see are related to the react/prefer-es6-class rule.
  3. Run yarn build and confirm that the admin page built ok.

React class warnings are going to be address by #8714.

Changes proposed in this Pull Request:

  • Fixes spaces and var usage after running Run eslint --fix
  • Fixes warnings related to the rule prefer-const.
  • Fixes warnings related to the rule import-docblock.
  • Fixes warnings related to the rule brace-style.
  • Fixes warnings related to the rule operator-linebreak.
  • Fixes warnings related to the rule brace-style.
  • Makes a line marked to not warn on react-no-danger.
  • Fixes warnings related to the rule wpcalypso/i18n-no-this-translate.
  • Fixes warnings related to the rule valid-jsdoc.
  • Downgrades the react/jsx-no-bind rule to be ignored temporarily because this pattern is extensively used.

Changelog entry

  • We removed all linting warnings for the JS code of the Admin page. These were only shown in development builds.

@oskosk oskosk requested review from jeherve and a team as code owners February 16, 2018 18:10
@oskosk oskosk added Admin Page React-powered dashboard under the Jetpack menu [Type] Janitorial [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Feb 16, 2018
@oskosk oskosk requested review from zinigor and dereksmart February 16, 2018 18:16
@oskosk oskosk force-pushed the update/run-eslint-fix branch from ec9214a to b2ec654 Compare February 16, 2018 18:17
@oskosk oskosk changed the title Admin Page: Fixx all eslint warnings except the related to using React ES6 classed Admin Page: Fix all eslint warnings except the related to using React ES6 classed Feb 16, 2018
@oskosk oskosk changed the title Admin Page: Fix all eslint warnings except the related to using React ES6 classed Admin Page: Fix all eslint warnings except the related to using React ES6 classes Feb 16, 2018
withinboredom
withinboredom approved these changes Feb 16, 2018
View reviewed changes
Copy link
Contributor

@withinboredom withinboredom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Lot's of changes, but lets see what breaks!

@oskosk
Copy link
Contributor Author

oskosk commented Feb 16, 2018

Thanks! I'm merging. The page built ok locally and with the Jetpack builder and this will help other devs. If anything breaks I'll fix asap.

@oskosk oskosk merged commit 7e2a783 into master Feb 16, 2018
@oskosk oskosk deleted the update/run-eslint-fix branch February 16, 2018 18:51
@oskosk oskosk removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Feb 16, 2018
@oskosk oskosk added this to the 5.9 milestone Feb 16, 2018
@simison simison mentioned this pull request Feb 16, 2018
Merged
@oskosk oskosk changed the title Admin Page: Fix all eslint warnings except the related to using React ES6 classes Admin Page: Fix all eslint warnings except thosee related to React ES6 classes Feb 17, 2018
@oskosk oskosk changed the title Admin Page: Fix all eslint warnings except thosee related to React ES6 classes Admin Page: Fix all eslint warnings except those related to React ES6 classes Feb 27, 2018
oskosk added a commit that referenced this pull request Feb 27, 2018
@oskosk
Add changelog entry for #8861
4f12239
oskosk added a commit that referenced this pull request Feb 27, 2018
@oskosk
Changelog 5.9: running changelog (#8819)
1174ef5 
* update changelog.txt

* Update readme.txt with scaffolding for 5.9 changelog and release draft shortlink

* Add changelog entry for #8243

* Add changelog entry for #8296

* Add changelog entry for #8367

* Add changelog entry for #8686

* Add changelog entry for #8707

* Add changelog entry for #8709 and #8714

* Add changelog entry for #8729

* Add changelog entry for #8777

* Add changelog entry for #8780

* Add changelog entry for #8786

* Add changelog entry for #8787

* Add changelog entry for #8801 #8805 #8832 #8865 and #8804

* Add changelog entry for #8817

* Add changelog entry for #8822

* Add changelog entry for #8823

* Add changelog entry for #8829

* Add changelog entry for #8834

* move some items to major enhancements

* Add changelog entry for #8836

* Add changelog entry for #8839

* Add changelog entry for #8861

* Add changelog entry for #8862

* Add changelog entry for #8863

* Add changelog entry for #8866

* Add changelog entry for #8870

* Add changelog entry for #8874

* Add changelog entry for #8875

* Add changelog entry for #8881

* Add changelog entry for #8890

* Add changelog entry for #8911

* Add changelog entry for #8927

* Add changelog entry for #8931

* Add changelog entry for #8933

* Add changelog entry for #8930

* fix wording

* typo

* minor fixes

* replace partner scripts for Jetpack Start in changelog entry

* Update to-test.md

* Update to-test.md

* minor style fixes to to-test.md

* minor style fixes to to-test.md

* minor fixes on to-test.md

* Add changelog entry for #8868

* Add changelog entry for #8844

* Add changelog entry for #8664

* Add changelog entry for #8935

* Add changelog entry for #8425

* Add changelog entry for #8625
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@withinboredom withinboredom withinboredom approved these changes

@jeherve jeherve Awaiting requested review from jeherve

@zinigor zinigor Awaiting requested review from zinigor

@dereksmart dereksmart Awaiting requested review from dereksmart

Assignees
No one assigned
Labels
Admin Page React-powered dashboard under the Jetpack menu [Type] Janitorial
Projects
None yet
Milestone
5.9
Development

Successfully merging this pull request may close these issues.
3 participants
@oskosk @withinboredom @matticbot