-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance domain-picker package encapsulation #43045
Changes from 7 commits
b876c0f
b41ad1c
485cba1
bbfd0bf
871f54c
d7bc9d0
702172c
c7bdecd
8f82d03
d1770cf
3cc22fc
bd1e6eb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,6 +9,9 @@ import type { ValuesType } from 'utility-types'; | |
*/ | ||
export const FLOW_ID = 'gutenboarding'; | ||
|
||
export const DOMAINS_SUGGESTION_COUNT_IN_POPOVER = 5; | ||
export const DOMAINS_SUGGESTION_COUNT_IN_MODAL = 10; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not sure these new constants are needed in Gutenboarding. We already know we want a single free domain and there is Then there is the bigger value ( |
||
|
||
/** | ||
* Debounce our input + HTTP dependent select changes | ||
* | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
export const PAID_DOMAINS_TO_SHOW = 5; | ||
export const DOMAIN_SEARCH_DEBOUNCE_INTERVAL = 300; | ||
export const DOMAIN_SUGGESTION_VENDOR = 'variation4_front'; | ||
export const DOMAIN_SUGGESTIONS_STORE = 'automattic/domains/suggestions'; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
@import '../mixins'; | ||
@import '../styles/mixins'; | ||
|
||
.domain-categories { | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After moving
domainCategory
state intoDomainPicker
component, the selected domain category is no longer persisted after closing Domain Modal. Is this something we want? cc: @dubielzykThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what you mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently in production: after I've selected a domain category and then confirm de selection, next time I open the Domain Modal, I find that category already selected.
On this branch: category selection isn't saved from one DomainModal interaction opening to another: https://cloudup.com/cgXioTPqRx6