Editing Toolkit: specify node version in github workflow #45766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matticbot
added
the
[Status] Needs Review
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
ramonjd
added a commit
that referenced
this pull request
Sep 20, 2020
matticbot
removed
the
[Status] Needs Review
|
cc @Automattic/team-calypso this was missed perhaps when Node.js was updated recently? |
|
I don't think it was intentional. Thanks for taking care of it @deBhal! 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
Currently, the Editing toolkit CI is failing:
This is because #45721 updated the required node version, but we're still using the default 12.18.3 provided by ubuntu 18.04, so we need to pull in a newer version of node in line with our other workflows. (Aside: there is a ubutu 20-04, but it's got the same node, so totally don't need to do that)
Testing instructions
As a circle-CI update, we're really just looking for the CI tests to pass.
I rebased #45747 on top of this change as a test, and it's gone from failing to passing, which looks good.
A thorough test would look similar:
OTOH, CI is broken, so breaking it again isn't much of a risk...