Post Normalizer: Refactor rules into individual files #5577
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And make the sync rules truly sync, wrapping them in the main post normalizer.
This really just moves all of the post normalizer rules out of the one massive file into little files. This helps scoping quite a bit and makes it clearer what each rule does and what constants it depends on.
I also took the opportunity to make all of the sync rules look and feel like sync functions. No longer do they take a callback, which implies async behavior, and invoke it synchronously. There is a new wrapper that converts the sync variants to look like the old async-ish version so the refactoring doesn't impact users of the post normalizer.
To test,
Stuff for another PR