Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader: Use the new style post normalization #5643

Merged
merged 3 commits into from
Jun 2, 2016
Merged

Conversation

blowery
Copy link
Contributor

@blowery blowery commented May 27, 2016

#5577 needs to land before this and this will need to be rebased.

This updates the feed-post-store to use the post normalizer in the new way. It no longer uses async to run the rule set and the initial pass is guaranteed to run synchronously.

To test, use the Reader as you normally would and look for any errors in the console. Should work just like before.

@blowery blowery added [Status] In Progress [Feature] Reader The reader site on Calypso. labels May 27, 2016
@blowery
Copy link
Contributor Author

blowery commented May 27, 2016

cc @rralian for an example move looks like

@blowery blowery force-pushed the update/new-post-norm branch from 70ae981 to 62b5835 Compare June 1, 2016 13:37
@blowery blowery force-pushed the update/new-post-norm branch from 62b5835 to 724eaa4 Compare June 1, 2016 13:59
@blowery blowery added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] In Progress labels Jun 1, 2016
@bluefuton
Copy link
Contributor

Looks good to me 🚢

@@ -23,6 +23,7 @@ function debugForPost( post ) {
* If successful, the callback is invoked with `(null, theMutatedPost)`
*/
function normalizePost( post, transforms, callback ) {
console && console.warn( '[DEPRECATED]: Please run the rules you need by hand' );
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oof, need to remove that

@blowery blowery merged commit 1757f7b into master Jun 2, 2016
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 2, 2016
@blowery blowery deleted the update/new-post-norm branch June 2, 2016 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Reader The reader site on Calypso.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants