Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tag to indicate which version of ACIR bb.js is using in tests #1668

Open
kevaundray opened this issue Aug 18, 2023 · 0 comments
Open

Add tag to indicate which version of ACIR bb.js is using in tests #1668

kevaundray opened this issue Aug 18, 2023 · 0 comments
Labels
C-bb-bin Component: Barretenberg executable binary

Comments

@kevaundray
Copy link
Contributor

Problem

Currently bb.js and the bb binary run tests on ACIR bytecode. Its not clear which version of ACIR that it is running against however.

Solution

There are two parts to the solution:

  • Noir needs to add appropriate versioning to the bytecode
  • When bb.js or the bb binaries run tests, they should write a file or indicate somewhere, the version of ACIR that the tests have passed with.

The ACIR version file/indicator is useful for checking released versions and immediately knowing which version of ACIR they were compiled with
@iAmMichaelConnor iAmMichaelConnor added the C-bb.js Component: bb.js - wrapping bberg in js label Aug 20, 2023
@TomAFrench TomAFrench mentioned this issue Sep 2, 2023
Closed
@TomAFrench TomAFrench added C-bb-bin Component: Barretenberg executable binary and removed C-bb.js Component: bb.js - wrapping bberg in js labels Sep 15, 2023
codygunton pushed a commit that referenced this issue Jan 23, 2024
@PhilWindle @jonybur
Merge pull request #1678 from AztecProtocol/defi-bridge-project
40476bb 
* Copied index.html to output (#1661)

* Generate htnl file (#1662)

* Deployment fix (#1663)

* Deployment fixes (#1665)

* Deployment fix attempt (#1667)

* Updated falafel and kebab terraform with new project directory structure (#1670)

* Reduce the amount of logging in kebab (#1668)

* Reduce the amount of logging in kebab

* Logging improvement

* Bug fix

* Reverted erroneous change

* Pw/increase faucet drip (#1669)

* Increased the faucet drip size

* Force contract redeployment

* Deploy terraform from correct directory (#1671)

* JB/Website grants updates (#1666)

* Add new grant

* Improve research images

* Mini typo

* JB/Website build manifest (#1672)

* Add website to build manifest

* JB/Brand iteration (#1673)

* Small build change

* JB/Fix website deployment (#1676)

* Fix deployment

* JB/Fix website deploy (#1677)

* Fix deploy

Co-authored-by: Jonathan Bursztyn <jobur93@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bb-bin Component: Barretenberg executable binary
Projects
A3
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
3 participants
@TomAFrench @kevaundray @iAmMichaelConnor