chore(bb): refactor bb CLI interface #1672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevaundray
commented
Aug 19, 2023
kevaundray
commented
Aug 19, 2023
| process.stdout.write(contract); | ||
| writeFileSync(outputPath, contract); | ||
|
|
||
| debug(`contract written to: ${outputPath}`); |
There was a problem hiding this comment.
All input which is just "information" is printed to debug which should print to stderr, instead of console.log which is printing to stdout
kevaundray
commented
Aug 19, 2023
| @@ -67,6 +67,7 @@ | |||
| "resolve-typescript-plugin": "^2.0.1", | |||
| "ts-jest": "^29.1.0", | |||
| "ts-loader": "^9.4.2", | |||
| "tslib": "^2.6.2", | |||
There was a problem hiding this comment.
This is for #1670
kevaundray
changed the title
|
nit: We should print out byte arrays as hexstrings |
This will now be done as part of #1674 |
TomAFrench
reviewed
Aug 21, 2023
TomAFrench
reviewed
Aug 21, 2023
|
I think |
Thats a good point -- I'm not sure what scope this should be, though bb is better than acir because other parts might use acir when talking about the simulator |
kevaundray
changed the title
codygunton
pushed a commit
that referenced
this pull request
Jan 23, 2024
* Copied index.html to output (#1661) * Generate htnl file (#1662) * Deployment fix (#1663) * Deployment fixes (#1665) * Deployment fix attempt (#1667) * Updated falafel and kebab terraform with new project directory structure (#1670) * Reduce the amount of logging in kebab (#1668) * Reduce the amount of logging in kebab * Logging improvement * Bug fix * Reverted erroneous change * Pw/increase faucet drip (#1669) * Increased the faucet drip size * Force contract redeployment * Deploy terraform from correct directory (#1671) * JB/Website grants updates (#1666) * Add new grant * Improve research images * Mini typo * JB/Website build manifest (#1672) * Add website to build manifest * JB/Brand iteration (#1673) * Small build change * JB/Fix website deployment (#1676) * Fix deployment * JB/Fix website deploy (#1677) * Fix deploy Co-authored-by: Jonathan Bursztyn <jobur93@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1671
Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.