feat: l1-publisher cleanup

[LHerskind]

Doing some cleanup after #7850, looking to address the issue of #8153 and #8110.

• refactor: get rid of time traveler #8153
  • Addressed by including a "watcher" as part of the setup, which will push us to the next slot if there is already a block proposed for the current one.
• refactor: Simulate into the future #8110
  • Updates the logic in the contract such that we can deal with "simulating" in the future, and use this from the sequencer.

Gets rid of the time_traveler from the l1-publisher, now lives in the watcher which is used in tests.

Issues related to slot duration is still to be addressed, so the name of this branch got slightly funky.

Taking over the extra check added in #8204 since i) they are related and ii) the pain of going through CI made me do it.

[LHerskind]

• feat: Removing is_dev_net flag #8275
• chore: rename process to propose for clarity #8265
• feat: moving fee payout + make proof submission sequential #8262
• feat: l1-publisher cleanup #8148 👈
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @LHerskind and the rest of your teammates on Graphite

[AztecBot]

Benchmark results

Metrics with a significant change:

• protocol_circuit_simulation_time_in_ms (private-kernel-tail-to-public): 767 (-44%)
• avm_simulation_time_ms (FeeJuice:set_portal): 13.4 (+34%)
• avm_simulation_time_ms (Token:mint_public): 69.9 (+55%)
• avm_simulation_time_ms (Token:assert_minter_and_mint): 40.2 (-39%)
• avm_simulation_time_ms (Token:transfer_public): 51.1 (+150%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,767	1,554 (-1%)	708 (-1%)	772 (+1%)	766 (-1%)
proof_construction_time_sha256_30_ms	11,482	3,082	1,380	1,449 (+3%)	1,467
proof_construction_time_sha256_100_ms	44,103	11,823	5,423 (-1%)	5,440 (-1%)	5,695
proof_construction_time_poseidon_hash_ms	79.0 (+1%)	34.0	34.0	59.0 (-2%)	88.0 (-1%)
proof_construction_time_poseidon_hash_30_ms	1,530	423	202 (-1%)	222 (+1%)	268
proof_construction_time_poseidon_hash_100_ms	5,643	1,511	671 (-3%)	728	740

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	4,356	7,876	14,884
l1_rollup_calldata_gas	50,208	93,010	178,132
l1_rollup_execution_gas	845,754	1,579,452	3,364,630
l2_block_processing_time_in_ms	268 (+2%)	454	839
l2_block_building_time_in_ms	11,365	22,358 (+1%)	44,635
l2_block_rollup_simulation_time_in_ms	11,364	22,358 (+1%)	44,635
l2_block_public_tx_process_time_in_ms	9,659	20,535 (+1%)	42,772

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	2,965 (-4%)	4,001 (+2%)
node_database_size_in_bytes	12,628,048	16,670,800
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	input_size_in_bytes	output_size_in_bytes	proving_time_in_ms
private-kernel-init	92.5 (+1%)	386 (-2%)	21,735	44,860	N/A
private-kernel-inner	179 (+5%)	689 (-1%)	72,544	45,007	N/A
private-kernel-reset-tiny	312 (+1%)	702 (-2%)	65,593	44,846	N/A
private-kernel-tail	167 (+1%)	133 (-4%)	50,644	52,257	N/A
base-parity	5.59	N/A	160	96.0	N/A
root-parity	35.1 (-1%)	N/A	73,948	96.0	N/A
base-rollup	3,489 (+2%)	N/A	189,136	664	N/A
block-root-rollup	41.2 (-1%)	N/A	58,205	2,448	N/A
public-kernel-setup	84.8	N/A	105,085	71,222	N/A
public-kernel-app-logic	97.2 (+1%)	N/A	104,911	71,222	N/A
public-kernel-tail	858	N/A	390,582	16,414	N/A
private-kernel-reset-small	309 (-1%)	N/A	66,341	45,629	N/A
private-kernel-tail-to-public	⚠️ 767 (-44%)	598 (-3%)	455,400	1,825	N/A
public-kernel-teardown	84.0 (-1%)	N/A	105,349	71,222	N/A
merge-rollup	20.4 (+1%)	N/A	38,174	664	N/A
undefined	N/A	N/A	N/A	N/A	84,713 (+7%)

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms
ContractClassRegisterer:register	1,344	11,731	343
ContractInstanceDeployer:deploy	1,408	11,731	18.3
MultiCallEntrypoint:entrypoint	1,920	11,731	404
FeeJuice:deploy	1,376	11,731	390 (-1%)
SchnorrAccount:constructor	1,312	11,731	73.1 (-1%)
SchnorrAccount:entrypoint	2,304	11,731	396 (+1%)
Token:privately_mint_private_note	1,280	11,731	107 (+5%)
FPC:fee_entrypoint_public	1,344	11,731	25.4 (-15%)
Token:transfer	1,312	11,731	226
Benchmarking:create_note	1,344	11,731	85.5
SchnorrAccount:verify_private_authwit	1,280	11,731	27.7
Token:unshield	1,376	11,731	526
FPC:fee_entrypoint_private	1,376	11,731	696 (-2%)

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
FeeJuice:_increase_public_balance	56.5 (-13%)	7,101
FeeJuice:set_portal	⚠️ 13.4 (+34%)	2,128
Token:constructor	81.3	25,285
FPC:constructor	54.4	17,853
FeeJuice:mint_public	39.6 (-1%)	5,415
Token:mint_public	⚠️ 69.9 (+55%)	10,101
Token:assert_minter_and_mint	⚠️ 40.2 (-39%)	6,844
AuthRegistry:set_authorized	48.9 (+19%)	3,969
FPC:prepare_fee	230 (-1%)	6,747
Token:transfer_public	⚠️ 51.1 (+150%)	38,126
FPC:pay_refund	54.7 (+10%)	9,398
Benchmarking:increment_balance	1,207 (+1%)	6,179
Token:_increase_public_balance	39.7 (-1%)	7,705
FPC:pay_refund_with_shielded_rebate	61.0 (-5%)	9,881

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.162 (+1%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	2.19 (-1%)	3.88 (-2%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.113 (-2%)	0.109 (-3%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	11.2 (-2%)	17.8 (-2%)	30.7 (-5%)	59.9 (+1%)	118 (+2%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.107 (-3%)	0.103 (-2%)	0.0999 (-4%)	0.103 (+1%)	0.105 (+1%)
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	14.2 (-1%)	25.9 (-1%)	44.0 (-2%)	83.3	168 (+2%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.108 (-2%)	0.104	0.106 (-3%)	0.103	0.105 (+1%)
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	16.7	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	132	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.107 (-1%)	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	64,779	668,997

Transaction size based on fee payment method

| Metric | |
| - | |

[LHerskind]

The wording here probably got slightly weird. But it is the block number at the timestamp, e.g., the next block. I am inclined to fix it in a later pr along with other things because of ci times.

[just-mitch]

Should this be an env var?

[LHerskind]

Thought about it but not sure. It is not something we really want to turn "off" by mistake as that would cause some of the failing issues that for example @Maddiaa0 have encountered. The main reason I kept it here was such that it was not needed to add the simulate if one really wanted to simulate those calls.

[just-mitch]

Coming as part of TxObjects I expect?

[LHerskind]

Not really, but we need the header for the validateHeader call so just building it here.