refactor(avm): replace range and cmp with gadgets

[IlyasRidhuan]

Please read contributing guidelines and remove this line.

[IlyasRidhuan]

• feat(avm): integrate new range and cmp gadgets #8165
• refactor(avm): replace range and cmp with gadgets #8164 👈
• feat(avm): range check gadget #7967
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @IlyasRidhuan and the rest of your teammates on Graphite

[AztecBot]

Benchmark results

Metrics with a significant change:

• proof_construction_time_sha256_100_ms (32): 6,519 (+16%)
• protocol_circuit_simulation_time_in_ms (private-kernel-tail-to-public): 1,400 (+109%)
• avm_simulation_time_ms (Token:transfer_public): 25.6 (-38%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,856 (+2%)	1,614 (+3%)	752 (+5%)	800 (+3%)	817 (+5%)
proof_construction_time_sha256_30_ms	11,955 (+4%)	3,189 (+3%)	1,459 (+5%)	1,532 (+7%)	1,572 (+7%)
proof_construction_time_sha256_100_ms	45,189 (+2%)	12,378 (+4%)	5,909 (+7%)	⚠️ 6,519 (+16%)	5,878
proof_construction_time_poseidon_hash_ms	79.0 (+1%)	35.0 (+3%)	36.0 (+6%)	60.0 (+3%)	89.0 (+2%)
proof_construction_time_poseidon_hash_30_ms	1,561 (+2%)	430 (+2%)	212 (+5%)	241 (+5%)	279 (+4%)
proof_construction_time_poseidon_hash_100_ms	5,742 (+2%)	1,538 (+1%)	698 (+3%)	750 (+5%)	798 (+7%)

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	4,356	7,876	14,884
l1_rollup_calldata_gas	50,220	92,984	178,144
l1_rollup_execution_gas	842,880	1,576,540	3,361,756
l2_block_processing_time_in_ms	257 (-2%)	475 (+4%)	805 (-4%)
l2_block_building_time_in_ms	11,436	23,082 (+4%)	44,584
l2_block_rollup_simulation_time_in_ms	11,436	23,082 (+4%)	44,583
l2_block_public_tx_process_time_in_ms	9,764	21,274 (+4%)	42,850

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	3,222 (+6%)	4,342 (+11%)
node_database_size_in_bytes	12,587,088 (-1%)	16,633,936 (-1%)
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	input_size_in_bytes	output_size_in_bytes	proving_time_in_ms
private-kernel-init	91.4	395 (-1%)	21,735	44,860	N/A
private-kernel-inner	175 (-1%)	701 (-1%)	72,544	45,007	N/A
private-kernel-reset-tiny	311	715	65,593	44,846	N/A
private-kernel-tail	168 (+1%)	147 (+9%)	50,644	52,257	N/A
base-parity	5.68 (+1%)	N/A	160	96.0	N/A
root-parity	35.6	N/A	73,948	96.0	N/A
base-rollup	3,200 (+4%)	N/A	189,136	664	N/A
block-root-rollup	41.5	N/A	58,205	2,448	N/A
public-kernel-setup	85.5 (+1%)	N/A	105,085	71,222	N/A
public-kernel-app-logic	99.9 (+2%)	N/A	104,911	71,222	N/A
public-kernel-tail	874 (+2%)	N/A	390,582	16,414	N/A
private-kernel-reset-small	312 (+1%)	N/A	66,341	45,629	N/A
private-kernel-tail-to-public	⚠️ 1,400 (+109%)	614	455,400	1,825	N/A
public-kernel-teardown	84.8 (+1%)	N/A	105,349	71,222	N/A
merge-rollup	20.3 (+1%)	N/A	38,174	664	N/A
undefined	N/A	N/A	N/A	N/A	78,550 (+1%)

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms
ContractClassRegisterer:register	1,344	11,731	346 (+1%)
ContractInstanceDeployer:deploy	1,408	11,731	18.4
MultiCallEntrypoint:entrypoint	1,920	11,731	408 (+1%)
FeeJuice:deploy	1,376	11,731	395 (+2%)
SchnorrAccount:constructor	1,312	11,731	74.4
SchnorrAccount:entrypoint	2,304	11,731	398 (+1%)
Token:privately_mint_private_note	1,280	11,731	109 (+7%)
FPC:fee_entrypoint_public	1,344	11,731	25.4 (-7%)
Token:transfer	1,312	11,731	226 (+1%)
Benchmarking:create_note	1,344	11,731	86.1
SchnorrAccount:verify_private_authwit	1,280	11,731	27.6
Token:unshield	1,376	11,731	524 (+2%)
FPC:fee_entrypoint_private	1,376	11,731	730 (-3%)

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
FeeJuice:_increase_public_balance	59.1 (+1%)	8,174
FeeJuice:set_portal	11.0 (+3%)	4,055
Token:constructor	91.9 (+10%)	29,082
FPC:constructor	59.5 (+8%)	18,940
FeeJuice:mint_public	41.0 (+2%)	6,522
Token:mint_public	46.1 (-8%)	12,704
Token:assert_minter_and_mint	316	8,467
AuthRegistry:set_authorized	38.2 (-18%)	4,194
FPC:prepare_fee	236 (-3%)	6,747
Token:transfer_public	⚠️ 25.6 (-38%)	39,863
FPC:pay_refund	53.8 (-9%)	9,398
Benchmarking:increment_balance	1,241 (+2%)	7,263
Token:_increase_public_balance	43.0 (+4%)	8,686
FPC:pay_refund_with_shielded_rebate	65.4 (+6%)	9,881

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.160

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	2.17 (-2%)	3.87 (-1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.113 (-3%)	0.109 (-1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	11.4 (+2%)	17.7 (-1%)	30.8 (-3%)	60.5 (+2%)	112 (-1%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.109 (+1%)	0.103 (-1%)	0.100 (-2%)	0.104 (+2%)	0.100 (-1%)
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	14.6	26.1 (+1%)	43.8 (-2%)	86.7 (+5%)	160 (-4%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.111	0.105	0.106 (+2%)	0.106 (+3%)	0.102 (-2%)
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	16.9 (+1%)	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	132	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.107 (+1%)	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	64,779	668,997

Transaction size based on fee payment method

| Metric | |
| - | |

[jeanmon]

LGTM but look at my feedback before merging.

[IlyasRidhuan]

Merge activity

• Aug 29, 1:34 PM EDT: @IlyasRidhuan started a stack merge that includes this pull request via Graphite.
• Aug 29, 1:36 PM EDT: Graphite rebased this pull request as part of a merge.
• Aug 29, 2:50 PM EDT: @IlyasRidhuan merged this pull request with Graphite.